languages/cpython
languages/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2024-09-04 15:56:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

gh-96143: subprocess API %s/universal_newlines=/text=/g. (GH-96468)

Browse source 
minor missed test cleanup to use the modern API from the big review.

Automerge-Triggered-By: GH:gpshead
This commit is contained in:
Gregory P. Smith 2022-09-01 02:47:40 -07:00 committed by GitHub
parent 0cd33e11fe
commit e93d1bda77
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Lib/test/test_perf_profiler.py
View file

@ -108,7 +108,7 @@ def baz():
script = make_script(script_dir, "perftest", code)
with subprocess.Popen(
[sys.executable, "-Xperf", script],
universal_newlines=True,
text=True,
stderr=subprocess.PIPE,
stdout=subprocess.PIPE,
) as process:
@ -157,7 +157,7 @@ def baz():
script = make_script(script_dir, "perftest", code)
with subprocess.Popen(
[sys.executable, script],
universal_newlines=True,
text=True,
stderr=subprocess.PIPE,
stdout=subprocess.PIPE,
) as process:
@ -211,7 +211,7 @@ def is_unwinding_reliable():
def perf_command_works():
try:
cmd = ["perf", "--help"]
stdout = subprocess.check_output(cmd, universal_newlines=True)
stdout = subprocess.check_output(cmd, text=True)
except (subprocess.SubprocessError, OSError):
return False
@ -237,7 +237,7 @@ def perf_command_works():
'print("hello")',
)
stdout = subprocess.check_output(
cmd, cwd=script_dir, universal_newlines=True, stderr=subprocess.STDOUT
cmd, cwd=script_dir, text=True, stderr=subprocess.STDOUT
)
except (subprocess.SubprocessError, OSError):
return False