mirror of
https://github.com/python/cpython
synced 2024-09-05 08:17:45 +00:00
GH-83658: make multiprocessing.Pool raise an exception if maxtasksperchild is not None or a positive int (GH-93364)
Closes #83658.
This commit is contained in:
parent
38af903506
commit
e37a158725
|
@ -203,6 +203,9 @@ def __init__(self, processes=None, initializer=None, initargs=(),
|
|||
processes = os.cpu_count() or 1
|
||||
if processes < 1:
|
||||
raise ValueError("Number of processes must be at least 1")
|
||||
if maxtasksperchild is not None:
|
||||
if not isinstance(maxtasksperchild, int) or maxtasksperchild <= 0:
|
||||
raise ValueError("maxtasksperchild must be a positive int or None")
|
||||
|
||||
if initializer is not None and not callable(initializer):
|
||||
raise TypeError('initializer must be a callable')
|
||||
|
|
|
@ -2863,6 +2863,11 @@ def test_pool_worker_lifetime_early_close(self):
|
|||
for (j, res) in enumerate(results):
|
||||
self.assertEqual(res.get(), sqr(j))
|
||||
|
||||
def test_pool_maxtasksperchild_invalid(self):
|
||||
for value in [0, -1, 0.5, "12"]:
|
||||
with self.assertRaises(ValueError):
|
||||
multiprocessing.Pool(3, maxtasksperchild=value)
|
||||
|
||||
def test_worker_finalization_via_atexit_handler_of_multiprocessing(self):
|
||||
# tests cases against bpo-38744 and bpo-39360
|
||||
cmd = '''if 1:
|
||||
|
|
|
@ -0,0 +1 @@
|
|||
Make :class:`multiprocessing.Pool` raise an exception if ``maxtasksperchild`` is not ``None`` or a positive int.
|
Loading…
Reference in a new issue