languages/cpython
languages/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2024-07-21 10:15:53 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

gh-89902: Deprecate non-standard format specifier "N" for Decimal (GH-110508)

Browse source 
It was not documented and only supported in the C implementation.
This commit is contained in:
Serhiy Storchaka 2023-10-08 10:01:39 +03:00 committed by GitHub
parent 6780d63ae5
commit d96a8cdfe2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 29 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Doc/whatsnew/3.13.rst
View file

@ -353,6 +353,10 @@ Deprecated
in :data:`~dis.hasarg` instead.
(Contributed by Irit Katriel in :gh:`109319`.)
* Deprecate non-standard format specifier "N" for :class:`decimal.Decimal`.
It was not documented and only supported in the C implementation.
(Contributed by Serhiy Storchaka in :gh:`89902`.)
Pending Removal in Python 3.14
------------------------------

17
Lib/test/test_decimal.py
View file

@ -1222,6 +1222,23 @@ def get_fmt(x, override=None, fmt='n'):
self.assertEqual(get_fmt(Decimal('-1.5'), dotsep_wide, '020n'),
'-0\u00b4000\u00b4000\u00b4000\u00b4001\u00bf5')
def test_deprecated_N_format(self):
Decimal = self.decimal.Decimal
h = Decimal('6.62607015e-34')
if self.decimal == C:
with self.assertWarns(DeprecationWarning) as cm:
r = format(h, 'N')
self.assertEqual(cm.filename, __file__)
self.assertEqual(r, format(h, 'n').upper())
with self.assertWarns(DeprecationWarning) as cm:
r = format(h, '010.3N')
self.assertEqual(cm.filename, __file__)
self.assertEqual(r, format(h, '010.3n').upper())
else:
self.assertRaises(ValueError, format, h, 'N')
self.assertRaises(ValueError, format, h, '010.3N')
@run_with_locale('LC_ALL', 'ps_AF')
def test_wide_char_separator_decimal_point(self):
# locale with wide char separator and decimal point

2
Misc/NEWS.d/next/Library/2023-10-07-21-12-28.gh-issue-89902.dCokZj.rst Normal file
View file

@ -0,0 +1,2 @@
Deprecate non-standard format specifier "N" for :class:`decimal.Decimal`. It
was not documented and only supported in the C implementation.

6
Modules/_decimal/_decimal.c
View file

@ -3593,6 +3593,12 @@ dec_format(PyObject *dec, PyObject *args)
if (replace_fillchar) {
dec_replace_fillchar(decstring);
}
if (strchr(fmt, 'N') != NULL) {
if (PyErr_WarnEx(PyExc_DeprecationWarning,
"Format specifier 'N' is deprecated", 1) < 0) {
goto finish;
}
}
result = PyUnicode_DecodeUTF8(decstring, size, NULL);