gh-95454: Replace truthy/falsy with true/false (GH-95456)

This commit is contained in:
Robert O'Shea 2022-07-30 08:42:21 +01:00 committed by GitHub
parent 0956b6d9c4
commit cd26595232
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 15 additions and 13 deletions

View file

@ -672,7 +672,7 @@ empty string, all events are passed.
.. method:: filter(record)
Is the specified record to be logged? Returns falsy for no, truthy for
Is the specified record to be logged? Returns false for no, true for
yes. Filters can either modify log records in-place or return a completely
different record instance which will replace the original
log record in any future processing of the event.

View file

@ -833,17 +833,17 @@ def filter(self, record):
Determine if a record is loggable by consulting all the filters.
The default is to allow the record to be logged; any filter can veto
this by returning a falsy value.
this by returning a false value.
If a filter attached to a handler returns a log record instance,
then that instance is used in place of the original log record in
any further processing of the event by that handler.
If a filter returns any other truthy value, the original log record
If a filter returns any other true value, the original log record
is used in any further processing of the event by that handler.
If none of the filters return falsy values, this method returns
If none of the filters return false values, this method returns
a log record.
If any of the filters return a falsy value, this method returns
a falsy value.
If any of the filters return a false value, this method returns
a false value.
.. versionchanged:: 3.2
@ -1017,7 +1017,7 @@ def handle(self, record):
the I/O thread lock.
Returns an instance of the log record that was emitted
if it passed all filters, otherwise a falsy value is returned.
if it passed all filters, otherwise a false value is returned.
"""
rv = self.filter(record)
if isinstance(rv, LogRecord):

View file

@ -449,8 +449,8 @@ def testGetSubTestDescriptionWithoutDocstringAndParams(self):
'(' + __name__ + '.Test_TextTestResult.testGetSubTestDescriptionWithoutDocstringAndParams) '
'(<subtest>)')
def testGetSubTestDescriptionForFalsyValues(self):
expected = 'testGetSubTestDescriptionForFalsyValues (%s.Test_TextTestResult.testGetSubTestDescriptionForFalsyValues) [%s]'
def testGetSubTestDescriptionForFalseValues(self):
expected = 'testGetSubTestDescriptionForFalseValues (%s.Test_TextTestResult.testGetSubTestDescriptionForFalseValues) [%s]'
result = unittest.TextTestResult(None, True, 1)
for arg in [0, None, []]:
with self.subTest(arg):

View file

@ -900,7 +900,7 @@ Kurenkov.
.. nonce: QhQ9RD
.. section: Library
Fixed functools.singledispatch on classes with falsy metaclasses. Patch by
Fixed functools.singledispatch on classes with false metaclasses. Patch by
Ethan Furman.
..

View file

@ -832,7 +832,7 @@ In the traceback module, restore the formatting of exception messages like
.. nonce: 3UhyPo
.. section: Library
Allow falsy values to be used for msg parameter of subTest().
Allow false values to be used for msg parameter of subTest().
..

View file

@ -460,7 +460,7 @@ In the traceback module, restore the formatting of exception messages like
.. nonce: 3UhyPo
.. section: Library
Allow falsy values to be used for msg parameter of subTest().
Allow false values to be used for msg parameter of subTest().
..

View file

@ -4453,7 +4453,7 @@ In the traceback module, restore the formatting of exception messages like
.. nonce: 3UhyPo
.. section: Library
Allow falsy values to be used for msg parameter of subTest().
Allow false values to be used for msg parameter of subTest().
..

View file

@ -0,0 +1,2 @@
Replaced incorrectly written true/false values
in documentiation. Patch by Robert O'Shea