languages/cpython
languages/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2024-09-20 00:11:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Issue #4631: Fix urlopen() result when an HTTP response uses chunked encoding.

Browse source
This commit is contained in:
Antoine Pitrou 2009-02-11 00:39:14 +00:00
parent 651453ace0
commit b353c12a9c
9 changed files with 50 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Lib/http/client.py
View file

@ -249,7 +249,7 @@ def parse_headers(fp):
return email.parser.Parser(_class=HTTPMessage).parsestr(hstring)
class HTTPResponse:
class HTTPResponse(io.RawIOBase):
# strict: If true, raise BadStatusLine if the status line can't be
# parsed as a valid HTTP/1.0 or 1.1 status line. By default it is
@ -471,8 +471,6 @@ def isclosed(self):
# called, meaning self.isclosed() is meaningful.
return self.fp is None
# XXX It would be nice to have readline and __iter__ for this, too.
def read(self, amt=None):
if self.fp is None:
return b""
@ -585,6 +583,9 @@ def _safe_read(self, amt):
amt -= len(chunk)
return b"".join(s)
def fileno(self):
return self.fp.fileno()
def getheader(self, name, default=None):
if self.msg is None:
raise ResponseNotReady()
@ -596,6 +597,11 @@ def getheaders(self):
raise ResponseNotReady()
return list(self.msg.items())
# We override IOBase.__iter__ so that it doesn't check for closed-ness
def __iter__(self):
return self
class HTTPConnection:

2
Lib/io.py
View file

@ -491,7 +491,6 @@ def readline(self, limit: int = -1) -> bytes:
terminator(s) recognized.
"""
# For backwards compatibility, a (slowish) readline().
self._checkClosed()
if hasattr(self, "peek"):
def nreadahead():
readahead = self.peek(1)
@ -533,7 +532,6 @@ def readlines(self, hint=None):
lines will be read if the total size (in bytes/characters) of all
lines so far exceeds hint.
"""
self._checkClosed()
if hint is None or hint <= 0:
return list(self)
n = 0

4
Lib/test/test_httplib.py
View file

@ -42,7 +42,6 @@ def readline(self, length=None):
raise AssertionError('caller tried to read past EOF')
return data
class HeaderTests(TestCase):
def test_auto_headers(self):
# Some headers are added automatically, but should not be added by
@ -245,7 +244,6 @@ def testTimeoutAttribute(self):
self.assertEqual(httpConn.sock.gettimeout(), 30)
httpConn.close()
class HTTPSTimeoutTest(TestCase):
# XXX Here should be tests for HTTPS, there isn't any right now!
@ -257,7 +255,7 @@ def test_attributes(self):
def test_main(verbose=None):
support.run_unittest(HeaderTests, OfflineTest, BasicTest, TimeoutTest,
HTTPSTimeoutTest)
HTTPSTimeoutTest)
if __name__ == '__main__':
test_main()

1
Lib/test/test_io.py
View file

@ -1363,6 +1363,7 @@ def test_io_after_close(self):
self.assertRaises(ValueError, f.fileno)
self.assertRaises(ValueError, f.isatty)
self.assertRaises(ValueError, f.__iter__)
self.assertRaises(ValueError, next, f)
if hasattr(f, "peek"):
self.assertRaises(ValueError, f.peek, 1)
self.assertRaises(ValueError, f.read)

32
Lib/test/test_urllib2_localnet.py
View file

@ -310,7 +310,7 @@ def send_head(self):
self.send_response(response_code)
for (header, value) in headers:
self.send_header(header, value % self.port)
self.send_header(header, value % {'port':self.port})
if body:
self.send_header("Content-type", "text/plain")
self.end_headers()
@ -341,10 +341,17 @@ def tearDown(self):
self.server.stop()
def urlopen(self, url, data=None):
l = []
f = urllib.request.urlopen(url, data)
result = f.read()
f.close()
return result
try:
# Exercise various methods
l.extend(f.readlines(200))
l.append(f.readline())
l.append(f.read(1024))
l.append(f.read())
finally:
f.close()
return b"".join(l)
def start_server(self, responses=None):
if responses is None:
@ -361,7 +368,8 @@ def start_server(self, responses=None):
def test_redirection(self):
expected_response = b"We got here..."
responses = [
(302, [("Location", "http://localhost:%s/somewhere_else")], ""),
(302, [("Location", "http://localhost:%(port)s/somewhere_else")],
""),
(200, [], expected_response)
]
@ -370,6 +378,20 @@ def test_redirection(self):
self.assertEquals(data, expected_response)
self.assertEquals(handler.requests, ["/", "/somewhere_else"])
def test_chunked(self):
expected_response = b"hello world"
chunked_start = (
b'a\r\n'
b'hello worl\r\n'
b'1\r\n'
b'd\r\n'
b'0\r\n'
)
response = [(200, [("Transfer-Encoding", "chunked")], chunked_start)]
handler = self.start_server(response)
data = self.urlopen("http://localhost:%s/" % handler.port)
self.assertEquals(data, expected_response)
def test_404(self):
expected_response = b"Bad bad bad..."
handler = self.start_server([(404, [], expected_response)])

8
Lib/test/test_urllib2net.py
View file

@ -195,7 +195,7 @@ class TimeoutTest(unittest.TestCase):
def test_http_basic(self):
self.assertTrue(socket.getdefaulttimeout() is None)
u = _urlopen_with_retry("http://www.python.org")
self.assertTrue(u.fp.raw._sock.gettimeout() is None)
self.assertTrue(u.fp.fp.raw._sock.gettimeout() is None)
def test_http_default_timeout(self):
self.assertTrue(socket.getdefaulttimeout() is None)
@ -204,7 +204,7 @@ def test_http_default_timeout(self):
u = _urlopen_with_retry("http://www.python.org")
finally:
socket.setdefaulttimeout(None)
self.assertEqual(u.fp.raw._sock.gettimeout(), 60)
self.assertEqual(u.fp.fp.raw._sock.gettimeout(), 60)
def test_http_no_timeout(self):
self.assertTrue(socket.getdefaulttimeout() is None)
@ -213,11 +213,11 @@ def test_http_no_timeout(self):
u = _urlopen_with_retry("http://www.python.org", timeout=None)
finally:
socket.setdefaulttimeout(None)
self.assertTrue(u.fp.raw._sock.gettimeout() is None)
self.assertTrue(u.fp.fp.raw._sock.gettimeout() is None)
def test_http_timeout(self):
u = _urlopen_with_retry("http://www.python.org", timeout=120)
self.assertEqual(u.fp.raw._sock.gettimeout(), 120)
self.assertEqual(u.fp.fp.raw._sock.gettimeout(), 120)
FTP_HOST = "ftp://ftp.mirror.nl/pub/mirror/gnu/"

6
Lib/urllib/request.py
View file

@ -333,7 +333,6 @@ def _call_chain(self, chain, kind, meth_name, *args):
handlers = chain.get(kind, ())
for handler in handlers:
func = getattr(handler, meth_name)
result = func(*args)
if result is not None:
return result
@ -1070,7 +1069,8 @@ def do_open(self, http_class, req):
except socket.error as err: # XXX what error?
raise URLError(err)
resp = addinfourl(r.fp, r.msg, req.get_full_url())
## resp = addinfourl(r.fp, r.msg, req.get_full_url())
resp = addinfourl(r, r.msg, req.get_full_url())
resp.code = r.status
resp.msg = r.reason
return resp
@ -1606,7 +1606,7 @@ def _open_generic_http(self, connection_factory, url, data):
# According to RFC 2616, "2xx" code indicates that the client's
# request was successfully received, understood, and accepted.
if 200 <= response.status < 300:
return addinfourl(response.fp, response.msg, "http:" + url,
return addinfourl(response, response.msg, "http:" + url,
response.status)
else:
return self.http_error(

3
Lib/urllib/response.py
View file

@ -17,7 +17,8 @@ def __init__(self, fp):
self.read = self.fp.read
self.readline = self.fp.readline
# TODO(jhylton): Make sure an object with readlines() is also iterable
if hasattr(self.fp, "readlines"): self.readlines = self.fp.readlines
if hasattr(self.fp, "readlines"):
self.readlines = self.fp.readlines
if hasattr(self.fp, "fileno"):
self.fileno = self.fp.fileno
else:

3
Misc/NEWS
View file

@ -163,6 +163,9 @@ Core and Builtins
Library
-------
- Issue #4631: Fix urlopen() result when an HTTP response uses chunked
encoding.
- Issue #5203: Fixed ctypes segfaults when passing a unicode string to a
function without argtypes (only occurs if HAVE_USABLE_WCHAR_T is false).