mirror of
https://github.com/python/cpython
synced 2024-10-14 10:48:24 +00:00
gh-90195: Unset logger disabled flag when configuring it. (GH-96530)
This commit is contained in:
parent
e5823bf9b5
commit
ac4ddab405
|
@ -869,6 +869,7 @@ def configure_logger(self, name, config, incremental=False):
|
|||
"""Configure a non-root logger from a dictionary."""
|
||||
logger = logging.getLogger(name)
|
||||
self.common_logger_config(logger, config, incremental)
|
||||
logger.disabled = False
|
||||
propagate = config.get('propagate', None)
|
||||
if propagate is not None:
|
||||
logger.propagate = propagate
|
||||
|
|
|
@ -3677,6 +3677,35 @@ def test_config_queue_handler(self):
|
|||
msg = str(ctx.exception)
|
||||
self.assertEqual(msg, "Unable to configure handler 'ah'")
|
||||
|
||||
def test_90195(self):
|
||||
# See gh-90195
|
||||
config = {
|
||||
'version': 1,
|
||||
'disable_existing_loggers': False,
|
||||
'handlers': {
|
||||
'console': {
|
||||
'level': 'DEBUG',
|
||||
'class': 'logging.StreamHandler',
|
||||
},
|
||||
},
|
||||
'loggers': {
|
||||
'a': {
|
||||
'level': 'DEBUG',
|
||||
'handlers': ['console']
|
||||
}
|
||||
}
|
||||
}
|
||||
logger = logging.getLogger('a')
|
||||
self.assertFalse(logger.disabled)
|
||||
self.apply_config(config)
|
||||
self.assertFalse(logger.disabled)
|
||||
# Should disable all loggers ...
|
||||
self.apply_config({'version': 1})
|
||||
self.assertTrue(logger.disabled)
|
||||
del config['disable_existing_loggers']
|
||||
self.apply_config(config)
|
||||
# Logger should be enabled, since explicitly mentioned
|
||||
self.assertFalse(logger.disabled)
|
||||
|
||||
class ManagerTest(BaseTest):
|
||||
def test_manager_loggerclass(self):
|
||||
|
|
Loading…
Reference in a new issue