languages/cpython
languages/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2024-10-14 09:31:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

gh-114887 Reject only sockets of type SOCK_STREAM in create_datagram_endpoint() (#114893)

Browse source 
Also improve exception message.

Co-authored-by: Donghee Na <donghee.na92@gmail.com>
This commit is contained in:
Travis Howse 2024-02-04 03:14:02 +10:00 committed by GitHub
parent 6b53d5fe04
commit 94ec2b9c9c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Lib/asyncio/base_events.py
View file

@ -1340,9 +1340,9 @@ async def create_datagram_endpoint(self, protocol_factory,
allow_broadcast=None, sock=None):
"""Create datagram connection."""
if sock is not None:
if sock.type != socket.SOCK_DGRAM:
if sock.type == socket.SOCK_STREAM:
raise ValueError(
f'A UDP Socket was expected, got {sock!r}')
f'A datagram socket was expected, got {sock!r}')
if (local_addr or remote_addr or
family or proto or flags or
reuse_port or allow_broadcast):

2
Lib/test/test_asyncio/test_base_events.py
View file

@ -1232,7 +1232,7 @@ def test_create_datagram_endpoint_wrong_sock(self):
with sock:
coro = self.loop.create_datagram_endpoint(MyProto, sock=sock)
with self.assertRaisesRegex(ValueError,
'A UDP Socket was expected'):
'A datagram socket was expected'):
self.loop.run_until_complete(coro)
def test_create_connection_no_host_port_sock(self):

2
Misc/NEWS.d/next/Core and Builtins/2024-02-03-04-07-18.gh-issue-114887.uLSFmN.rst Normal file
View file

@ -0,0 +1,2 @@
Changed socket type validation in :meth:`~asyncio.loop.create_datagram_endpoint` to accept all non-stream sockets.
This fixes a regression in compatibility with raw sockets.