mirror of
https://github.com/python/cpython
synced 2024-09-05 16:38:56 +00:00
bpo-35606: Fix math.prod tests using 'start' as keyword parameter (GH-28595)
This commit is contained in:
parent
e649e0658f
commit
84975146a7
|
@ -1803,16 +1803,22 @@ def test_prod(self):
|
|||
self.assertRaises(TypeError, prod)
|
||||
self.assertRaises(TypeError, prod, 42)
|
||||
self.assertRaises(TypeError, prod, ['a', 'b', 'c'])
|
||||
self.assertRaises(TypeError, prod, ['a', 'b', 'c'], '')
|
||||
self.assertRaises(TypeError, prod, [b'a', b'c'], b'')
|
||||
self.assertRaises(TypeError, prod, ['a', 'b', 'c'], start='')
|
||||
self.assertRaises(TypeError, prod, [b'a', b'c'], start=b'')
|
||||
values = [bytearray(b'a'), bytearray(b'b')]
|
||||
self.assertRaises(TypeError, prod, values, bytearray(b''))
|
||||
self.assertRaises(TypeError, prod, values, start=bytearray(b''))
|
||||
self.assertRaises(TypeError, prod, [[1], [2], [3]])
|
||||
self.assertRaises(TypeError, prod, [{2:3}])
|
||||
self.assertRaises(TypeError, prod, [{2:3}]*2, {2:3})
|
||||
self.assertRaises(TypeError, prod, [[1], [2], [3]], [])
|
||||
self.assertRaises(TypeError, prod, [{2:3}]*2, start={2:3})
|
||||
self.assertRaises(TypeError, prod, [[1], [2], [3]], start=[])
|
||||
|
||||
# Some odd cases
|
||||
self.assertEqual(prod([2, 3], start='ab'), 'abababababab')
|
||||
self.assertEqual(prod([2, 3], start=[1, 2]), [1, 2, 1, 2, 1, 2, 1, 2, 1, 2, 1, 2])
|
||||
self.assertEqual(prod([], start={2: 3}), {2:3})
|
||||
|
||||
with self.assertRaises(TypeError):
|
||||
prod([10, 20], [30, 40]) # start is a keyword-only argument
|
||||
prod([10, 20], 1) # start is a keyword-only argument
|
||||
|
||||
self.assertEqual(prod([0, 1, 2, 3]), 0)
|
||||
self.assertEqual(prod([1, 0, 2, 3]), 0)
|
||||
|
|
|
@ -3082,14 +3082,9 @@ math_prod_impl(PyObject *module, PyObject *iterable, PyObject *start)
|
|||
}
|
||||
|
||||
if (result == NULL) {
|
||||
result = PyLong_FromLong(1);
|
||||
if (result == NULL) {
|
||||
Py_DECREF(iter);
|
||||
return NULL;
|
||||
}
|
||||
} else {
|
||||
Py_INCREF(result);
|
||||
result = _PyLong_GetOne();
|
||||
}
|
||||
Py_INCREF(result);
|
||||
#ifndef SLOW_PROD
|
||||
/* Fast paths for integers keeping temporary products in C.
|
||||
* Assumes all inputs are the same type.
|
||||
|
@ -3105,7 +3100,7 @@ math_prod_impl(PyObject *module, PyObject *iterable, PyObject *start)
|
|||
}
|
||||
/* Loop over all the items in the iterable until we finish, we overflow
|
||||
* or we found a non integer element */
|
||||
while(result == NULL) {
|
||||
while (result == NULL) {
|
||||
item = PyIter_Next(iter);
|
||||
if (item == NULL) {
|
||||
Py_DECREF(iter);
|
||||
|
|
Loading…
Reference in a new issue