languages/cpython
languages/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2024-10-06 16:15:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

gh-60203: Always pass True/False as boolean arguments in tests (GH-99983)

Browse source 
Unless we explicitly test non-bool values.
This commit is contained in:
Serhiy Storchaka 2022-12-04 14:28:56 +02:00 committed by GitHub
parent bf26bdf6ac
commit 76f43fc09a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Lib/test/_test_multiprocessing.py
View file

@ -6042,5 +6042,5 @@ def test_semlock_subclass(self):
class SemLock(_multiprocessing.SemLock):
pass
name = f'test_semlock_subclass-{os.getpid()}'
s = SemLock(1, 0, 10, name, 0)
s = SemLock(1, 0, 10, name, False)
_multiprocessing.sem_unlink(name)

2
Lib/test/test_asyncio/test_ssl.py
View file

@ -1689,7 +1689,7 @@ def stop(self):
def run(self):
try:
with self._sock:
self._sock.setblocking(0)
self._sock.setblocking(False)
self._run()
finally:
self._s1.close()

2
Lib/test/test_call.py
View file

@ -559,7 +559,7 @@ def __index__(self):
self.kwargs.clear()
gc.collect()
return 0
x = IntWithDict(dont_inherit=IntWithDict())
x = IntWithDict(optimize=IntWithDict())
# We test the argument handling of "compile" here, the compilation
# itself is not relevant. When we pass flags=x below, x.__index__() is
# called, which changes the keywords dict.

9
Lib/test/test_capi/test_misc.py
View file

@ -138,8 +138,9 @@ def test_seq_bytes_to_charp_array(self):
class Z(object):
def __len__(self):
return 1
self.assertRaises(TypeError, _posixsubprocess.fork_exec,
1,Z(),3,(1, 2),5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23)
with self.assertRaisesRegex(TypeError, 'indexing'):
_posixsubprocess.fork_exec(
1,Z(),True,(1, 2),5,6,7,8,9,10,11,12,13,14,True,True,17,False,19,20,21,22,False)
# Issue #15736: overflow in _PySequence_BytesToCharpArray()
class Z(object):
def __len__(self):
@ -147,7 +148,7 @@ def __len__(self):
def __getitem__(self, i):
return b'x'
self.assertRaises(MemoryError, _posixsubprocess.fork_exec,
1,Z(),3,(1, 2),5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23)
1,Z(),True,(1, 2),5,6,7,8,9,10,11,12,13,14,True,True,17,False,19,20,21,22,False)
@unittest.skipUnless(_posixsubprocess, '_posixsubprocess required for this test.')
def test_subprocess_fork_exec(self):
@ -157,7 +158,7 @@ def __len__(self):
# Issue #15738: crash in subprocess_fork_exec()
self.assertRaises(TypeError, _posixsubprocess.fork_exec,
Z(),[b'1'],3,(1, 2),5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23)
Z(),[b'1'],True,(1, 2),5,6,7,8,9,10,11,12,13,14,True,True,17,False,19,20,21,22,False)
@unittest.skipIf(MISSING_C_DOCSTRINGS,
"Signature information for builtins requires docstrings")

2
Lib/test/test_subprocess.py
View file

@ -3209,7 +3209,7 @@ def __int__(self):
1, 2, 3, 4,
True, True, 0,
None, None, None, -1,
None, "no vfork")
None, True)
self.assertIn('fds_to_keep', str(c.exception))
finally:
if not gc_enabled: