gh-104683: clinic.py: Improve coverage for the parse_converter method (#104729)

This commit is contained in:
Alex Waygood 2023-05-22 00:00:47 +01:00 committed by GitHub
parent f3466bc040
commit 64d1b44a54
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -774,6 +774,45 @@ def test_legacy_converters(self):
module, function = block.signatures
self.assertIsInstance((function.parameters['path']).converter, clinic.str_converter)
def test_legacy_converters_non_string_constant_annotation(self):
expected_failure_message = """\
Error on line 0:
Annotations must be either a name, a function call, or a string.
"""
s = self.parse_function_should_fail('module os\nos.access\n path: 42')
self.assertEqual(s, expected_failure_message)
s = self.parse_function_should_fail('module os\nos.access\n path: 42.42')
self.assertEqual(s, expected_failure_message)
s = self.parse_function_should_fail('module os\nos.access\n path: 42j')
self.assertEqual(s, expected_failure_message)
s = self.parse_function_should_fail('module os\nos.access\n path: b"42"')
self.assertEqual(s, expected_failure_message)
def test_other_bizarre_things_in_annotations_fail(self):
expected_failure_message = """\
Error on line 0:
Annotations must be either a name, a function call, or a string.
"""
s = self.parse_function_should_fail(
'module os\nos.access\n path: {"some": "dictionary"}'
)
self.assertEqual(s, expected_failure_message)
s = self.parse_function_should_fail(
'module os\nos.access\n path: ["list", "of", "strings"]'
)
self.assertEqual(s, expected_failure_message)
s = self.parse_function_should_fail(
'module os\nos.access\n path: (x for x in range(42))'
)
self.assertEqual(s, expected_failure_message)
def test_unused_param(self):
block = self.parse("""
module foo