languages/cpython
languages/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2024-09-16 00:17:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Issue #18520: Fix _PySys_Init(), handle PyDict_SetItemString() errors

Browse source
This commit is contained in:
Victor Stinner 2013-07-22 22:40:00 +02:00
parent f54a574478
commit 580496005d
1 changed files with 21 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
Python/sysmodule.c
View file

@ -1565,17 +1565,24 @@ static struct PyModuleDef sysmodule = {
PyObject *
_PySys_Init(void)
{
PyObject *m, *v, *sysdict, *version_info;
PyObject *m, *sysdict, *version_info;
m = PyModule_Create(&sysmodule);
if (m == NULL)
return NULL;
sysdict = PyModule_GetDict(m);
#define SET_SYS_FROM_STRING(key, value) \
v = value; \
if (v != NULL) \
PyDict_SetItemString(sysdict, key, v); \
Py_XDECREF(v)
#define SET_SYS_FROM_STRING(key, value) \
do { \
int res; \
PyObject *v = (value); \
if (v == NULL) \
return NULL; \
res = PyDict_SetItemString(sysdict, key, v); \
if (res < 0) { \
Py_DECREF(v); \
return NULL; \
} \
} while (0)
/* Check that stdin is not a directory
Using shell redirection, you can redirect stdin to a directory,
@ -1597,10 +1604,10 @@ _PySys_Init(void)
/* stdin/stdout/stderr are now set by pythonrun.c */
PyDict_SetItemString(sysdict, "__displayhook__",
PyDict_GetItemString(sysdict, "displayhook"));
PyDict_SetItemString(sysdict, "__excepthook__",
PyDict_GetItemString(sysdict, "excepthook"));
SET_SYS_FROM_STRING("__displayhook__",
PyDict_GetItemString(sysdict, "displayhook"));
SET_SYS_FROM_STRING("__excepthook__",
PyDict_GetItemString(sysdict, "excepthook"));
SET_SYS_FROM_STRING("version",
PyUnicode_FromString(Py_GetVersion()));
SET_SYS_FROM_STRING("hexversion",
@ -1664,18 +1671,15 @@ _PySys_Init(void)
#endif
if (warnoptions == NULL) {
warnoptions = PyList_New(0);
if (warnoptions == NULL)
return NULL;
}
else {
Py_INCREF(warnoptions);
}
if (warnoptions != NULL) {
PyDict_SetItemString(sysdict, "warnoptions", warnoptions);
}
SET_SYS_FROM_STRING("warnoptions", warnoptions);
v = get_xoptions();
if (v != NULL) {
PyDict_SetItemString(sysdict, "_xoptions", v);
}
SET_SYS_FROM_STRING("_xoptions", get_xoptions());
/* version_info */
if (VersionInfoType.tp_name == NULL) {