languages/cpython
languages/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2024-10-14 16:37:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

bpo-45561: Run smelly.py tool from $(srcdir) (GH-29138)

Browse source
This commit is contained in:
Neil Schemenauer 2021-11-22 23:51:02 -08:00 committed by GitHub
parent 024209401e
commit 457e6a6e96
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Makefile.pre.in
View file

@ -2420,7 +2420,7 @@ distclean: clobber
# Check that all symbols exported by libpython start with "Py" or "_Py" # Check that all symbols exported by libpython start with "Py" or "_Py"
smelly: @DEF_MAKE_RULE@ smelly: @DEF_MAKE_RULE@
$(RUNSHARED) ./$(BUILDPYTHON) Tools/scripts/smelly.py $(RUNSHARED) ./$(BUILDPYTHON) $(srcdir)/Tools/scripts/smelly.py
# Find files with funny names # Find files with funny names
funny: funny:

1
Misc/NEWS.d/next/Build/2021-10-21-14-38-30.bpo-45561.PVqhZE.rst Normal file
View file

@ -0,0 +1 @@
Run smelly.py tool from $(srcdir).

9
Tools/scripts/smelly.py
View file

@ -108,8 +108,11 @@ def check_library(library, dynamic=False):
def check_extensions(): def check_extensions():
print(__file__) print(__file__)
srcdir = os.path.dirname(os.path.dirname(os.path.dirname(__file__))) # This assumes pybuilddir.txt is in same directory as pyconfig.h.
filename = os.path.join(srcdir, "pybuilddir.txt") # In the case of out-of-tree builds, we can't assume pybuilddir.txt is
# in the source folder.
config_dir = os.path.dirname(sysconfig.get_config_h_filename())
filename = os.path.join(config_dir, "pybuilddir.txt")
try: try:
with open(filename, encoding="utf-8") as fp: with open(filename, encoding="utf-8") as fp:
pybuilddir = fp.readline() pybuilddir = fp.readline()
@ -118,7 +121,7 @@ def check_extensions():
return True return True
print(f"Check extension modules from {pybuilddir} directory") print(f"Check extension modules from {pybuilddir} directory")
builddir = os.path.join(srcdir, pybuilddir) builddir = os.path.join(config_dir, pybuilddir)
nsymbol = 0 nsymbol = 0
for name in os.listdir(builddir): for name in os.listdir(builddir):
if not name.endswith(".so"): if not name.endswith(".so"):