languages/cpython
languages/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2024-07-20 09:45:46 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

bpo-41361: Optimized argument parsing for deque_rotate (GH-24796)

Browse source
This commit is contained in:
Dennis Sweeney 2021-03-16 00:02:25 -04:00 committed by GitHub
parent d69ae758a0
commit 448801da96
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Misc/NEWS.d/next/Library/2021-03-13-08-18-01.bpo-41361.lXDIlr.rst Normal file
View file

@ -0,0 +1 @@
:meth:`~collections.deque.rotate` calls are now slightly faster due to faster argument parsing.

13
Modules/_collectionsmodule.c
View file

@ -880,9 +880,20 @@ deque_rotate(dequeobject *deque, PyObject *const *args, Py_ssize_t nargs)
{
Py_ssize_t n=1;
if (!_PyArg_ParseStack(args, nargs, "|n:rotate", &n)) {
if (!_PyArg_CheckPositional("deque.rotate", nargs, 0, 1)) {
return NULL;
}
if (nargs) {
PyObject *index = _PyNumber_Index(args[0]);
if (index == NULL) {
return NULL;
}
n = PyLong_AsSsize_t(index);
Py_DECREF(index);
if (n == -1 && PyErr_Occurred()) {
return NULL;
}
}
if (!_deque_rotate(deque, n))
Py_RETURN_NONE;