languages/cpython
languages/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2024-09-19 21:11:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Issue #22421 - Secure pydoc server run. Bind it to localhost instead of all interfaces.

Browse source
This commit is contained in:
Senthil Kumaran 2014-09-17 13:17:58 +08:00
parent 7d0b8f95e7
commit 2a42a0bff3
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Lib/pydoc.py
View file

@ -2168,8 +2168,8 @@ def log_message(self, *args):
class DocServer(http.server.HTTPServer):
def __init__(self, port, callback):
self.host = (sys.platform == 'mac') and '127.0.0.1' or 'localhost'
self.address = ('', port)
self.host = 'localhost'
self.address = (self.host, port)
self.callback = callback
self.base.__init__(self, self.address, self.handler)
self.quit = False

2
Lib/test/test_pydoc.py
View file

@ -557,6 +557,8 @@ def my_url_handler(url, content_type):
return text
serverthread = pydoc._start_server(my_url_handler, port=0)
self.assertIn('localhost', serverthread.docserver.address)
starttime = time.time()
timeout = 1 #seconds