From 164a017e13ee96bd1ea1ae79f5ac9e25fe83994e Mon Sep 17 00:00:00 2001 From: "Gregory P. Smith" Date: Wed, 2 Feb 2022 12:15:16 -0800 Subject: [PATCH] bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (#31015) Disable compiler optimization within test_peg_generator. This speed up test_peg_generator by always disabling compiler optimizations by using -O0 or equivalent when the test is building its own C extensions. A build not using --with-pydebug in order to speed up test execution winds up with this test taking a very long time as it would do repeated compilation of parser C code using the same optimization flags as CPython was built with. This speeds the test up 6-8x on gps-raspbian. Also incorporate's #31017's win32 conditional and flags. Co-authored-by: Kumar Aditya kumaraditya303 --- .../Tests/2022-01-29-12-37-53.bpo-46576.-prRaV.rst | 3 +++ Tools/peg_generator/pegen/build.py | 10 ++++++++++ 2 files changed, 13 insertions(+) create mode 100644 Misc/NEWS.d/next/Tests/2022-01-29-12-37-53.bpo-46576.-prRaV.rst diff --git a/Misc/NEWS.d/next/Tests/2022-01-29-12-37-53.bpo-46576.-prRaV.rst b/Misc/NEWS.d/next/Tests/2022-01-29-12-37-53.bpo-46576.-prRaV.rst new file mode 100644 index 00000000000..be50fc8cbe0 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2022-01-29-12-37-53.bpo-46576.-prRaV.rst @@ -0,0 +1,3 @@ +test_peg_generator now disables compiler optimization when testing +compilation of its own C extensions to significantly speed up the +testing on non-debug builds of CPython. diff --git a/Tools/peg_generator/pegen/build.py b/Tools/peg_generator/pegen/build.py index c69e5c9a5f2..78789b94df2 100644 --- a/Tools/peg_generator/pegen/build.py +++ b/Tools/peg_generator/pegen/build.py @@ -1,6 +1,7 @@ import itertools import pathlib import shutil +import sys import sysconfig import tempfile import tokenize @@ -32,6 +33,7 @@ def compile_c_extension( build_dir: Optional[str] = None, verbose: bool = False, keep_asserts: bool = True, + disable_optimization: bool = True, # Significant test_peg_generator speedup. ) -> str: """Compile the generated source for a parser generator into an extension module. @@ -61,6 +63,14 @@ def compile_c_extension( extra_link_args = get_extra_flags("LDFLAGS", "PY_LDFLAGS_NODIST") if keep_asserts: extra_compile_args.append("-UNDEBUG") + if disable_optimization: + if sys.platform == 'win32': + extra_compile_args.append("/Od") + extra_link_args.append("/LTCG:OFF") + else: + extra_compile_args.append("-O0") + if sysconfig.get_config_var("GNULD") == "yes": + extra_link_args.append("-fno-lto") extension = [ Extension( extension_name,