languages/cpython
languages/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2024-10-14 19:40:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

gh-101936: Update the default value of fp from io.StringIO to io.BytesIO (gh-102100)

Browse source 
Co-authored-by: Long Vo <long.vo@linecorp.com>
This commit is contained in:
Vo Hoang Long 2023-02-21 22:14:41 +07:00 committed by GitHub
parent c2b85a95a5
commit 0d4c7fcd4f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Lib/test/test_urllib2.py
View file

@ -1827,6 +1827,7 @@ def test_HTTPError_interface(self):
def test_gh_98778(self):
x = urllib.error.HTTPError("url", 405, "METHOD NOT ALLOWED", None, None)
self.assertEqual(getattr(x, "__notes__", ()), ())
self.assertIsInstance(x.fp.read(), bytes)
def test_parse_proxy(self):
parse_proxy_test_cases = [

2
Lib/urllib/error.py
View file

@ -43,7 +43,7 @@ def __init__(self, url, code, msg, hdrs, fp):
self.fp = fp
self.filename = url
if fp is None:
fp = io.StringIO()
fp = io.BytesIO()
self.__super_init(fp, hdrs, url, code)
def __str__(self):

1
Misc/ACKS
View file

@ -1898,6 +1898,7 @@ Kurt Vile
Norman Vine
Pauli Virtanen
Frank Visser
Long Vo
Johannes Vogel
Michael Vogt
Radu Voicilas

2
Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.QVOxHH.rst Normal file
View file

@ -0,0 +1,2 @@
The default value of ``fp`` becomes :class:`io.BytesIO` if :exc:`~urllib.error.HTTPError`
is initialized without a designated ``fp`` parameter. Patch by Long Vo.