speed hack can be implemented more cleanly by directly calling __new__

This commit is contained in:
Benjamin Peterson 2010-08-21 02:45:15 +00:00
parent bf6f31b65f
commit 0cc7444ea9

View file

@ -12,10 +12,6 @@
# hashing module used. Use digest_size from the instance of HMAC instead.
digest_size = None
# A unique object passed by HMAC.copy() to the HMAC constructor, in order
# that the latter return very quickly. HMAC("") in contrast is quite
# expensive.
_secret_backdoor_key = object()
class HMAC:
"""RFC 2104 HMAC class. Also complies with RFC 4231.
@ -36,9 +32,6 @@ def __init__(self, key, msg = None, digestmod = None):
Note: key and msg must be bytes objects.
"""
if key is _secret_backdoor_key: # cheap
return
if not isinstance(key, bytes):
raise TypeError("expected bytes, but got %r" % type(key).__name__)
@ -89,7 +82,8 @@ def copy(self):
An update to this copy won't affect the original object.
"""
other = self.__class__(_secret_backdoor_key)
# Call __new__ directly to avoid the expensive __init__.
other = self.__class__.__new__(self.__class__)
other.digest_cons = self.digest_cons
other.digest_size = self.digest_size
other.inner = self.inner.copy()