languages/cpython
languages/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython synced 2024-09-16 03:39:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

gh-90623: signal.raise_signal() calls PyErr_CheckSignals() (#91756)

Browse source 
signal.raise_signal() and os.kill() now call PyErr_CheckSignals() to
check immediately for pending signals.
This commit is contained in:
Victor Stinner 2022-04-21 03:14:57 +02:00 committed by GitHub
parent c77953b23e
commit 031f1e6040
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Misc/NEWS.d/next/Library/2022-04-20-18-47-27.gh-issue-90623.5fROpX.rst Normal file
View file

@ -0,0 +1,2 @@
:func:`signal.raise_signal` and :func:`os.kill` now check immediately for
pending signals. Patch by Victor Stinner.

11
Modules/posixmodule.c
View file

@ -7929,8 +7929,17 @@ os_kill_impl(PyObject *module, pid_t pid, Py_ssize_t signal)
return NULL;
}
#ifndef MS_WINDOWS
if (kill(pid, (int)signal) == -1)
if (kill(pid, (int)signal) == -1) {
return posix_error();
}
// Check immediately if the signal was sent to the current process.
// Don't micro-optimize pid == getpid(), since PyErr_SetString() check
// is cheap.
if (PyErr_CheckSignals()) {
return NULL;
}
Py_RETURN_NONE;
#else /* !MS_WINDOWS */
PyObject *result;

7
Modules/signalmodule.c
View file

@ -481,6 +481,13 @@ signal_raise_signal_impl(PyObject *module, int signalnum)
if (err) {
return PyErr_SetFromErrno(PyExc_OSError);
}
// If the current thread can handle signals, handle immediately
// the raised signal.
if (PyErr_CheckSignals()) {
return NULL;
}
Py_RETURN_NONE;
}