kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-09-12 12:54:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
5701 commits 139 branches 325 tags 154 MiB
C++ 97.9%
CMake 1.5%
Ruby 0.3%
Python 0.3%
Find a file
David Hallas f2b72c1648 Fix crash at shutdown after showing a tooltip 
Summary:
Fix crash at shutdown after showing a tooltip. The commit
94d7e1471e introduced a crash that occurs
when closing Dolphin after Dolphin has showed a tooltip. This happens
because the ToolTipManager::showToolTip function calls the
KToopTipWidget::showBelow function passing in the pointer to the
DolphinFileMetaDataWidget. But this also passes the ownership of the
pointer to the KToopTipWidget as long as a new tooltip is not shown. The
problem is that at shutdown, the KToopTipWidget instance will be
destoyed first and therefore also destroy the DolphinFileMetaDataWidget
instance (which the ToolTipManager still owns through the
QScopedPointer) causing it to be deleted twice. The fix for this is
simply to swap the order of these two members so that the
DolphinFileMetaDataWidget is destroyed first by the QScopedPointer
thereby removing it from the KToopTipWidget if it has been set as it's
parent.

Test Plan:
Open Dolphin
Show a Tool Tip
Close Dolphin

Reviewers: #dolphin, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D19737
2019-03-17 18:09:02 +01:00
cmake Fix "make install" with ninja. 2015-07-29 22:53:06 +02:00
doc Update screenshot 2019-03-13 12:53:12 +02:00
src Fix crash at shutdown after showing a tooltip 2019-03-17 18:09:02 +01:00
.arcconfig Add .arcconfig file for phabricator 2017-02-05 11:09:21 +01:00
.gitignore Added .kdev4 to gitignore 2017-02-18 23:00:48 +01:00
AUTHORS updated to KDE 4 (the file was valid for Dolphin for KDE 3) 2008-07-07 09:18:51 +00:00
CMakeLists.txt GIT_SILENT Upgrade KDE Applications version to 19.07.70. 2019-03-16 22:11:47 +01:00
COPYING commited initial version of Dolphin 2006-11-21 06:02:05 +00:00
COPYING.DOC updates for new licence policy 2008-01-12 16:39:07 +00:00
dolphin.categories Autogenerate debug file + install debug categories file 2018-11-02 13:23:10 +01:00
DolphinVcsConfig.cmake.in Use CMakePackageConfigHelpers instead of the ECM variant 2017-12-01 19:27:57 +01:00
org.kde.dolphin.FileManager1.service.in Add dbus interface to dolphin 2015-04-22 18:59:39 +05:30
README it's http://dolphin.kde.org/ now 2008-07-26 14:01:34 +00:00

README 

See http://dolphin.kde.org for information about Dolphin.