mirror of
https://invent.kde.org/system/dolphin
synced 2024-09-20 00:41:23 +00:00
ccdd7c9a44
selection cache was invalidated just after a listview recreate but accessed before this invalidation due to setCurrent resulting in a handleCurrentChanged call. attempt to fix the vg warning in paintCell svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=260288
132 lines
5.7 KiB
Plaintext
132 lines
5.7 KiB
Plaintext
BUGS
|
|
----
|
|
|
|
general xbel bug: http://bugzilla.gnome.org/show_bug.cgi?id=69702
|
|
tbcache: don't create a tbcache file when its gonna be empty in any case!!!
|
|
historymgr: get dirtyness working for the kbookmarkmap
|
|
proper readonly support - rmb should work but things should be disabled? no addbookmark, etc.
|
|
multi selection deletion then shift down selects roots
|
|
clicking in the increm. search text field selects the root item in the list view
|
|
tips dialog - fixes bugs - shortcuts for keyboard selection are wierd
|
|
selecting a closed folder should selected all items inside - i.e, the outer parent
|
|
show a partial highlight of items that are implicitly selected
|
|
|
|
TODO
|
|
----
|
|
|
|
bookmarklets: add some examples!
|
|
main bookmark config:
|
|
make the keditbookmarks prefs persistant
|
|
and make a simple include selector using
|
|
for example kautoconfig, including a
|
|
simple dynamic menu config gui
|
|
|
|
THINGS FOR 3.3+
|
|
------------------
|
|
|
|
tools:
|
|
recursive 404 finder
|
|
duplicate finder
|
|
|
|
basic gui:
|
|
split view stuff - including filtered views
|
|
need to get keyboard shortcut changes working somehow (wheels)
|
|
have to get dynamic filtering (e.g sorting, pruning),
|
|
|
|
CHECKS
|
|
------
|
|
|
|
valgrind report:
|
|
|
|
on startup:
|
|
==31246== Conditional jump or move depends on uninitialised value(s)
|
|
==31246== at 0x4026A4DF: KEBListViewItem::paintCell(QPainter*, QColorGroup const&, int, int, int) (listview.cpp:786)
|
|
==31246== by 0x40FD9CA7: QListView::drawContentsOffset(QPainter*, int, int, int, int, int, int) (qlistview.cpp:2905)
|
|
==31246== by 0x41013A5D: QScrollView::viewportPaintEvent(QPaintEvent*) (qscrollview.cpp:1702)
|
|
==31246== by 0x407E7051: KListView::viewportPaintEvent(QPaintEvent*) (klistview.cpp:1872)
|
|
==31246==
|
|
==31246== Conditional jump or move depends on uninitialised value(s)
|
|
==31246== at 0x4026A4E4: KEBListViewItem::paintCell(QPainter*, QColorGroup const&, int, int, int) (listview.cpp:786)
|
|
==31246== by 0x40FD9CA7: QListView::drawContentsOffset(QPainter*, int, int, int, int, int, int) (qlistview.cpp:2905)
|
|
==31246== by 0x41013A5D: QScrollView::viewportPaintEvent(QPaintEvent*) (qscrollview.cpp:1702)
|
|
==31246== by 0x407E7051: KListView::viewportPaintEvent(QPaintEvent*) (klistview.cpp:1872)
|
|
==31246==
|
|
==31246== Conditional jump or move depends on uninitialised value(s)
|
|
==31246== at 0x4026A4E8: KEBListViewItem::paintCell(QPainter*, QColorGroup const&, int, int, int) (listview.cpp:786)
|
|
==31246== by 0x40FD9CA7: QListView::drawContentsOffset(QPainter*, int, int, int, int, int, int) (qlistview.cpp:2905)
|
|
==31246== by 0x41013A5D: QScrollView::viewportPaintEvent(QPaintEvent*) (qscrollview.cpp:1702)
|
|
==31246== by 0x407E7051: KListView::viewportPaintEvent(QPaintEvent*) (klistview.cpp:1872)
|
|
==31246==
|
|
|
|
lots of crap when using file->open
|
|
|
|
with memcheck
|
|
==20415== 420 bytes in 14 blocks are definitely lost in loss record 107 of 146
|
|
==20415== at 0x40029B01: __builtin_new (in /usr/lib/valgrind/vgskin_memcheck.so)
|
|
==20415== by 0x40029B6C: operator new(unsigned) (in /usr/lib/valgrind/vgskin_memcheck.so)
|
|
==20415== by 0x402669AA: KEBListView::itemList() (listview.cpp:682)
|
|
==20415== by 0x402634EA: ListView::selectedItems() const (qptrlist.h:157)
|
|
|
|
STUFF:
|
|
|
|
Bookmark current tabs as tabset/folder? :-)
|
|
I just wonder how to unset "Show in Toolbar". Shoudln't it be a toggle action?
|
|
And the "Cancel" entries in the "Bookmark" menus looks strange too. How about
|
|
a KMail-like progress bar (in a status bar?) with an "X" button to stop them?
|
|
And "Advanced Add Bookmark" doesn't work for "Add Bookmark" in context menu?
|
|
|
|
---
|
|
|
|
> > Do you still plan to move those options? And make features like "Quick
|
|
> > Actions" non-dependent on the "Advanced Add Bookmark" functionality?
|
|
> yup, for certain. and want to make them all instant apply for 3.2.
|
|
|
|
Fine. And any plans to reorder the RMB/"Quick actions" entries to be more
|
|
logical/synchronious to each other and other Konqueror context menus? :-)
|
|
|
|
Folder: Bookmark:
|
|
"Add Bookmark Here" "Delete Bookmark"
|
|
"Delete Folder "Copy Link Location"
|
|
"Open Folder in Bookmarks Editor" "Open Bookmark"
|
|
"Properties" "Add Bookmark Here"
|
|
"Open Folder in Tabs" "Properties"
|
|
"Open in New Tab"
|
|
|
|
Like moving "Properties" to last entry as in the Konqueror file manager
|
|
context menus? And moving destructive actions down from 1st/2nd place?
|
|
|
|
"Add Bookmark Here" when pointing at a bookmark looks strange and if you
|
|
call it you have to close and reopen the menu to see an entry was added?
|
|
|
|
And is "Open Bookmark" in context menu necessary? Anyway, my proposal:
|
|
|
|
Folder: Bookmark:
|
|
"Add Bookmark Here" "Open Bookmark"
|
|
"Open Folder in Tabs" "Open in New Tab"
|
|
"Open Folder in Editor" "Copy Link Location"
|
|
"---" "---"
|
|
"Delete Folder" "Delete Bookmark"
|
|
"---" "---"
|
|
"---" "---"
|
|
"Properties" "Properties"
|
|
|
|
Btw, if you want to "Delete Folder" it wants to confirm "Delete Bookmark?".
|
|
|
|
----
|
|
|
|
Btw, I think when you have no tab and call "Bookmarks Tabs as Folder..."
|
|
it should not only create a folder but bookmark the current page within
|
|
the folder unconditional if it's a tab or not. :-)
|
|
|
|
----
|
|
|
|
bookmarkinfo.ui: colons?
|
|
|
|
|
|
TESTING::
|
|
|
|
favicon and status check updates:
|
|
removal of items while checks are happening
|
|
program exit with checks and updates are still going on
|
|
random deletion of all items
|