kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-08-22 09:50:12 +00:00
Code Issues Packages Projects Releases Wiki Activity
5186 commits 137 branches 324 tags 136 MiB
C++ 97.9%
CMake 1.5%
Ruby 0.3%
Python 0.3%
Go to file
Elvis Angelaccio c85ca11455 Ignore drops-onto-items from invalid places items 
If the QMimeData object created by PlacesItemModel doesn't have any url
set (e.g. when dragging unmounted devices), it is detected by the
resulting DropJob as "drop raw data" because the mimeData has one format set
(the internalMimeType() used for dragging between places items).

This results in a crash because the DropJob schedules a PasteJob, but in
the meantime the QDrag from Dolphin ends and deletes the mimeData object
that was passed to the paste job.

The fix is to prevent the DropJob in the first place. We can introduce a
new internal mimetype that we use to blacklist drops-onto-items (while
still allowing drops-between-items). This way PlacesItemModel can set
the blacklist flag if the mimeData is being created without urls.

BUG: 373005
FIXED-IN: 17.04.3

Test Plan:
Drag and drop an unmounted device to another place item or the DolphinView, doesn't crash anymore.
Dropping the unmounted device between two places item still works.

Differential Revision: https://phabricator.kde.org/D5535
2017-06-11 19:11:56 +02:00
cmake Fix "make install" with ninja. 2015-07-29 22:53:06 +02:00
doc Remove extra dot 2016-12-05 07:33:58 +02:00
src Ignore drops-onto-items from invalid places items 2017-06-11 19:11:56 +02:00
.arcconfig Add .arcconfig file for phabricator 2017-02-05 11:09:21 +01:00
.gitignore Added .kdev4 to gitignore 2017-02-18 23:00:48 +01:00
.reviewboardrc added .reviewboardrc 2015-02-26 14:38:31 +01:00
AUTHORS updated to KDE 4 (the file was valid for Dolphin for KDE 3) 2008-07-07 09:18:51 +00:00
CMakeLists.txt GIT_SILENT Upgrade KDE Applications version to 17.04.2. 2017-06-05 20:52:31 +02:00
COPYING commited initial version of Dolphin 2006-11-21 06:02:05 +00:00
COPYING.DOC updates for new licence policy 2008-01-12 16:39:07 +00:00
DolphinVcsConfig.cmake.in Move the KVersionControlPlugin2 interface from konqlib to Dolphin and remove the deprecated KVersionControlPlugin interface from konqlib 2015-02-25 17:21:10 +01:00
org.kde.dolphin.FileManager1.service.in Add dbus interface to dolphin 2015-04-22 18:59:39 +05:30
README it's http://dolphin.kde.org/ now 2008-07-26 14:01:34 +00:00

README 

See http://dolphin.kde.org for information about Dolphin.