mirror of
https://invent.kde.org/system/dolphin
synced 2024-11-05 18:47:12 +00:00
No description
84b40da88d
When we remove items from the model, we called the function KFileItemModel::removeItems(const KFileItemList&, RemoveItemsBehavior). This function then looked up the indexes of the items using the hash m_items. This is wasteful in the situations when the indexes of the removed items are known in advance (like when an expanded folder is collapsed in Details View), and it can cause trouble if one item is contained in the model multiple times (can happen when searching, and a file both matches the search and is a child of a folder that matches the search). Even if expanding folders in the search results list might not be particularly useful most of the time, it makes sense to make the model more robust to prevent crashes and other unexpected behavior in such situations. This patch makes the following changes to achieve that goal: * Change the argument of removeItems() from KFileItemList to KItemRangeList. To make this work, the "look the indexes up in m_items" code is moved from that function to slotItemsDeleted(). In the other places where removeItems() is called, the indexes are calculated directly (which is not more difficult than determining the removed items as a KFileItemList, if one considers that we needed the function childItems(KFileItem) for that, which is not needed any more with this patch). * Also removeFilteredChildren() takes a KItemRangeList now. Rather than putting the parent KFileItems into a QSet for O(1) lookup (which prevents O(N^2) worst case behavior for the entire function), it uses a QSet<ItemData*> now, which should even be more efficient (hashing a pointer is cheaper than hashing a KFileItem/KUrl). BUG: 324371 BUG: 325359 FIXED-IN: 4.12.0 REVIEW: 113070 |
||
|---|---|---|
| doc | ||
| dolphin | ||
| kdepasswd | ||
| kdialog | ||
| keditbookmarks | ||
| kfind | ||
| konq-plugins | ||
| konqueror | ||
| lib | ||
| nsplugins | ||
| plasma | ||
| CMakeLists.txt | ||
| config-apps.h.cmake | ||
| ConfigureChecks.cmake | ||
| COPYING | ||
| COPYING.DOC | ||
| COPYING.LIB | ||
| CTestConfig.cmake | ||
| Mainpage.dox | ||
| README | ||
KDE Base Applications consists of what runs on the desktop. This module isn't a complete collection of essential applications that a user would expect on a desktop (such as e-mail and calculator). This packages is the basic set of applications beyond the workspace that KDE applications can assume are installed. These applications should have no problem running on Windows, OS X, Gnome, etc as stand alone applications if the user wanted to use them there.