dolphin/src/dolphincontextmenu.h
Nathaniel Graham b9143a55a7 Move "Open" actions to the top of the context menu for files
Summary:
This patch moves the "Open", "Open With", and "Open in" items to the top of the context menu to reap the following benefits:
- Move the "Open" and "Open With" items closer to the top since they're commonly used items, and right now they're buried in the middle of the menu
- Group related functionality
- Consistency with other common platforms (macOS Finder and Windows Explorer both have these items at the top of the context menu)

For folders, the "Open With" entries are moved higher, but not all the way to the top, since the "open in New tab/folder" entries are more useful.

Test Plan:
Tested all menu items in the context menu for files, folders, and links; all still work.

Context menu for single file:
{F5806809}

Context menu for multiple files:
{F5806810}

Context menu for single folder:
{F5806811}

Context menu for multiple folders:
{F5806812}

Context menu for symlink to folder:
{F5806815}

Reviewers: #dolphin, #vdg, elvisangelaccio, abetts

Reviewed By: #dolphin, #vdg, elvisangelaccio, abetts

Subscribers: markg, abetts, elvisangelaccio

Differential Revision: https://phabricator.kde.org/D11884
2018-04-22 09:40:50 -06:00

173 lines
5.3 KiB
C++

/***************************************************************************
* Copyright (C) 2006 by Peter Penz <peter.penz19@gmail.com> *
* *
* This program is free software; you can redistribute it and/or modify *
* it under the terms of the GNU General Public License as published by *
* the Free Software Foundation; either version 2 of the License, or *
* (at your option) any later version. *
* *
* This program is distributed in the hope that it will be useful, *
* but WITHOUT ANY WARRANTY; without even the implied warranty of *
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License *
* along with this program; if not, write to the *
* Free Software Foundation, Inc., *
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA *
***************************************************************************/
#ifndef DOLPHINCONTEXTMENU_H
#define DOLPHINCONTEXTMENU_H
#include <KFileCopyToMenu>
#include <KFileItem>
#include <QMenu>
#include <QUrl>
class QAction;
class DolphinMainWindow;
class KFileItemActions;
class KFileItemListProperties;
class DolphinRemoveAction;
/**
* @brief Represents the context menu which appears when doing a right
* click on an item or the viewport of the file manager.
*
* Beside static menu entries (e. g. 'Paste' or 'Properties') two
* dynamic sub menus are shown when opening a context menu above
* an item:
* - 'Open With': Contains all applications which are registered to
* open items of the given MIME type.
* - 'Actions': Contains all actions which can be applied to the
* given item.
*/
class DolphinContextMenu : public QMenu
{
Q_OBJECT
public:
enum Command
{
None,
OpenParentFolder,
OpenParentFolderInNewWindow,
OpenParentFolderInNewTab
};
/**
* @parent Pointer to the main window the context menu
* belongs to.
* @pos Position in screen coordinates.
* @fileInfo Pointer to the file item the context menu
* is applied. If 0 is passed, the context menu
* is above the viewport.
* @baseUrl Base URL of the viewport where the context menu
* should be opened.
*/
DolphinContextMenu(DolphinMainWindow* parent,
const QPoint& pos,
const KFileItem& fileInfo,
const QUrl& baseUrl);
~DolphinContextMenu() override;
void setCustomActions(const QList<QAction*>& actions);
/**
* Opens the context menu model and returns the requested
* command, that should be triggered by the caller. If
* Command::None has been returned, either the context-menu
* had been closed without executing an action or an
* already available action from the main-window has been
* executed.
*/
Command open();
protected:
void keyPressEvent(QKeyEvent *ev) override;
void keyReleaseEvent(QKeyEvent *ev) override;
private:
void openTrashContextMenu();
void openTrashItemContextMenu();
void openItemContextMenu();
void openViewportContextMenu();
void insertDefaultItemActions(const KFileItemListProperties&);
/**
* Adds the "Show menubar" action to the menu if the
* menubar is hidden.
*/
void addShowMenuBarAction();
bool placeExists(const QUrl& url) const;
QAction* createPasteAction();
KFileItemListProperties& selectedItemsProperties() const;
/**
* Returns the file item for m_baseUrl.
*/
KFileItem baseFileItem();
/**
* Adds "Open With" actions
*/
void addOpenWithActions(KFileItemActions& fileItemActions);
/**
* Adds actions that are provided by a KVersionControlPlugin.
*/
void addVersionControlPluginActions();
/**
* Adds custom actions e.g. like the "[x] Expandable Folders"-action
* provided in the details view.
*/
void addCustomActions();
private:
struct Entry
{
int type;
QString name;
QString filePath; // empty for separator
QString templatePath; // same as filePath for template
QString icon;
QString comment;
};
enum ContextType
{
NoContext = 0,
ItemContext = 1,
TrashContext = 2
};
QPoint m_pos;
DolphinMainWindow* m_mainWindow;
KFileItem m_fileInfo;
QUrl m_baseUrl;
KFileItem* m_baseFileItem; /// File item for m_baseUrl
KFileItemList m_selectedItems;
mutable KFileItemListProperties* m_selectedItemsProperties;
int m_context;
KFileCopyToMenu m_copyToMenu;
QList<QAction*> m_customActions;
Command m_command;
DolphinRemoveAction* m_removeAction; // Action that represents either 'Move To Trash' or 'Delete'
};
#endif