mirror of
https://invent.kde.org/system/dolphin
synced 2024-10-28 03:21:56 +00:00
b3add25694
This mostly red MR should have no visible effect. It is part of my work towards !273. There are two calls necessary to open the DolphinContextMenu: One to construct it and one to execute/show it. Before this commit, the actual populating of the ContextMenu was done on execute. This meant that the actions of the ContextMenu couldn't be looked at or changed without first showing the Menu to the user. It also meant that the construction itself didn't actually do much constructing/populating at all which might seem a bit unintuitive. This commit changes this behaviour so the DolphinContextMenu is actually populated fully on construction. The executing/showing of the ContextMenu now does just that and nothing more. Previously, some actions in the context menu were actually not wired up to anything and instead the DolphinContextMenu or the DolphinMainWindow executed some code after the user had clicked such a dummy action from the ContextMenu. Now all the actions are properly constructed beforehand and no special handling is necessary when the ContextMenu hides itself. This commit removes the pos parameter from the DolphinContextMenu constructor. This parameter contained the position where the Menu would be shown later. This information isn't necessary to have on construction and was already part of the exec(pos) call in the first place. The variable m_pos that stored the value is removed. This commit also removes a "customActions" functionality that can supposedly be used to add further custom actions to the DolphinContextMenu but this functionality isn't ever used anywhere so its usefulness is questionable. It also wouldn't be difficult to re-add this functionality if it was ever required for something. This commit also addresses an old TODO in dolphinpart.cpp that asked for the calls for opening the DolphinContextMenu to actually contain the information for which items the DolphinContextMenu is supposed to be constructed. Before this, only the item that was directly clicked was transmitted and then DolphinContextMenu retrieved the currently selected set of items by itself. It makes more sense that DolphinContextMenu would be informed on construction which items it is supposed to show context actions for. Most of this is necessary so we are able to show the contextual actions anywhere else than in the ContextMenu in the future. I am targeting 22.08 with this MR because it makes no sense to merge a refactor for the upcoming release already.
236 lines
7.1 KiB
C++
236 lines
7.1 KiB
C++
/* This file is part of the KDE project
|
|
SPDX-FileCopyrightText: 2007 David Faure <faure@kde.org>
|
|
|
|
SPDX-License-Identifier: LGPL-2.0-or-later
|
|
*/
|
|
|
|
#ifndef DOLPHINPART_H
|
|
#define DOLPHINPART_H
|
|
|
|
#include <KParts/ReadOnlyPart>
|
|
|
|
#include <QAction>
|
|
#include <QUrl>
|
|
|
|
class DolphinNewFileMenu;
|
|
class DolphinViewActionHandler;
|
|
class QActionGroup;
|
|
class KFileItemList;
|
|
class KFileItem;
|
|
class DolphinPartBrowserExtension;
|
|
class DolphinRemoteEncoding;
|
|
class KDirLister;
|
|
class DolphinView;
|
|
class DolphinRemoveAction;
|
|
|
|
class DolphinPart : public KParts::ReadOnlyPart
|
|
{
|
|
Q_OBJECT
|
|
// Used by konqueror. Technically it means "we want undo enabled if
|
|
// there are things in the undo history and the current part is a dolphin part".
|
|
// Even though it's konqueror doing the undo...
|
|
Q_PROPERTY( bool supportsUndo READ supportsUndo )
|
|
|
|
Q_PROPERTY( QString currentViewMode READ currentViewMode WRITE setCurrentViewMode )
|
|
|
|
// Used by konqueror when typing something like /home/dfaure/*.diff in the location bar
|
|
Q_PROPERTY( QString nameFilter READ nameFilter WRITE setNameFilter )
|
|
|
|
// Used by konqueror to implement the --select command-line option
|
|
Q_PROPERTY( QList<QUrl> filesToSelect READ filesToSelect WRITE setFilesToSelect )
|
|
|
|
public:
|
|
explicit DolphinPart(QWidget* parentWidget, QObject* parent,
|
|
const KPluginMetaData& metaData, const QVariantList& args);
|
|
~DolphinPart() override;
|
|
|
|
/**
|
|
* Standard KParts::ReadOnlyPart openUrl method.
|
|
* Called by Konqueror to view a directory in DolphinPart.
|
|
*/
|
|
bool openUrl(const QUrl& url) override;
|
|
|
|
/// see the supportsUndo property
|
|
bool supportsUndo() const { return true; }
|
|
|
|
/**
|
|
* Used by konqueror for setting the view mode
|
|
* @param viewModeName internal name for the view mode, like "icons"
|
|
* Those names come from the Actions line in dolphinpart.desktop,
|
|
* and have to match the name of the KActions.
|
|
*/
|
|
void setCurrentViewMode(const QString& viewModeName);
|
|
|
|
/**
|
|
* Used by konqueror for displaying the current view mode.
|
|
* @see setCurrentViewMode
|
|
*/
|
|
QString currentViewMode() const;
|
|
|
|
/// Returns the view owned by this part; used by DolphinPartBrowserExtension
|
|
DolphinView* view() { return m_view; }
|
|
|
|
/**
|
|
* Sets a name filter, like *.diff
|
|
*/
|
|
void setNameFilter(const QString& nameFilter);
|
|
|
|
/**
|
|
* Returns the current name filter. Used by konqueror to show it in the URL.
|
|
*/
|
|
QString nameFilter() const { return m_nameFilter; }
|
|
|
|
protected:
|
|
/**
|
|
* We reimplement openUrl so no need to implement openFile.
|
|
*/
|
|
bool openFile() override { return true; }
|
|
|
|
Q_SIGNALS:
|
|
/**
|
|
* Emitted when the view mode changes. Used by konqueror.
|
|
*/
|
|
void viewModeChanged();
|
|
|
|
|
|
/**
|
|
* Emitted whenever the current URL is about to be changed.
|
|
*/
|
|
void aboutToOpenURL();
|
|
|
|
private Q_SLOTS:
|
|
void slotMessage(const QString& msg);
|
|
void slotErrorMessage(const QString& msg);
|
|
/**
|
|
* Shows the information for the item \a item inside the statusbar. If the
|
|
* item is null, the default statusbar information is shown.
|
|
*/
|
|
void slotRequestItemInfo(const KFileItem& item);
|
|
/**
|
|
* Handles clicking on an item
|
|
*/
|
|
void slotItemActivated(const KFileItem& item);
|
|
/**
|
|
* Handles activation of multiple items
|
|
*/
|
|
void slotItemsActivated(const KFileItemList& items);
|
|
/**
|
|
* Creates a new window showing the content of \a url.
|
|
*/
|
|
void createNewWindow(const QUrl &url);
|
|
/**
|
|
* Opens the context menu on the current mouse position.
|
|
* @pos Position in screen coordinates.
|
|
* @item File item context. If item is null, the context menu
|
|
* should be applied to \a url.
|
|
* @selectedItems The selected items for which the context menu
|
|
* is opened. This list generally includes \a item.
|
|
* @url URL which contains \a item.
|
|
*/
|
|
void slotOpenContextMenu(const QPoint &pos, const KFileItem &_item, const KFileItemList &selectedItems, const QUrl &);
|
|
|
|
/**
|
|
* Informs the host that we are opening \a url (e.g. after a redirection
|
|
* coming from KDirLister).
|
|
* Testcase 1: fish://localhost
|
|
* Testcase 2: showing a directory that is being renamed by another window (#180156)
|
|
*/
|
|
void slotDirectoryRedirection(const QUrl& oldUrl, const QUrl& newUrl);
|
|
|
|
/**
|
|
* Updates the state of the 'Edit' menu actions and emits
|
|
* the signal selectionChanged().
|
|
*/
|
|
void slotSelectionChanged(const KFileItemList& selection);
|
|
|
|
/**
|
|
* Updates the text of the paste action dependent from
|
|
* the number of items which are in the clipboard.
|
|
*/
|
|
void updatePasteAction();
|
|
|
|
/**
|
|
* Connected to all "Go" menu actions provided by DolphinPart
|
|
*/
|
|
void slotGoTriggered(QAction* action);
|
|
|
|
/**
|
|
* Connected to the "editMimeType" action
|
|
*/
|
|
void slotEditMimeType();
|
|
|
|
/**
|
|
* Connected to the "select_items_matching" action.
|
|
* Opens a dialog which permits to select all items matching a pattern like "*.jpg".
|
|
*/
|
|
void slotSelectItemsMatchingPattern();
|
|
|
|
/**
|
|
* Connected to the "unselect_items_matching" action.
|
|
* Opens a dialog which permits to unselect all items matching a pattern like "*.jpg".
|
|
*/
|
|
void slotUnselectItemsMatchingPattern();
|
|
|
|
/**
|
|
* Open a terminal window, starting with the current directory.
|
|
*/
|
|
void slotOpenTerminal();
|
|
|
|
/**
|
|
* Open preferred search tool in the current directory to find files.
|
|
*/
|
|
void slotFindFile();
|
|
|
|
/**
|
|
* Updates the 'Create New...' sub menu, just before it's shown.
|
|
*/
|
|
void updateNewMenu();
|
|
|
|
/**
|
|
* Updates the number of items (= number of files + number of
|
|
* directories) in the statusbar. If files are selected, the number
|
|
* of selected files and the sum of the filesize is shown.
|
|
*/
|
|
void updateStatusBar();
|
|
|
|
/**
|
|
* Notify container of folder loading progress.
|
|
*/
|
|
void updateProgress(int percent);
|
|
|
|
void createDirectory();
|
|
|
|
/**
|
|
* Called by konqueror --select
|
|
*/
|
|
void setFilesToSelect(const QList<QUrl> &files);
|
|
QList<QUrl> filesToSelect() const { return QList<QUrl>(); } // silence moc
|
|
|
|
bool eventFilter(QObject*, QEvent*) override;
|
|
|
|
private:
|
|
void createActions();
|
|
void createGoAction(const char* name, const char* iconName,
|
|
const QString& text, const QString& url,
|
|
QActionGroup* actionGroup);
|
|
|
|
void openSelectionDialog(const QString& title, const QString& text,
|
|
bool selectItems);
|
|
QString urlToLocalFilePath(const QUrl &url);
|
|
QString localFilePathOrHome() const;
|
|
|
|
private:
|
|
DolphinView* m_view;
|
|
DolphinViewActionHandler* m_actionHandler;
|
|
DolphinRemoteEncoding* m_remoteEncoding;
|
|
DolphinPartBrowserExtension* m_extension;
|
|
DolphinNewFileMenu* m_newFileMenu;
|
|
QAction* m_findFileAction;
|
|
QAction* m_openTerminalAction;
|
|
QString m_nameFilter;
|
|
DolphinRemoveAction* m_removeAction;
|
|
Q_DISABLE_COPY(DolphinPart)
|
|
};
|
|
|
|
#endif /* DOLPHINPART_H */
|