kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-07-04 17:30:55 +00:00
Code Issues Projects Releases Wiki Activity
5,786 Commits 136 Branches 321 Tags 216 MiB
C++ 97.9%
CMake 1.5%
Ruby 0.3%
Python 0.3%
27e3907a3d
Go to file
Alexander Saoutkin 27e3907a3d Open externally called files/directories in new tabs 
Summary:
FEATURE: 183429
FIXED-IN: 19.08.0
GUI: new cli argument --new-window

Externally called files/directories are opened in a a new tab of an instance of Dolphin that already exists. If any of the given URIs are already open in a tab, then those tabs are activated instead of a new tab being opened.  If there is no instance then the files/directories are opened in a new window. The newly opened file/directory has its tab activated, and consequently, the window is also activated.

When the user clicks "Open In New Window" or "Detach Tab", the files/directories are opened in a new window.

Test Plan:
[Manual]
Before testing, set the default file manager in system settings as the newly built Dolphin executable.
One must also include the new dolphin executable in the $PATH, otherwise some functions will attempt to open the system dolphin instead of the new one.

Furthermore, running two different versions of Dolphin (in particular, where one does not have this patch included) can result in bugs appearing, in particular, new tabs not opening as old instances will not recognise the DBus commands sent to it. However, I see no reason why a user will have two different versions of Dolphin (apart from people like us :D).

Open directories with the help of auxillary programs (i.e. a browser). The files/directories should appear in a new window if an instance does not exist. If an existence already exists, then a new tab should be opened and activated in that instance and the window activated.
Use QDBusViewer to open folders/items by calling the ShowFolders/ShowItems methods in org.freedesktop.FileManager1 of the Dolphin instance.
When a user chooses to "Open In New Window"/"Detach Tab" then the files/directories should be opened in a new window.

Reviewers: #dolphin, elvisangelaccio

Subscribers: zzag, dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D16648
2019-05-30 22:40:08 +02:00
cmake Fix indentation 2019-05-12 13:12:01 +02:00
doc Use placeholder for search action 2019-04-22 23:03:10 +02:00
src Open externally called files/directories in new tabs 2019-05-30 22:40:08 +02:00
.arcconfig Add .arcconfig file for phabricator 2017-02-05 11:09:21 +01:00
.gitignore Added .kdev4 to gitignore 2017-02-18 23:00:48 +01:00
AUTHORS updated to KDE 4 (the file was valid for Dolphin for KDE 3) 2008-07-07 09:18:51 +00:00
CMakeLists.txt Open externally called files/directories in new tabs 2019-05-30 22:40:08 +02:00
COPYING commited initial version of Dolphin 2006-11-21 06:02:05 +00:00
COPYING.DOC updates for new licence policy 2008-01-12 16:39:07 +00:00
dolphin.categories Autogenerate debug file + install debug categories file 2018-11-02 13:23:10 +01:00
DolphinVcsConfig.cmake.in Use CMakePackageConfigHelpers instead of the ECM variant 2017-12-01 19:27:57 +01:00
HACKING.md Add HACKING file with 'Philosophy' paragraph from the Userbase page 2019-04-07 17:29:51 +02:00
org.kde.dolphin.FileManager1.service.in Add dbus interface to dolphin 2015-04-22 18:59:39 +05:30
README it's http://dolphin.kde.org/ now 2008-07-26 14:01:34 +00:00

README 

See http://dolphin.kde.org for information about Dolphin.