1
0
mirror of https://invent.kde.org/system/dolphin synced 2024-06-30 23:46:46 +00:00

Compare commits

...

2 Commits

Author SHA1 Message Date
Christian Hartmann
d3508348a4 Merge branch '452292-fix-service-menu-installer-run-script-in-konsole-on-install---uninstall' into 'master'
fix: service-menu-installer-run-script-in-konsole-on-install---uninstall

See merge request system/dolphin!372
2024-06-23 08:26:44 +00:00
Christian Hartmann
3c7d447030 fix-service-menu-installer-run-script-in-konsole-on-install---uninstall
service-menu-installer runs de-installation in konsole for 'uninstall.sh' but
not for 'install.sh uninstall' for no discernible reason.

Changes will run install.sh --uninstall as uninstall.sh in Konsole and will
therefor provide user feedback if any in the script.

BUG: 452292
2022-12-31 14:03:16 +00:00

View File

@ -261,7 +261,7 @@ bool runScriptVariants(const QString &path, bool hasArgVariants, const QStringLi
qInfo() << "[servicemenuinstaller]: Trying to run installer/uninstaller" << path;
if (hasArgVariants) {
for (const auto &arg : argVariants) {
if (runScriptOnce(path, {arg}, ScriptExecution::Process)) {
if (runScriptOnce(path, {arg}, ScriptExecution::Konsole)) {
return true;
}
}