Commit graph

153 commits

Author SHA1 Message Date
Peter Penz b28a5a6248 Minor API-cleanups for DolphinView 2012-04-11 16:43:11 +02:00
Peter Penz 6c3d9acbc2 KItemViews: Internal directory restructuration
- Move all private headers from the kitemviews-directory into
the 'private' subdirectory.

- Get rid of DolphinDirLister and just use a directory-lister
  internally in KFileItemModel.

- Minor interface-cleanups for signals
2012-04-11 16:08:32 +02:00
Peter Penz d9dbd3398a Improvements for slow sorting roles
If the sorting is done for data which is resolved asynchronously
(e.g. rating), it is important to give a visual feedback about
the state of the sorting. This is done now by a progress
indication in the statusbar.

Also optimizations for "Sort by type" have been done: Although
resolving a type can be expensive in the most often case it is a
very cheap operation. So it the sorting is done by type, try
to resolve the type synchronously for at least 200 ms to prevent
a asynchronous resorting. This is usually sufficient to have
resolved types even for directories with several thousands of
items.

BUG: 292733
FIXED-IN: 4.9.0
2012-04-10 16:36:26 +02:00
Peter Penz 7bbdb66618 Show file size when hovering an item
BUG: 292687
FIXED-IN: 4.8.1
2012-02-03 22:32:39 +01:00
Peter Penz d4e0bc2e23 Apply changed home-URL to the URL navigator
BUG: 291043
FIXED-IN: 4.8.1
2012-01-31 17:17:54 +01:00
Peter Penz e283a9f7d9 Synchronize view-mode settings before the settings dialog gets opened
BUG: 292698
FIXED-IN: 4.8.1
2012-01-30 16:38:24 +01:00
Peter Penz 1d7088b1ad Fix drag & drop issues with non-local URLs
BUG: 292821
BUG: 292355
FIXED-IN: 4.8.1
2012-01-30 12:09:36 +01:00
Peter Penz f38a70f5d0 Assure an active view when activating an item
This might not be the case when e.g. having a split view, having enabled the "auto
expand folders" option and dragging an item from the active view to another
folder of the inactive view.
2012-01-14 22:02:23 +01:00
Peter Penz 531c88c840 Reenable drag & drop for the URL navigator
BUG: 289568
FIXED-IN: 4.8.0
2011-12-22 22:00:05 +01:00
Sebastian Trueg 93cc480803 Use KFileItem::text() instead of KFileItem::name().
This way Nepomuk search results get their proper user readable names.
BUG: 287472
REVIEW: 103237
2011-11-25 16:09:57 +01:00
Peter Penz 3c77ffe832 Delete obsolete class DolphinSettings 2011-11-06 11:59:26 +01:00
Peter Penz eadbf920b5 Don't use mixed units in size-column of details-view
This makes it tricky to compare the filesizes without adjusting
the sort-order, so now all sizes in the size-column are shown
in KiB or KB (dependent on the KLocale setting).

BUG: 219932
FIXED-IN: 4.8.0

Related fixes:
- Stay consistent with the rounding when using the KiB/KB unit
  in the statusbar.
- Fix sorting-by-size issue for folders
- Show "Unknown" in the size-column when the number of items
  cannot be determined.
2011-11-04 21:58:32 +01:00
Peter Penz 6551c000fc Context menu cleanups
- Open the context menu on the mouse-press event, not on the
  mouse-release event.
- Provide an explicit position-information and don't use
  QCursor::pos(). This fixes the issue that opening a context-menu
  by the keyboard opens below the cursor.
- Provide different signals in the KItemListController for
  the different context-menu types (item vs. view vs. header).
- Implement turning on/off roles by the header-context-menu.
2011-10-08 21:43:55 +02:00
Peter Penz 1b88652b85 Renamed some signals for consistency with KItemViews classes 2011-08-29 20:14:33 +02:00
Montel Laurent 08d655c2bc normalize signals/slots 2011-07-31 13:33:56 +02:00
Peter Penz f23e9496f3 Merged very early alpha-version of Dolphin 2.0
Dolphin 2.0 will get a new view-engine with the
following improvements:
- Better performance
- Animated transitions
- No clipped filenames due to dynamic item-sizes
- Grouping support for all view-modes
- Non-rectangular selection areas
- Simplified code for better maintenance

More details will be provided in a blog-entry during
the next days.

Please note that the code is in a very
early alpha-stage and although the most tricky parts
have been implemented already very basic things like
drag and drop or selections have not been pushed yet.
Those things are rather trivial to implement but this
still will take some time.
2011-07-30 20:13:41 +02:00
Matthias Fuchs df557df2e0 Return the url of the view instead of the url of the url navigator.
That way if a wrong protocol had been entered the currently watched directory will be returned.
BUG:274890
REVIEW:101580
2011-06-11 00:28:05 +02:00
Peter Penz 27a8c55ec9 Search improvements
Use Query::titleFromQueryUrl() to give a hint what kind of information
is shown to the user.
2011-04-20 21:21:26 +02:00
Peter Penz ae488b1318 Improve usability of Search Panel
If the Search Panel is shown outside the context of the "Find" mode it
will be always enabled and does a global search. Only if the user is in
the "Find" mode and the searching is restricted to the current directory
the Search Panel might get disabled if the current directory is not
indexed. This solves the major usability issue that it was not clear
for the users whether a global or restricted search is done.
2011-04-20 20:09:08 +02:00
Sebastian Dörner 4b0dc69070 Make cursor keys always trigger a statusbar update
When the selection is changed using the cursor keys, the statusbar
should be updated. Until now, this didn't actually happen directly after
an operation ending in a OperationCompletedMessage, because the
OperationCompletedMessage was protected.

This patch changes the behaviour to only protect ErrorMessages in the
ViewContainer. When an OperationCompletedMessage was issued very
recently, it keeps being protected by DolphinStatusbar itself.

Statusbar updates in the ViewContainer are only triggered by
a) user actions (move keyboard focus, enter something in the filter bar)
b) finished filed jobs

In case a), the update is desired, also overriding
OperationCompletedMessages.
In case b), the OperationCompletedMessage issued by the file command is
issues so shortly before the call to updateStatusBar, that the
DolphinStatusBar skips the message anyway (see
DolphinStatusBar::setMessage).

BUG: 193847
FIXED-IN: 4.7.0
REVIEW: 100939
2011-03-24 22:43:45 +01:00
Peter Penz 1173ca1211 Reset progress of the statusbar when the stop-button has been pressed 2011-02-12 17:47:18 +01:00
Christoph Thielecke 12324da326 revert ed4f9d3e11 2011-02-10 10:59:35 +01:00
Christoph Thielecke ee0f3435b2 compile fix: includes does only exist with old names, please fix kde headers too 2011-02-10 08:58:24 +01:00
Peter Penz d3496b1231 Coding style update for pointer comparison
Most developers seem to prefer
  if (ptr) ...
  if (!ptr) ...
in comparison to
  if (ptr != 0) ...
  if (ptr == 0) ...

Adjusted the Dolphin-code to use the "most-prefered style" to make contributors happy.
2011-02-09 19:24:27 +01:00
Peter Penz ceba0f6f6a Use capitalized includes of recently committed kdelibs headers 2011-02-09 18:42:04 +01:00
Peter Penz 27456a2f73 Provide a hook for externally triggered search queries
In this case the "From Here"/"Everywhere" buttons and the "Filename"/"Content" buttons are useless. Currently they just get disabled but the plan is to provide a better visual indication of the current query and to remove them completely.
2011-02-05 23:33:08 +01:00
Peter Penz 17d217b862 Add unittest for DolphinSearchBox
A minor API cleanup in DolphinSearchBox has been done related to the test.
2011-02-04 22:13:50 +01:00
Peter Penz 236eac2ffa Don't clear the search-text when switching between tabs
The clearing of the search-text should only be done when opening the search-box.
2011-02-04 20:55:52 +01:00
Peter Penz fd74aa8e20 Update e-mail address from peter.penz@gmx.at to peter.penz19@gmail.com 2011-02-04 15:57:33 +01:00
Peter Penz 956ebf7115 Don't use the submodule-path for Qt-includes on application-level
Also some KDE-includes have been capitalized
2011-02-04 15:49:45 +01:00
Peter Penz 8eb9b508ca Use capitalized KDE includes 2011-02-04 15:43:21 +01:00
Peter Penz fae8ba471b Encapsulate the creation and handling of the directory lister, the model and proxy model to DolphinView. By this it will be easier later to replace the traditional QAbstractItemViews by any kind of other implementation (e.g. based on QGraphicsView/QML).
svn path=/trunk/KDE/kdebase/apps/; revision=1213189
2011-01-09 13:58:35 +00:00
Peter Penz 342954bb1f Select the whole text in the filterbar and searchbox if the widget has lost the focus and gets focused again by the shortcut (this behavior is consistent to e.g. the behavior in Kate).
CCBUG: 256160

svn path=/trunk/KDE/kdebase/apps/; revision=1207719
2010-12-19 12:03:46 +00:00
Peter Penz bf4689bb64 Keeping DolphinDirLister and DolphinModel as DolphinViewContainers members is not needed anymore, as all the handling is encapsulated inside DolphinView in the meantime. The moving of the dirlister- and model-construction will be done after the 4.6 release, as some internal API adjustments are necessary.
svn path=/trunk/KDE/kdebase/apps/; revision=1206754
2010-12-15 18:55:25 +00:00
Peter Penz adde3d4e3c Fix issue that the enabled state of the "Create New..." menu is not updated correctly in the column-view.
BUG: 258534
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1206749
2010-12-15 18:40:08 +00:00
Peter Penz e587aaa9c4 Show an undetermined progress indication within one second after changing an URL.
Update to SVN commit 1205329:
- Fix issue that an undetermined progress is shown when switching between columns of the column-view.
- Fix issue that no undetermined progress is shown when editing the URL directly in the URL navigator

BUG: 234894
BUG: 163004
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1205345
2010-12-10 22:54:37 +00:00
Peter Penz 0da54e5c1b Show an undetermined progress indication within one second after changing an URL.
svn path=/trunk/KDE/kdebase/apps/; revision=1205329
2010-12-10 21:54:53 +00:00
Friedrich W. H. Kossebau 6b2ee4933c removed: include of unused header
svn path=/trunk/KDE/kdebase/apps/; revision=1199157
2010-11-20 21:32:16 +00:00
Peter Penz 6ec1a1eb36 Allow to cancel the loading of search results.
BUG: 257421
FIXED-IN: 4.6.0


svn path=/trunk/KDE/kdebase/apps/; revision=1199112
2010-11-20 17:17:35 +00:00
Peter Penz 456d529295 Make the filter-behavior similar to applications like Kate, where activating the filter lets focus it again.
BUG: 256160
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1193912
2010-11-07 14:55:33 +00:00
Peter Penz d83a4ce51d Rename the setter showFilterBar() to setFilterBarVisible().
svn path=/trunk/KDE/kdebase/apps/; revision=1193348
2010-11-05 17:12:35 +00:00
Peter Penz da1adf7ba4 If the user has changed the startup settings, they should also get applied to the current views.
BUG: 254947
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1193344
2010-11-05 17:02:58 +00:00
Peter Penz 3aa13c7a24 Assure that always the search-box is shown instead of the URL-navigator if a Nepomuk-URL is requested. We still have to think about how to show queries that cannot be represented by the facet-widget, but at least it is sure that this kind of information should not be shown by the URL navigator.
svn path=/trunk/KDE/kdebase/apps/; revision=1191912
2010-11-01 12:31:44 +00:00
Peter Penz 4383f4238e - Automatically show the filter-panel when a searching is done
- Remove filter-prototypes that conflict with the filterpanel


svn path=/trunk/KDE/kdebase/apps/; revision=1190445
2010-10-27 17:08:02 +00:00
Peter Penz 4ad4d4785c Update the statusbar also during loading the items, not only after the loading has been completed. This fixes the issue that no current item-count is shown when doing a search.
svn path=/trunk/KDE/kdebase/apps/; revision=1184520
2010-10-10 17:11:55 +00:00
Peter Penz 717a665c4e Automatically start the searching if the user did not change the search-text for at least a second.
svn path=/trunk/KDE/kdebase/apps/; revision=1184510
2010-10-10 16:13:24 +00:00
Peter Penz 55739979a8 KDirModel takes ownership of the directory lister, so don't delete the directory lister manually.
BUG: 196681

svn path=/trunk/KDE/kdebase/apps/; revision=1176325
2010-09-17 11:24:06 +00:00
Peter Penz 624ca2b320 Fix triggering of an assertion, if a new tab is opened. Thanks to Frank Reininghaus for the detailed analyses!
BUG: 246747
FIXED-IN: 4.6.0


svn path=/trunk/KDE/kdebase/apps/; revision=1164862
2010-08-17 19:58:47 +00:00
Peter Penz a5cf21ff06 Sourcecode hierarchy cleanup: Move further files from src to src/views
svn path=/trunk/KDE/kdebase/apps/; revision=1154150
2010-07-24 22:08:30 +00:00
Peter Penz 652d08c924 Sourcecode hierarchy cleanup: Create folder "views" and move view related sources to it
svn path=/trunk/KDE/kdebase/apps/; revision=1154146
2010-07-24 21:45:49 +00:00