Commit graph

3813 commits

Author SHA1 Message Date
Peter Penz
f158bf097a Places Panel: Fix implementation issues when hiding items 2012-05-02 21:24:16 +02:00
Peter Penz
d76b113ad1 Places Panel: Allow hiding of items
Related changes:
- Animate changed items for the details-view in case it is not expandable
- Remove the hardcoded "isHidden"-code in KStandardItemListWidget and
  allow derived widgets to define themselves what means "hidden" within
  their context.

The current code needs a lot of bugfixing, but lets make this in smaller
steps during the next days...
2012-05-01 23:14:52 +02:00
Peter Penz
6a7cb5ff7d Fix crash when closing Dolphin during generating previews
BUG: 299108
FIXED-IN: 4.9.0
2012-04-30 18:55:48 +02:00
Peter Penz
cb1f42a1eb Places Panel: Minor fixes/improvements
- Determine group of a new entry dependent from the protocol
- Allow panels to forward error-messages to the view-container
  (also applied to Folders Panel)
2012-04-30 18:27:56 +02:00
Peter Penz
b419cfc597 Places Panel fixes
Implement adding, editing and removing of entries. Note that the
result currently is still not stored in bookmarks.xml (this needs
to wait until the hiding is implemented in the model).
2012-04-29 00:00:38 +02:00
Peter Penz
0a00f13bf2 Never pass null-items to version-control-plugins
Some plugins are not prepared for this and might crash. Although
the additional check in VersionControlObserver::actions() should not
be necessary because of the fix in DolphinView, it is left here
to catch potential other cases where a null-item might get passed
accidently.

Thanks to Ilya for initially patching the Box-plugin which gave
a hint whats going wrong.

BUG: 294336
FIXED-IN: 4.9.0
2012-04-27 09:31:57 +02:00
Peter Penz
d1c5dc52a3 Places Panel: Provide dialog for editing places 2012-04-26 23:41:01 +02:00
Peter Penz
2854a69fca Reset to ascending sort order when changing the column
When changing the sort-column the sort order should always be reset
to 'ascending' to by consistent with the QListView behavior.

BUG: 298830
FIXED-IN: 4.9.0
2012-04-26 21:29:33 +02:00
Frank Reininghaus
12c239ae14 Update the view when changing the directory using 'cd' in the terminal
Thanks to Jekyll Wu for helping to implement this feature!

FEATURE: 156732
FIXED-IN: 4.9.0
2012-04-26 08:31:59 +02:00
Peter Penz
640696db72 Places panel: Internal cleanup
Move the bookmark handling into a custom model, so that the
PlacesPanel only contains UI + controller code.
2012-04-25 23:02:40 +02:00
Peter Penz
804021a8db Provide correct labels for Nepomuk resources 2012-04-25 21:15:14 +02:00
Frank Reininghaus
c3bd4b44e4 When the current item is removed, make -1 the current index temporarily
This fixes two problems:
1. KItemListKeyboardSearchManger can cancel the current search when a
   new folder is opened (note that this action removes the current item
   from the view).
2. The view can underline the new current item (which is the item that
   used to be below the removed item). Note that this did not work
   before because the view did not receive a currentChanged() signal in
   this case and therefore did not update the "current item" status of
   the new current item.

CCBUG: 297488
CCBUG: 298782
REVIEW: 104709
(cherry picked from commit 68ce395a19)
2012-04-25 09:20:23 +02:00
Frank Reininghaus
90baf5a897 When Esc is pressed, clear the selection and cancel the keyboard search
This patch restores the Dolphin 1.x behaviour that Esc clears the
selection (Dolphin 2.0 did not have an easy way to clear the selection
using the keyboard so far). Moreover, Esc now also cancels the current
keyboard search. This fixes the problem that the only way to cancel the
search is to wait until the timeout has expired.

CCBUG: 298742
CCBUG: 297458
(cherry picked from commit d3b1312d3e)
2012-04-25 09:17:43 +02:00
Frank Reininghaus
fa447df642 Reduce the timeout in KItemListKeyboardSearchManager to 1 second
It turned out that the longer timeout, introduced recently in
02eab49b2d, not only made multi-letter
keyboard searches easier, but also had some unwanted side effects. I
hope that 1 second, which is between the previous value of 5 seconds and
the pre-KDE 4.8.2 value of 0.4 seconds, is a compromise which will fit
most users' needs.
We will try to improve the situation further in future releases by
providing visual feedback about the keyboard search, but such a change
would not be suitable for a bug-fix release.
(cherry picked from commit d8732a59d3)
2012-04-25 09:16:39 +02:00
Peter Penz
67f58d5082 Fix search-UI issues in combination with the new places entries
The places-entries for searching revealed some serious issues in
combination with the search-panel. Move the filtering away from
QDockWidget and bring it back below the search-bar.
2012-04-25 02:20:25 +02:00
Peter Penz
d9de391720 Provide additional default groups for the Places Panel
If Nepomuk is enabled, it is now possible to easily search for
some most common queries by having additional groups.
2012-04-24 23:18:34 +02:00
Script Kiddy
ba2593247b SVN_SILENT made messages (.desktop file) 2012-04-24 16:54:04 +02:00
Peter Penz
cbf83085be Details mode: Fix wrong required column-width calculation
BUG: 298577
FIXED-IN: 4.9.0
2012-04-23 00:24:40 +02:00
Peter Penz
007907be20 Bring back basic bookmark support for the Places Panel
The folders-panel signals have been adjusted too for consistency.
2012-04-21 23:29:11 +02:00
Peter Penz
e3f46c3b20 Inline renaming: Fix wrong assertion
BUG: 298512
FIXED-IN: 4.9.0
2012-04-21 21:41:24 +02:00
Peter Penz
ae4d11d918 Prepare view-engine for non-KFileItem usecase
Up to now the view-engine only provided a model-implementation that
supports file-items. The view-engine always had been designed to be able
to work with any kind of model, so now a KStandardItemModel is available.
The plan is to convert the places panel to the new view-engine. It should
be no problem to fix this until the feature freeze - in the worst case
the places-panel code could be reverted while still keeping the
KStandardItemModel changes.
2012-04-21 21:32:42 +02:00
Dawit Alemayehu
47d7cdffdd Fixed the signal connection that emits completed in Dolphin's KPart 2012-04-17 19:57:12 -04:00
Peter Penz
7afd2f0ae1 Inline renaming fixes
- Increase the editor-height in the icons-view if required
- Don't try to react on resizings of the parent, just finish
  the renaming
2012-04-18 01:15:49 +02:00
Peter Penz
beeb9078f5 Ensure authentication data is cached properly
The attached patch sets the main window on the main directory
lister in DolphinView and KIO jobs in DolphinMainWindow to ensure
that login data for remote protocols such as sftp, ftp are cached
properly for the duration of the application. Otherwise, the end
user is going to end up being unnecessarily re-prompted to enter
password login information.

Thanks to Dawit Alemayehu for the patch!

REVIEW: 104614
FIXED-IN: 4.9.0
2012-04-17 22:21:55 +02:00
Peter Penz
9f94aac23f Documentation update for KItemListRoleEditor 2012-04-17 18:18:10 +02:00
Peter Penz
b2e54c3a31 Implement inline-renaming for the new view-engine
BUG: 286893
FIXED-IN: 4.9.0
2012-04-17 18:15:12 +02:00
Script Kiddy
eb1b53103d SVN_SILENT made messages (.desktop file) 2012-04-17 16:06:32 +02:00
Peter Penz
d8b832ec6a General settings: Use radiobuttons instead of a combo-box
Revert the change to use a combo-box, it results to clipped texts
with some languages.
2012-04-15 20:59:37 +02:00
Peter Penz
1ea09b24e1 Minor statusbar fixes
- Don't show information messages as KMessageWidget
- Assure that a set text in a statusbar will be shown for at least
  one second
2012-04-15 11:46:07 +02:00
Peter Penz
60b8681081 Allow to optionally limit the maximum number of text lines
Showing the whole filename unclipped seems to be a good default,
however for users with a lot of files that have extremely long names
this might get a problem especially in the icons-view.

- Allow to limit the maximum number of lines in the icons-view
- Allow to specify a maximum width in the compact-view

(No limit is required for the details-view, as the name is shortened
automatically to show other columns)

BUG: 288596
FIXED-IN: 4.9.0
2012-04-14 00:28:24 +02:00
Peter Penz
31ee4085c2 Use KMessageWidget for error- and information-messages
See http://agateau.com/2011/04/21/kde-ux-2011/ for more details.
This simplifies the statusbar in Dolphin a lot and allows to
do a proper eliding in case if status-messages are too long: In
this case a tooltip will show the whole status-message (thanks
to Wolfgang Mader for the initial patch!).

There is still missing some finetuning but the general approach
seems to work quite nice.

BUG: 249638
BUG: 245618
BUG: 146533
FIXED-IN: 4.9.0
2012-04-13 00:11:36 +02:00
Peter Penz
2c4e59a16f Fix outdated statusbar message when entering an empty folder
BUG: 291641
FIXED-IN: 4.9.0
2012-04-11 22:21:46 +02:00
Peter Penz
40c71d5ce0 KFileItemModel: interface cleanups
Fix some naming inconsistencies regarding the usage of 'dir' vs.
'directory' vs. 'folder'.
2012-04-11 21:53:45 +02:00
Peter Penz
ff0a86288e Fix compile issue resulted by commit 2caff15b 2012-04-11 20:45:19 +02:00
Peter Penz
b28a5a6248 Minor API-cleanups for DolphinView 2012-04-11 16:43:11 +02:00
Peter Penz
6c3d9acbc2 KItemViews: Internal directory restructuration
- Move all private headers from the kitemviews-directory into
the 'private' subdirectory.

- Get rid of DolphinDirLister and just use a directory-lister
  internally in KFileItemModel.

- Minor interface-cleanups for signals
2012-04-11 16:08:32 +02:00
Peter Penz
d9dbd3398a Improvements for slow sorting roles
If the sorting is done for data which is resolved asynchronously
(e.g. rating), it is important to give a visual feedback about
the state of the sorting. This is done now by a progress
indication in the statusbar.

Also optimizations for "Sort by type" have been done: Although
resolving a type can be expensive in the most often case it is a
very cheap operation. So it the sorting is done by type, try
to resolve the type synchronously for at least 200 ms to prevent
a asynchronous resorting. This is usually sufficient to have
resolved types even for directories with several thousands of
items.

BUG: 292733
FIXED-IN: 4.9.0
2012-04-10 16:36:26 +02:00
Stephen Kelly
b8c3d933e6 Add some missing includes.
These are needed in Qt5/KF5.
2012-04-10 00:20:22 +02:00
Stephen Kelly
d2a73971d8 Remove QBool headers. 2012-04-10 00:20:22 +02:00
Peter Penz
16e5740828 Revert the 2.0 decision to always use KB for file-sizes
The feedback on bugs.kde.org has shown that the previous behavior
(= show size with best-matching unit) is preferred by most users.
I initially wanted to make this configurable, but for implementing
it in a non-hacky way extending KLocale from kdelibs would have
been required. I'm not sure whether the usecase in Dolphin justifies
having such a configuration in KLocale - however as kdelibs is frozen
at the moment this is no option and the old behavior has been
restored.

BUG: 289850
FIXED-IN: 4.9.0
2012-04-09 09:50:17 +02:00
Peter Penz
e0ac8b61fb Layout improvements for settings
- Handle 'Context Menu' settings as part of the services
- Handle 'Version Control' settings as part of the services
- Move the confirmations-settings into own tab
- Use combobox for view-property settings
- A lot of minor spacing cleanups
2012-04-08 23:18:20 +02:00
Peter Penz
05082aed16 Ignore maximum size for local files when creating previews
It is up to the plugins to decide what sensible size is required for
creating a preview, this cannot be decided by the user for all
plugins. A maximum size only makes sense for remote files, where
the user implicitely decides how much of the bandwith may be used
for having previews.

BUG: 273226
FIXED-IN: 4.9.0
2012-04-08 16:12:06 +02:00
Peter Penz
02f122f33c Remove unneeded/wrong signal-slot-connection 2012-04-08 15:25:38 +02:00
Peter Penz
d90da9a85e Remove toolbar-spacer if the menu has been disabled
Aligning the control-button to the right of Dolphin has the problem
that sub-menus might be opened on the left of the menu if the Dolphin
window reaches the right of the desktop. So the toolbar-spacer has
been removed and a default label has been applied to the control-button
to increase the target-area for opening the menu.
2012-04-08 00:11:17 +02:00
Peter Penz
1fe46e7dcc Fix drag & drop cursor issue
When dragging a file within the same Dolphin window and the Ctrl, Shift
or Alt-key is pressed the shape of the cursor was not changed to
indicate the copy/move/link-operation.

BUG: 293850
FIXED-IN: 4.8.3
2012-04-07 23:14:43 +02:00
Peter Penz
1ea1f351d6 Use stars for showing the rating in the group headers 2012-04-07 20:59:54 +02:00
Peter Penz
305ecd86f9 Just use "-" instead of "No destination" for the destination-role 2012-04-07 15:09:44 +02:00
Peter Penz
94a44c03e4 Provide proper translation for orientation-EXIF-value 2012-04-07 09:49:31 +02:00
Peter Penz
f4fd2c201f Show a placeholder for roles that are empty 2012-04-07 09:15:42 +02:00
Peter Penz
99f19a820b Icons Mode: Fix wrong width calculation of additional roles 2012-04-07 00:03:42 +02:00