Commit graph

3794 commits

Author SHA1 Message Date
Peter Penz
b2f9e0758e Assure to mark an item as unhovered on a drag-leave event
BUG: 292501
FIXED-IN: 4.8.1
2012-01-28 11:04:20 +01:00
Peter Penz
452e2edaec --warning 2012-01-28 10:51:15 +01:00
Peter Penz
2c3e9fa5b5 --warning 2012-01-28 10:50:56 +01:00
Peter Penz
b8edfd993b --warning 2012-01-28 10:47:56 +01:00
Peter Penz
bcd2828f96 --warning 2012-01-28 10:47:17 +01:00
Peter Penz
f8f5cf8760 Fix regression: Allow dragging items on a tab
BUG: 292505
FIXED-IN: 4.8.1
2012-01-27 22:02:42 +01:00
Peter Penz
05fec8d24b Don't crash when opening a tab with enabled split view
BUG: 292470
FIXED-IN: 4.8.1
2012-01-27 22:02:42 +01:00
Peter Penz
a4553c9747 Fix regression: Allow dragging items on a tab
BUG: 292505
FIXED-IN: 4.8.1
2012-01-27 22:01:05 +01:00
Peter Penz
329f6009a8 Don't crash when opening a tab with enabled split view
BUG: 292470
FIXED-IN: 4.8.1
2012-01-27 22:01:04 +01:00
Frank Reininghaus
c7d6f43a94 Handle folder names containing spaces correctly in the Folders Panel
The problem was that KFileItemModel::setExpanded() used KUrl::url()
to determine the names of the subfolders. This method encodes special
characters, such that comparing the folder names with the unencoded URLs
stored in the model fails.
Using KUrl::path(), which does not encode special characters, fixes the
problem.

CCBUG: 291781
FIXED-IN: 4.8.1
(cherry picked from commit 80d9bfec58)
2012-01-25 21:35:00 +01:00
Frank Reininghaus
2a812eaf7d Handle folder names containing spaces correctly in the Folders Panel
The problem was that KFileItemModel::setExpanded() used KUrl::url()
to determine the names of the subfolders. This method encodes special
characters, such that comparing the folder names with the unencoded URLs
stored in the model fails.
Using KUrl::path(), which does not encode special characters, fixes the
problem.

BUG: 291781
FIXED-IN: 4.8.1
2012-01-25 21:32:49 +01:00
Peter Penz
14d5a32475 Terminal: only consider process IDs > 0
Thanks to Jekyll Wu for the analyses.

CCBUG: 286367
2012-01-25 15:20:59 +01:00
Peter Penz
3a84f2223b Terminal: only consider process IDs > 0
Thanks to Jekyll Wu for the analyses.

CCBUG: 286367
2012-01-25 15:20:17 +01:00
Frank Reininghaus
fbb73966b2 Make sure that Control+click toggles the selection state
This commit fixes a regression caused by the recent commit
9f711b5f2e.
CCBUG: 292250
(cherry picked from commit 84a9cc4bf6)
2012-01-23 19:38:26 +01:00
Frank Reininghaus
30b65ef939 Make sure that Control+click toggles the selection state
This commit fixes a regression caused by the recent commit
9f711b5f2e.
BUG: 292250
2012-01-23 19:28:21 +01:00
Script Kiddy
0f2faadef4 SVN_SILENT made messages (.desktop file) 2012-01-22 09:28:28 +01:00
Frank Reininghaus
a043163b61 Do not make items invisible when turning off previews
This commit fixes a problem in KItemListView::doLayout(): This function
assumed that firstVisibleIndex is a constant.
However, if the view is scrolled to the bottom with previews enabled,
and then previews are disabled (and the icon size is much smaller
without previews), this function changes the scroll offset, which also
changes the the first visible index. Using the unchanged variable causes
trouble later on (i.e., it makes items which are actually inside the
view area invisible).
lastVisibleIndex is not needed before the scroll offset change and is
const after that, so its calculation is moved a few lines down.
CCBUG: 291841
FIXED-IN: 4.8.1
(cherry picked from commit cc8f5b4939)
2012-01-19 19:57:51 +01:00
Frank Reininghaus
8b73ea3061 Do not make items invisible when turning off previews
This commit fixes a problem in KItemListView::doLayout(): This function
assumed that firstVisibleIndex is a constant.
However, if the view is scrolled to the bottom with previews enabled,
and then previews are disabled (and the icon size is much smaller
without previews), this function changes the scroll offset, which also
changes the the first visible index. Using the unchanged variable causes
trouble later on (i.e., it makes items which are actually inside the
view area invisible).
lastVisibleIndex is not needed before the scroll offset change and is
const after that, so its calculation is moved a few lines down.
BUG: 291841
FIXED-IN: 4.8.1
REVIEW: 103731
2012-01-19 19:52:51 +01:00
Dawit Alemayehu
d13504b5a7 When populating the "Show Remote Encoding" menu, put the check mark besides
the correct saved remote encoding charset.

BUG: 186289
FIXED-IN: 4.8.0
REVIEW: 103730
(cherry picked from commit 8f231bd081)
2012-01-18 18:05:15 -05:00
Dawit Alemayehu
7dc1741277 When populating the "Show Remote Encoding" menu, put the check mark besides
the correct saved remote encoding charset.

BUG: 186289
FIXED-IN: 4.8.0
REVIEW: 103730
2012-01-18 16:23:18 -05:00
Frank Reininghaus
0b0b2cba93 Make PageUp/PageDown work in Dolphin's new view engine
BUG: 288748
FIXED-IN: 4.8.0
REVIEW: 103721
(cherry picked from commit e56a363aa6)
2012-01-18 10:46:47 +01:00
Frank Reininghaus
6a338f28e5 Make PageUp/PageDown work in Dolphin's new view engine
BUG: 288748
FIXED-IN: 4.8.0
REVIEW: 103721
2012-01-18 10:18:47 +01:00
Frank Reininghaus
375b35762d Fix typo, which caused a Qt runtime warning when closing Dolphin
(cherry picked from commit dbf0bfffa7)
2012-01-18 09:39:07 +01:00
Frank Reininghaus
aff9b9570e Fix typo, which caused a Qt runtime warning when closing Dolphin 2012-01-18 09:37:06 +01:00
Peter Penz
61c742dada Avoid unnecessary animations when switching view modes
Thanks to Nikita Skovoroda for the initial patch and the analyses.

BUG: 290947
FIXED-IN: 4.8.0
2012-01-17 23:45:23 +01:00
Peter Penz
cc0ce2a7aa Fix probably wrong alternative background color
Thanks to Nikita Skovoroda for the patch!

CCMAIL: chalkerx@gmail.com
2012-01-17 23:45:23 +01:00
Peter Penz
c712b9a427 Do a synchronous layout for dynamic item sizes when changing the geometry
This prevents a delayed update when resizing the window e.g. in the details
view. As no animated item position changes can happen for dynamic item sizes
the synchronous relayout is fine from a performance point of view.

BUG: 290953
FIXED-IN: 4.8.0
2012-01-17 23:45:23 +01:00
Peter Penz
e96af09351 Avoid unnecessary animations when switching view modes
Thanks to Nikita Skovoroda for the initial patch and the analyses.

BUG: 290947
FIXED-IN: 4.8.0
2012-01-17 23:44:28 +01:00
Peter Penz
8b8091f275 Fix probably wrong alternative background color
Thanks to Nikita Skovoroda for the patch!

CCMAIL: chalkerx@gmail.com
2012-01-17 21:19:34 +01:00
Peter Penz
7f718123b2 Do a synchronous layout for dynamic item sizes when changing the geometry
This prevents a delayed update when resizing the window e.g. in the details
view. As no animated item position changes can happen for dynamic item sizes
the synchronous relayout is fine from a performance point of view.

BUG: 290953
FIXED-IN: 4.8.0
2012-01-17 21:11:49 +01:00
Script Kiddy
cc9697b44c SVN_SILENT made messages (.desktop file) 2012-01-17 16:33:32 +01:00
Peter Penz
ab61a6174e Disable smooth-scrolling dependent on the graphics-effect level
If the graphics-effect-level has been set to NoEffects (systemsettings -> Appearance
-> Style -> Fine Tuning), the smooth scrolling in Dolphin will be disabled.

Additionally the duration for the smooth-scrolling has been decreased from 200 ms
to 100 ms to reduce the lag.

A wrong calculation of the end-value has been fixed that might trigger
a wrong position of the content.

BUG: 291740
BUG: 291607
FIXED-IN: 4.8.0
2012-01-17 10:04:00 +01:00
Peter Penz
52b6f68bf8 Disable smooth-scrolling dependent on the graphics-effect level
If the graphics-effect-level has been set to NoEffects (systemsettings -> Appearance
-> Style -> Fine Tuning), the smooth scrolling in Dolphin will be disabled.

Additionally the duration for the smooth-scrolling has been decreased from 200 ms
to 100 ms to reduce the lag.

A wrong calculation of the end-value has been fixed that might trigger
a wrong position of the content.

BUG: 291740
BUG: 291607
FIXED-IN: 4.8.0
2012-01-17 10:03:22 +01:00
Frank Reininghaus
555364c006 If an item is clicked to trigger it, clear the rest of the selection
Note that the clearing is not done on mouse press, but on mouse release.
The reason is that there are situations when multiple items are selected
and pressing the mouse on one of them should not clear the selection
(e.g., drag and drop of multiple items).

BUG: 290854
REVIEW: 103703
FIXED-IN: 4.8.0
(cherry picked from commit 9f711b5f2e)
2012-01-16 20:03:49 +01:00
Frank Reininghaus
63cce810a3 If an item is clicked to trigger it, clear the rest of the selection
Note that the clearing is not done on mouse press, but on mouse release.
The reason is that there are situations when multiple items are selected
and pressing the mouse on one of them should not clear the selection
(e.g., drag and drop of multiple items).

BUG: 290854
REVIEW: 103703
FIXED-IN: 4.8.0
2012-01-16 19:59:54 +01:00
Peter Penz
a7295033e6 Use new icon for "Show in groups"
This allows adding the "Show in groups" action to the toolbar with
a nice icon.

CCBUG: 290632
2012-01-16 15:39:46 +01:00
Peter Penz
d93cf037ea Use new icon for "Show in groups"
This allows adding the "Show in groups" action to the toolbar with
a nice icon.

CCBUG: 290632
2012-01-16 15:38:59 +01:00
Script Kiddy
d0fe7390b6 SVN_SILENT made messages (.desktop file) 2012-01-16 09:28:43 +01:00
Patrick Spendrin
6e9c5ad58e fix build of tests on windows
(cherry picked from commit 24213ae6cc)
2012-01-15 15:50:48 +01:00
Patrick Spendrin
377ce832e1 fix build of tests on windows 2012-01-15 15:49:34 +01:00
Peter Penz
8d7a2c96ea Don't select items if the selection toggle has been disabled 2012-01-15 10:51:46 +01:00
Peter Penz
dd98f41056 Don't select items if the selection toggle has been disabled 2012-01-15 10:51:17 +01:00
Peter Penz
8306a0fa6c Don't show a expanding-toggle in the Folders Panel if there are no subdirectories
BUG: 290745
FIXED-IN: 4.8.0
2012-01-15 10:41:44 +01:00
Peter Penz
df6a28653e Don't show a expanding-toggle in the Folders Panel if there are no subdirectories
BUG: 290745
FIXED-IN: 4.8.0
2012-01-15 10:41:06 +01:00
Peter Penz
f38a70f5d0 Assure an active view when activating an item
This might not be the case when e.g. having a split view, having enabled the "auto
expand folders" option and dragging an item from the active view to another
folder of the inactive view.
2012-01-14 22:02:23 +01:00
Peter Penz
ed429d7309 Assure an active view when activating an item
This might not be the case when e.g. having a split view, having enabled the "auto
expand folders" option and dragging an item from the active view to another
folder of the inactive view.
2012-01-14 22:01:58 +01:00
Peter Penz
fcfb636ffe Fix "general settings" issues
If the general settings for the "selection toggle" or "expanding folders during
drag operations" are changed, those changes must be applied to the engine.
2012-01-14 21:46:41 +01:00
Peter Penz
538d9bf43f Fix "general settings" issues
If the general settings for the "selection toggle" or "expanding folders during
drag operations" are changed, those changes must be applied to the engine.
2012-01-14 21:46:07 +01:00
Peter Penz
a0115f912a Fix issue when deleting items with the context menu
Thanks to Jekyll Wu for the analyses of the issue!

BUG: 290307
BUG: 269096
BUG: 290954
BUG: 264583
FIXED-IN: 4.8.0
2012-01-14 20:06:05 +01:00
Peter Penz
9da248fa26 Fix issue when deleting items with the context menu
Thanks to Jekyll Wu for the analyses of the issue!

BUG: 290307
BUG: 269096
BUG: 290954
BUG: 264583
FIXED-IN: 4.8.0
2012-01-14 20:05:09 +01:00