row using right/left arrow" and "jump to next/previous column using
down/up arrow" when using the Icon View's "Rows" and "Columns"
arrangement, respectively, in the following cases:
1. In "Columns" arrangement, if the first item is selected and
Ctrl-Down is pressed repeatedly, don't deselect the first item when
jumping to the next column.
2. In "Rows" arrangement, if the first item in the second row is
active and then Left and finally Shift-Left is pressed, don't
re-select the first item in the second row unexpectedly.
3. If an item in the middle of the second row is selected, make sure
that selection with Shift-Left/Shift-Right is reversible even if the
previous/next row is reached.
svn path=/trunk/KDE/kdebase/apps/; revision=996758
RevisionControlObserver is implemented in a way that no recognizable slowdown is given for directories that are not under revision control.
CCBUG: 192158
svn path=/trunk/KDE/kdebase/apps/; revision=995351
- Don't connect to KDirLister::itemDeleted(const KFileItem&), but KDirLister::itemsDeleted(const KFileItemList&). Otherwise Dolphin is informed about each single file deletion instead of getting the deleted items as a list. Thanks to David Faure for the hint!
- DolphinViewContainer::updateStatusBar() can be expensive when a lot of files are selected, as the file size must get retrieved. Assure that fast calls for updateStatusBar() don't trigger a synchronous update, do the update after 300 ms where no further update has been triggered.
- Dolphin provides a list of file items when emitting the selectionChanged() signal. Collecting the file items is a quite expensive operation, so use the same approach as when updating the statusbar: only emit the selection changed signal when no change has been done within 300 ms. This improves the performance when doing huge selections a lot.
- Make updateStatusBar() a private method, the main window should not need to take care about updating the statusbar (this is done internally now by DolphinViewContainer).
BUG: 199090
BUG: 195787
CCBUG: 199352
CCBUG: 188218
svn path=/trunk/KDE/kdebase/apps/; revision=995015
QVariant to QString() is not the same as calling clear on the QVariant (which makes the variant invalid).
(BUG 194502)
svn path=/trunk/KDE/kdebase/apps/; revision=994217
- minor adjustment of name
- use same declaration order as other private methods
CCMAIL: predator106@gmail.com
svn path=/trunk/KDE/kdebase/apps/; revision=994089
Now they are ellided, so e.g. "really really long folder name...is" or something.
Few more cases left for me to fix(shortly), but those are not quite close to this section.
svn path=/trunk/KDE/kdebase/apps/; revision=993618
To keep the Information Panel maintainable and prepared for future features a cleanup has been done. The whole user interface handling has been moved into the class InformationPanelContent that offers a straight forward interface: showItem(const KFileItem& item) and showItems(const KFileItemList& items).
The class InformationPanel is responsible for calling those methods in a way that hovering items, changing directories, doing selections, rename and delete operations, ... don't result in calling showItem() 10 times per second.
This cleanup won't be backported to KDE 4.3.x
svn path=/trunk/KDE/kdebase/apps/; revision=991902
- When changing a directory the receiving of the meta data is done now with a short delay. This gives the directory lister the chance to show the directory as fast as possible.
- Prevent that DolphinInformationPanel::reset() is invoked when changing a directory. The method only needs to get invoked if an item has been deleted or renamed.
- Cache an unknown file item. This improves the startup time of Dolphin (-> KFileItem constructor is invoked only once instead of up to 6 times).
svn path=/trunk/KDE/kdebase/apps/; revision=991840
No backport to KDE 4.3.x is done until the patch has proven to work well under all circumstances.
BUG: 152985
CCMAIL: tahseen.mohammad@gmail.com
CCMAIL: frank78ac@googlemail.com
svn path=/trunk/KDE/kdebase/apps/; revision=991780
that %B and %Y actually get replaced by month and year. Today seemed
to be a good day to reproduce and fix this :-)
BUG: 179262
svn path=/trunk/KDE/kdebase/apps/; revision=990131
(...)" check was more or less equivalent to "if (false)" here ;-) I've
verified that the "Create New..." menu is still enabled correctly when
switching columns in Columns view, which is what the "if" check
was added for in the first place.
svn path=/trunk/KDE/kdebase/apps/; revision=988119
DolphinView::selectedItemsCount(). This fixes the problem that the
"Compare Files" action may be disabled or enabled incorrectly.
BUG: 181134
svn path=/trunk/KDE/kdebase/apps/; revision=985402
- don't provide any mode for editing, just let the user directly manipulate the comment inside the text widget
- automatically save changes, no explicit confirmation required
svn path=/trunk/KDE/kdebase/apps/; revision=984592
