Commit graph

433 commits

Author SHA1 Message Date
Shaun Reich 9c095f56fd Use currentIndexChanged() signal instead of activated(), the latter does not always do what you would think.
svn path=/trunk/KDE/kdebase/apps/; revision=933889
2009-03-01 21:11:12 +00:00
Peter Penz ec8a75b90c adjust size hints of group boxes
svn path=/trunk/KDE/kdebase/apps/; revision=932509
2009-02-26 20:10:27 +00:00
David Faure fd6be5b9af Calling the "Show" group "hiddenGroup" is a bit surprising to the casual reader ;)
svn path=/trunk/KDE/kdebase/apps/; revision=932508
2009-02-26 20:08:22 +00:00
Peter Penz 5411363284 remember which service menus should be shown in the context menu
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=932504
2009-02-26 19:58:22 +00:00
Peter Penz 26acdb7c77 Provide a basic UI for the "Services" settings dialog. It's open yet whether installing services by the internet will make it into Dolphin/Konqueror for KDE 4.3, but at least turning off services (without deinstalling applications...) will be supported.
svn path=/trunk/KDE/kdebase/apps/; revision=931854
2009-02-25 20:53:17 +00:00
Peter Penz 540eeb0030 Remember the used URL completion mode of the URL navigator. Thanks to Frank Reininghaus for the patch!
BUG: 170502

svn path=/trunk/KDE/kdebase/apps/; revision=929111
2009-02-20 16:55:25 +00:00
Shaun Reich 02aa3f8ea0 The tab order of the View Properties Dialog now moves in a logical and coherent manner (it no longer skips out of order).
svn path=/trunk/KDE/kdebase/apps/; revision=927483
2009-02-17 16:40:59 +00:00
Shaun Reich 0e467ea6ab I forgot to change these connection statements to both send and receive boolean values in my prior commit(s). Now the View Properties Dialog will enable the apply button when the affected (4) widget values are changed.
svn path=/trunk/KDE/kdebase/apps/; revision=926757
2009-02-16 04:40:17 +00:00
Shaun Reich 8ce343ba3d Added the Trash KCM to Dolphin, it's visible in the Settings Dialog, in the 'Trash" page.
Konqueror has it, we should too =)

svn path=/trunk/KDE/kdebase/apps/; revision=926571
2009-02-15 18:06:04 +00:00
Shaun Reich 614a1a1861 The View Properties dialog now correctly disables/enables the Apply button, instead of it just being enabled all the time, even after you apply it, so it's similar to the Settings Dialog now.
svn path=/trunk/KDE/kdebase/apps/; revision=926562
2009-02-15 17:30:00 +00:00
Shaun Reich 4157103173 Changed connections of the signals activated(), to currentIndexChanged() as used in 3 QComboBoxes. Remember that activated() is not always triggered when the selected item is changed.
svn path=/trunk/KDE/kdebase/apps/; revision=926180
2009-02-14 19:45:25 +00:00
Shaun Reich 5c53ea1f60 The Home folder location, when set via loadSettings(), and when set via the 'Use Default Location' button, now will use KUrl::prettyUrl(); Prior to this, saving an address of '/home/user/' would be changed to 'file:///home/user' (on Linux) normally (through applySettings()). However, when the listed methods were called, the text of the line edit would be just '/home/user/'. It will now (basically) be set to 'file:///'... all throughout.
svn path=/trunk/KDE/kdebase/apps/; revision=920943
2009-02-04 03:44:13 +00:00
Shaun Reich 6969b704c0 Added const bools for a few settings that were referenced more than once. Otherwise, the fellow coder would probably just think these were taken out of seemingly thin air.
svn path=/trunk/KDE/kdebase/apps/; revision=920920
2009-02-04 01:24:38 +00:00
Peter Penz 7af662dc12 rename the checkbox "Browse through archives" to "Open archives as folder"
CCBUG: 182991

svn path=/trunk/KDE/kdebase/apps/; revision=920733
2009-02-03 17:54:33 +00:00
Peter Penz aa885d4e21 SVN_SILENT: updated comment
svn path=/trunk/KDE/kdebase/apps/; revision=920731
2009-02-03 17:49:27 +00:00
Peter Penz 58373c05fe * no general settings are read -> invoking loadSettings has no effect in restoreDefaults()
* use constants for the defaults, as hardcoding the defaults in 2 methods might be error-prone when changing the defaults in future

CCMAIL: predator106@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=920531
2009-02-03 06:24:39 +00:00
Shaun Reich 4f00fc19cd String change - Added clarification in the displayed message box for when the settings are applied in the Startup page, and there is an error. This is under the home folder setting. It now says that "the home folder is invalid or does not exist" as opposed to just saying it is invalid. I believe that it was kind of misleading as to what was wrong, so I figured it should give them _some_ hint as to what the problem is.
svn path=/trunk/KDE/kdebase/apps/; revision=920501
2009-02-03 03:20:47 +00:00
Shaun Reich 5d230c956f SVN_SILENT Small update to a comment.
svn path=/trunk/KDE/kdebase/apps/; revision=920497
2009-02-03 01:40:30 +00:00
Shaun Reich 58c95bc8d8 Both the 'preview size' slider and the 'embed thumbnails in files' settings now restore to defaults when asked to.
svn path=/trunk/KDE/kdebase/apps/; revision=920491
2009-02-03 01:20:53 +00:00
Shaun Reich a8d577ff2d A few more fixes...mostly cleanups.
*Grouped some statements that it didn't make sense to put after a certain block of code (giving the impression that it had to be after this block).
*There is no need to set the value of the QSpinBox equal to that of the slider, when loading settings... their valueChanges() signals are connected to the opposite one's slot.
*Made a now unused variable be used, it was inconsistent in this code block, two times '1' was used, but other times a var set to '1' would be used.
*Moved some blocks of code from the loadSettings() method, into the constructor, since the loadSettings() method is called more than once, so it's more resource-friendly to do it this way.

svn path=/trunk/KDE/kdebase/apps/; revision=920441
2009-02-02 22:23:06 +00:00
Shaun Reich c2429b1dcb We were calling methods within loadSettings() which should have been moved to inside the constructor instead. Examples include setting up a slider's notch-type(bottom or top). Especially significant since loadSettings() gets called more often than the constructor.
svn path=/trunk/KDE/kdebase/apps/; revision=920419
2009-02-02 21:35:37 +00:00
Shaun Reich 97425edcf6 Navigation click type (single/double-click) now gets set to it's default when asked (the default is single-click).
svn path=/trunk/KDE/kdebase/apps/; revision=920400
2009-02-02 20:40:33 +00:00
Shaun Reich 8230d0f7f4 Changed group config reference pertaining to the "kcminputrc" file. The Navigation page setting of whether to use single/double click navigation now saves itself properly, instead of insisting on using single-click. :)
P.S. Bear in mind that the setting still does not apply itself until a restart of Dolphin.

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=920390
2009-02-02 20:14:42 +00:00
Shaun Reich c48b347e58 Reverted my previous commit(919897), I was incorrect, it looked to work like this, but didn't.
svn path=/trunk/KDE/kdebase/apps/; revision=920374
2009-02-02 19:43:02 +00:00
Shaun Reich 952fc86039 Confirmations of the following settings now reset themselves to their defaults:
*Move to Trash
*Delete
These are located in the General page->Context Menu tab of the settings dialog.

svn path=/trunk/KDE/kdebase/apps/; revision=920205
2009-02-02 14:44:25 +00:00
Shaun Reich bacc9c9137 The "Show 'Delete' Command" checkbox now gets restored to it's default (false).
svn path=/trunk/KDE/kdebase/apps/; revision=919996
2009-02-02 02:38:42 +00:00
Shaun Reich 9587d04b80 These radio buttons are paired, when you enable one, you inherently disable the other, so we're just repeating ourselves by doing this manually.
svn path=/trunk/KDE/kdebase/apps/; revision=919995
2009-02-02 02:34:57 +00:00
Shaun Reich e3bf301477 I forgot to change these three tabs to the new method usage also. Effected was the View Modes page.
svn path=/trunk/KDE/kdebase/apps/; revision=919919
2009-02-01 21:01:06 +00:00
Shaun Reich 9f7c2424d9 Now when you click the button "Defaults" in the settings dialog, it will push the settings to the UI, then the user can apply, cancel, or modify them from there. Also removed the message box prompt. Use settings->useDefaults(true), then set it back to false after you are done loading settings in the restoreDefaults() method calls. Don't use ->setDefaults() normally, anymore.
svn path=/trunk/KDE/kdebase/apps/; revision=919897
2009-02-01 20:43:26 +00:00
Shaun Reich 2632ea2643 Default size and Preview size sliders, were using wrong signal to notify that settings have changed. The keyboard, when used on the slider, wouldn't enable the apply button, nor clicking to either side of the slider to change it. sliderMoved signal emission changed to valueChanged. Effects all tabs in Settings Dialog->View Modes.
svn path=/trunk/KDE/kdebase/apps/; revision=917972
2009-01-28 21:27:16 +00:00
Shaun Reich 68b3e86fdf The apply button in the settings dialog now disables itself when settings are applied, as per all of the other KDE applications, added in DolphinSettingsDialog::applySettings(). It was already setup to re-enable on a settings change.
svn path=/trunk/KDE/kdebase/apps/; revision=917168
2009-01-27 01:13:03 +00:00
Peter Penz 8acb68ed28 Relayout of the settings dialog, so that all Dolphin KPart relevant settings can be made available in Konqueror's settings dialog too. Further cleanups and layout fixes are required and will be done during the next week.
svn path=/trunk/KDE/kdebase/apps/; revision=912587
2009-01-17 18:42:06 +00:00
Peter Penz 307285e963 Group classes into folders, Dolphin is too big in the meantime for having a flat directory hierarchy. dolphin/src/CMakeLists.txt will be cleaned up later.
svn path=/trunk/KDE/kdebase/apps/; revision=911065
2009-01-14 19:26:23 +00:00