Commit graph

34 commits

Author SHA1 Message Date
David Faure
3b5ccaacf5 Fix memory leak
svn path=/trunk/KDE/kdebase/apps/; revision=1119153
2010-04-26 17:29:02 +00:00
David Faure
f55ff68840 Move the bookmark model (+commands +commandhistory) into a lib of its own, for future sharing with other parts of kdebase
(e.g. bookmark toolbar and bookmark sidebar).
Not sure if it should end up in libkonq or libkio...
CCMAIL: hein@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=1118280
2010-04-24 09:06:17 +00:00
David Faure
7f5e80a8d3 Unbreak favicon checking; in many error cases it wouldn't proceed to the next item.
Also when the cached favicon was recent enough, then the kded module wouldn't emit anything;
fixed by adding a "forceDownloadHostIcon" and an error signal in the favicons kded module.
CCBUG: 23102
 (and probably others)

svn path=/trunk/KDE/kdebase/apps/; revision=1116050
2010-04-18 14:24:11 +00:00
David Faure
1cd5acff40 remove dep on globalbookmarkmanager.h; move m_model to holder
svn path=/trunk/KDE/kdebase/apps/; revision=1115823
2010-04-17 16:01:46 +00:00
David Faure
c2dee9346d Get rid of two more singletons (how many singletons can one have in a single program?)
svn path=/trunk/KDE/kdebase/apps/; revision=1115716
2010-04-17 08:10:35 +00:00
David Faure
4c3122d106 Fix the display of link and favicon status, by using KBookmark::metaDataItem/setMetaDataItem
rather than the ugly and wrong recursive descent that was done here [wrong because it was writing
into the freedesktop.org metadata rather than into the www.kde.org metadata]

svn path=/trunk/KDE/kdebase/apps/; revision=1112544
2010-04-08 12:50:34 +00:00
David Faure
054cbc204c Port favicon and testlink to having their own model pointer.
Try to repair these things (the status wasn't returned by the model), but doesn't seem to work yet.

svn path=/trunk/KDE/kdebase/apps/; revision=1112533
2010-04-08 12:16:33 +00:00
Tom Albers
671b224bd8 RELICENSE: GPL2->GPL2+/GPL23
svn path=/trunk/KDE/kdebase/apps/; revision=751022
2007-12-20 22:23:07 +00:00
Daniel Teske
e84f28dc47 Small changes to make it compileSmall changes to make it compile.
svn path=/trunk/KDE/kdebase/apps/; revision=707874
2007-09-03 07:53:52 +00:00
Laurent Montel
264d696087 Adapt to new KWarning/kFatal/kDebug api
svn path=/trunk/KDE/kdebase/apps/; revision=695870
2007-08-03 06:40:12 +00:00
Dirk Mueller
52d6d2f9ce include cleanup
svn path=/trunk/KDE/kdebase/apps/; revision=663054
2007-05-09 22:23:52 +00:00
Laurent Montel
49ebc2ce72 #include <q...h> -> #include <Q...>
svn path=/trunk/KDE/kdebase/nsplugins/; revision=539617
2006-05-11 08:04:23 +00:00
Tim Beaulen
abb9701b64 Less warnings about deprecated functions
svn path=/trunk/KDE/kdebase/apps/; revision=526457
2006-04-04 18:12:34 +00:00
Laurent Montel
aed1a8b78d deprecated--
svn path=/trunk/KDE/kdebase/konqueror/; revision=506335
2006-02-06 15:07:10 +00:00
Dirk Mueller
40b74b7fc1 SVN_SILENT: fix typo
svn path=/trunk/KDE/kdebase/nsplugins/; revision=467416
2005-10-05 08:44:32 +00:00
Daniel Teske
40c354dcc3 Remove Q3PtrList from BookmarkIterator and derived classes.
Replave QVector<KBookmark> by QList<KBookmark> (== KBookmark::List).


svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=464923
2005-09-28 16:16:52 +00:00
Daniel Teske
aa3cb7cfe7 Forgot to remove these #includes
svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=462406
2005-09-20 23:47:35 +00:00
Daniel Teske
fddf326d4e Port keditbookmarks to Qt4's model/view framework.
Editing, creating and selecting bookmarks works.
For deleting you have to run apply-patches in your qt-copy directory.
All other things are broken. (E.g. drag'n'drop, the edit fields at the bottom, the searchline...)

I wrote down some of my learned lessons while working with Qt4's model/view framework
at http://www.squorn.de/kde/qtmodelview.html


svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=448977
2005-08-13 20:13:21 +00:00
Stephan Kulow
e77f20dbaf svn merge svn+ssh://coolo@svn.kde.org/home/kde/trunk/KDE/kdebase@438057
svn+ssh://coolo@svn.kde.org/home/kde/branches/work/kde4/kdebase
          .

I couldn't resolve one kicker conflict that results from different
development directions, so I rely on Aaron to sort it out - the file
is commited with conflicts

svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=439627
2005-07-28 14:59:42 +00:00
Dirk Mueller
b3736b51bc update FSF address
svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=431577
2005-07-04 19:02:09 +00:00
Daniel Teske
d42dfcb445 Naively iterating over a container while removing
the contents is evil. Doing the same to a
QPtrList is evil.
Cancel Checks and Cancel Favicons Update didn't
abort every Iterator.


svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=423899
2005-06-10 01:08:43 +00:00
David Faure
41aff60420 Fix compiler warning, and fix wrong mode in emacs (this is C++, not perl)
svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=412727
2005-05-12 12:15:44 +00:00
Alexander Kellett
adc71c9a93 fix a bunch of favicon updating crashes
load/save the status columns size in init, was defaulting to 0
init m_canPaste to false, no idea why this doesn't fix the vg bt

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=260183
2003-10-19 16:23:37 +00:00
Alexander Kellett
807e476f82 indent to 4 spaces
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=257985
2003-10-11 13:39:50 +00:00
Alexander Kellett
7f65c026be sick of having two different coding styles between kio/bookmarks and here,
so, add 4 space modelines to all files. i'll gradually fix the files over
the coming days.

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=256804
2003-10-06 18:31:25 +00:00
Alexander Kellett
0458ac2248 reorder includes - $0.h, "*.h", <*.h>
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=251057
2003-09-14 18:07:31 +00:00
Alexander Kellett
2e828dce30 some isEmpty() usages in place of count() == 0
thx ossi :)

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=240526
2003-08-02 10:39:21 +00:00
Alexander Kellett
440dcd243e cruft removal
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=215527
2003-03-22 00:43:39 +00:00
Alexander Kellett
84f0b66e1d move data to privates and provide important const accessors
more const-ness fixes
cleanup (removal & renames) of member variables

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=212373
2003-03-08 15:26:42 +00:00
Alexander Kellett
c78d55307d renames:
doBlah -> doAction
   isBlahable -> isApplicable

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=211136
2003-03-03 20:52:39 +00:00
Alexander Kellett
5cecdebd4f replace another ugly ERROR comparison with hasParent use
favicons: don't crash on empty bookmark lists
make sure root qlistviewitem doesn't get added as bookmark

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=207858
2003-02-19 01:06:22 +00:00
Alexander Kellett
16dffadf69 more code section lines
shuffles

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=207152
2003-02-16 00:05:39 +00:00
Alexander Kellett
36f5b2e0f3 compile and stuff
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=206974
2003-02-15 01:24:14 +00:00
Alexander Kellett
4ff4b0c3e6 merge in make_it_even_cooler_branch
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=201732
2003-01-21 16:16:53 +00:00