Also when the cached favicon was recent enough, then the kded module wouldn't emit anything;
fixed by adding a "forceDownloadHostIcon" and an error signal in the favicons kded module.
CCBUG: 23102
(and probably others)
svn path=/trunk/KDE/kdebase/apps/; revision=1116050
Try to repair these things (the status wasn't returned by the model), but doesn't seem to work yet.
svn path=/trunk/KDE/kdebase/apps/; revision=1112533
Like drag and dropping bookmarks.
Filtering.
And various fixes all over the place.
Still not really where it should be for a release.
svn path=/trunk/KDE/kdebase/apps/; revision=748964
* Delete KonqFavIconMgr, was merely a dbus interface wrapper, so generate a org::kde::FavIcon instead. This also spotted a typo in the .xml file...
* Call favicon.downloadHostIcon synchronously instead of with NoBlock; was racy [sounds like a possible kde3 bug too, it was using send instead of call]
Blocking during that method call isn't a big problem anyway, if a real download has to happen it will be delayed via a KIO job anyway (-> the method returns fast).
* One must connect to a dbus signal using a real connect, in unit tests; QSignalSpy isn't enough since it's connect() that triggers some DBUS magic which makes our process listen to the signal. That's quite tricky and unexpected...
svn path=/trunk/KDE/kdebase/apps/; revision=730878
Editing, creating and selecting bookmarks works.
For deleting you have to run apply-patches in your qt-copy directory.
All other things are broken. (E.g. drag'n'drop, the edit fields at the bottom, the searchline...)
I wrote down some of my learned lessons while working with Qt4's model/view framework
at http://www.squorn.de/kde/qtmodelview.html
svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=448977
svn+ssh://coolo@svn.kde.org/home/kde/branches/work/kde4/kdebase
.
I couldn't resolve one kicker conflict that results from different
development directions, so I rely on Aaron to sort it out - the file
is commited with conflicts
svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=439627
(It used a broken design.)
Instead immediately forward changes in keditbookmarks
to all other kbookmarkmanagers.
BUG: 77355
svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=425768
so, add 4 space modelines to all files. i'll gradually fix the files over
the coming days.
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=256804