Commit graph

463 commits

Author SHA1 Message Date
Peter Penz
5a3e79e4ed Prevent unwanted item animations
When splitting the view or opening a new tab there should not be
any animation of the items due to a wrong initial viewport size.
2011-12-07 21:57:12 +01:00
Peter Penz
36b8989179 Fix shortcut issue with panels
The KAction instance of the panels is added to the menu instance
now instead of the QDock-actions. It is assured that the state
between the actions gets synchronized. Now it's possible for
the user to apply custom shortcuts and the shortcuts are also
shown in the menu as expected.

CCMAIL: lueck@hube-lueck.de
2011-11-21 11:08:26 +01:00
Peter Penz
3c079ee3f9 Show panel shortcuts in menu 2011-11-20 20:03:59 +01:00
Peter Penz
dc8ec1bf01 Fix crash when toggling the menu-bar visibility
Use a queued connection to prevent that the menu
gets hidden during it is still open. Thanks to
Christoph Feck for the hint!

Frank and I could not reproduce the issue in our
environments even when following the steps from
bug 278366, however Christoph's hint sounds sane
and let's hope it works (leaves a bad gut feeling
to "fix" bugs without being able to verify them).

CCBUG: 286822
CCBUG: 278366
FIXED-IN: 4.7.4
2011-11-19 06:51:31 +01:00
Peter Penz
3c77ffe832 Delete obsolete class DolphinSettings 2011-11-06 11:59:26 +01:00
Peter Penz
4fcb5662a7 Fix issues with applying wrong view-mode
- The view properties dialog mixed the details-view with
  the compact-view (#285848).

- The view properties have been reset when applying a
  setting from the "Dolphin Preferences" dialog. The rootcause
  was that the obsolete DolphinSettings class implemented
  the saving in a wrong way because of the recent refactoring
  (will remove this class completely now to prevent such
  issues in future).

BUG: 285848
FIXED-IN: 4.8.0
2011-11-06 09:56:14 +01:00
Peter Penz
90e39e3116 Allow changing shortcuts for the Panel actions
Until now the shortcuts of the Panel actions could not be changed
as they did not show up in the "Configure shortcuts..." dialog.

The patch is based on the work of "SiegeLord" and Fabian Henze
attached to bug 273050.

BUG: 273050
FIXED-IN: 4.8.0
2011-10-10 22:08:23 +02:00
Jaime Torres
c9156fdaf9 avoid two possible null pointer dereferences
move the setToolTip lines outside the if(action) inside it.
do not crash if there is no action.
2011-10-09 11:12:22 +02:00
Peter Penz
6551c000fc Context menu cleanups
- Open the context menu on the mouse-press event, not on the
  mouse-release event.
- Provide an explicit position-information and don't use
  QCursor::pos(). This fixes the issue that opening a context-menu
  by the keyboard opens below the cursor.
- Provide different signals in the KItemListController for
  the different context-menu types (item vs. view vs. header).
- Implement turning on/off roles by the header-context-menu.
2011-10-08 21:43:55 +02:00
Chirag Anand
9ca11175a4 Fixed bug for selecting files with --select parameter.
Files selected via --select parameter did not get current item focus.
And if files were deleted while being current item, updating the view
would select the next item instead of the first item in the list.

BUG: 257805
CCMAIL: peter.penz19@gmail.com
CCMAIL: frank78ac@googlemail.com
2011-09-22 18:08:49 +05:30
Peter Penz
8266e456a1 Simplified code for the viewmode settings 2011-09-02 19:49:49 +02:00
Peter Penz
e57bef0261 Remove "FirstRun" property
The property got obsoleted by the "Version" property.
2011-08-14 15:31:58 +02:00
Peter Penz
d11de1855f Don't enable the search panel per default
Assure that the search panel also stays disabled when updating
from an older Dolphin version.

BUG: 279348
FIXED-IN: 4.7.1
2011-08-13 12:45:14 +02:00
Kai Uwe Broulik
6e76582694 Add missing separators to the "Help" sub-menu of Dolphin's menubar replacement like all KDE apps have
BUG: 276560
2011-08-01 18:26:18 +02:00
Montel Laurent
08d655c2bc normalize signals/slots 2011-07-31 13:33:56 +02:00
Peter Penz
f23e9496f3 Merged very early alpha-version of Dolphin 2.0
Dolphin 2.0 will get a new view-engine with the
following improvements:
- Better performance
- Animated transitions
- No clipped filenames due to dynamic item-sizes
- Grouping support for all view-modes
- Non-rectangular selection areas
- Simplified code for better maintenance

More details will be provided in a blog-entry during
the next days.

Please note that the code is in a very
early alpha-stage and although the most tricky parts
have been implemented already very basic things like
drag and drop or selections have not been pushed yet.
Those things are rather trivial to implement but this
still will take some time.
2011-07-30 20:13:41 +02:00
Burkhard Lück
7ca4e389be Add missing actions to report bug + switch language to Help menu in dolphin whithout menubar
Using Dolphin in default mode in master/4.7 whithout menubar the user has no actions to report a bug or switch language.
Add these missing actions the Help menu launched from the toolbar button Configure and control Dolphin.
REVIEW: 101597
2011-06-13 08:26:07 +02:00
Peter Penz
8f6045bac7 Fix position of toolbar-menu
CCBUG: 274495
2011-06-10 16:27:39 +02:00
Sebastian Dörner
0a7c5997df Fix problems with commit 8d789f2626
- fix crash when Ctrl-D-ing in the terminal
 - don't respond to window manager actions, only when the dock itself is
   hidden

Refers to commit 8d789f2626
2011-06-01 21:53:44 +01:00
Peter Penz
2fcd3dd788 Fix position of Dolphin menu with multiple-screens setup
BUG: 274495
FIXED-IN: 4.7.0
2011-05-30 16:33:35 +02:00
Frank Reininghaus
009535d910 Fix build failure if Nepomuk is not available.
Thanks to Krzysztof Nowicki for the patch!
BUG: 274297
2011-05-28 00:17:17 +02:00
Sebastian Dörner
603ec47b8b Don't let hidden terminals prevent unmounting
Previous state: When the terminal is hidden, the cwd is not updated
anymore. If it was on a removable device when hiding, the hidden
terminal might prevent unmounting this device.
This patch fixes that bug by changing the cwd to "/" when hiding the panel.

REVIEW: 101387
BUG: 158264
FIXED-IN: 4.7.0
2011-05-25 22:19:11 +01:00
Peter Penz
371e718ec5 Fix enabled/disabled issue of Search Panel 2011-04-20 22:11:22 +02:00
Peter Penz
ae488b1318 Improve usability of Search Panel
If the Search Panel is shown outside the context of the "Find" mode it
will be always enabled and does a global search. Only if the user is in
the "Find" mode and the searching is restricted to the current directory
the Search Panel might get disabled if the current directory is not
indexed. This solves the major usability issue that it was not clear
for the users whether a global or restricted search is done.
2011-04-20 20:09:08 +02:00
Peter Penz
d4be11f205 Assure that the startup-settings are applied immediately 2011-04-15 20:53:13 +02:00
Peter Penz
de077f8477 Let each DolphinMainWindow run in a custom process
A possible crash in one Dolphin window should not result in crashing
other Dolphin windows. Beside this it also prevents issues with
modal dialogs or notifications.

BUG: 269950
BUG: 206053
BUG: 196034
FIXED-IN: 4.7.0
2011-04-12 20:08:08 +02:00
Peter Penz
2baa9ec45a Optimize alignment of toolbar menu
Try to align the toolbar menu within the Dolphin window to
reduce the cases where the sub-menus overlap with the right
screen border.
2011-04-08 19:38:37 +02:00
Frederik Schwarzer
33635cd40c Add missing i18n call 2011-04-06 00:36:39 +02:00
Peter Penz
5ff682d852 Readd the "go home" action
It got accidently lost during the menu-button changes. Also the
clearStatusBar() calls have been removed as this is handled in the
DolphinViewContainer internally since a long time already.
2011-03-29 18:37:40 +02:00
Peter Penz
c80b261505 Update the size of the menu toolbar-item
If the icon size of the toolbar has been changed, the manually added
menu toolbar-item must be updated.
2011-03-27 19:07:14 +02:00
Peter Penz
5647aab1e3 Minor optimizations for the menu toolbar-item 2011-03-27 18:46:08 +02:00
Peter Penz
bbef0013a1 Don't use a submenu for the settings
If the toolbar-menu is used just put the settings-related entries
directly to the root instead of collecting them in a sub-menu.
2011-03-27 17:43:02 +02:00
Peter Penz
9af429cae1 Provide toolbar-menu when the menubar is hidden
Use a similar default UI like in Rekonq and other browsers: Hide the
menubar and add access to all actions by a button in the toolbar.
Of course it is still possible to show the menubar so that the same UI
is given like before.
2011-03-26 23:26:39 +01:00
Peter Penz
a90938c414 Show places selector of URL navigator only when required
The places selector of the URL navigator only needs to get shown
if the Places panel is invisible.
2011-03-26 16:38:34 +01:00
Peter Penz
984c20161b Add search modes for the Search Panel
The search panel must get a hint whether clicking on the facets should result in searching everywhere or from the current folder. It is not sufficient to check the search-settings of the "Find:"-box, as when the "Find:"-box is invisible there is no hint for the user what kind of searching is done and the setting must be ignored.
2011-03-10 23:21:42 +01:00
Peter Penz
65b5d7d8e3 Rename the "Filter Panel" to "Search Panel"
Bug reports indicate that users are confused by the term "filter" for this.
2011-03-09 19:19:54 +01:00
Peter Penz
39911cad18 Prevent unnecessary reloading of KDirLister on startup
When Dolphin is started with a directory as argument unnecessary reload operations of KDirListers are done. The patch improves this by just letting the DolphinView internally do a loading as soon as it gets visible (and without reloading). Also in case if only one directory is passed as argument the current tab gets reused instead of creating new tabs and removing the current tab.

Thanks a lot to David Faure for pointing out this unefficient handling.
2011-03-08 22:32:49 +01:00
Sebastian Dörner
2a5b3ec615 Consistently use binary operators to connect QFlags 2011-02-27 23:06:14 +01:00
Peter Penz
4a9561e6b7 Fix regression that creating a sub-folder is not possible
CCBUG: 265714
2011-02-09 21:15:55 +01:00
Peter Penz
d3496b1231 Coding style update for pointer comparison
Most developers seem to prefer
  if (ptr) ...
  if (!ptr) ...
in comparison to
  if (ptr != 0) ...
  if (ptr == 0) ...

Adjusted the Dolphin-code to use the "most-prefered style" to make contributors happy.
2011-02-09 19:24:27 +01:00
Peter Penz
ceba0f6f6a Use capitalized includes of recently committed kdelibs headers 2011-02-09 18:42:04 +01:00
Peter Penz
fd74aa8e20 Update e-mail address from peter.penz@gmx.at to peter.penz19@gmail.com 2011-02-04 15:57:33 +01:00
Peter Penz
8eb9b508ca Use capitalized KDE includes 2011-02-04 15:43:21 +01:00
Peter Penz
7045a25e3a Fix visibility- and enabled-issues for the filter-panel
The filter-panel should be disabled if the current folder is not indexed at all. Also when triggering a "Find" the filter-panel should stay invisible per default when the current folder is not indexed.

CCBUG: 264969
2011-02-02 19:36:08 +01:00
Sebastian Doerner
aef40807d1 Fix crash when detaching a tab with "Split View Mode" setting enabled
svn path=/trunk/KDE/kdebase/apps/; revision=1217560
2011-01-27 21:30:45 +00:00
Peter Penz
75a6e8fb2a Fix regression introduced by SVN commit 1214916: The navigator should get the focus when "Replace Location" is invoked.
CCMAIL: sebastian@sebastian-doerner.de

svn path=/trunk/KDE/kdebase/apps/; revision=1215110
2011-01-17 17:39:36 +00:00
Sebastian Doerner
f5f6c89c3f Simplify DolphinMainWindow::replaceLocation()
svn path=/trunk/KDE/kdebase/apps/; revision=1214916
2011-01-16 21:18:18 +00:00
Peter Penz
eaf7c9ab2b SVN_SILENT: Remove unused method
svn path=/trunk/KDE/kdebase/apps/; revision=1212992
2011-01-08 23:11:34 +00:00
Sebastian Doerner
6866686dd2 Fix sanity check in toggleViews()
svn path=/trunk/KDE/kdebase/apps/; revision=1212950
2011-01-08 19:08:49 +00:00
Peter Penz
d257bcb21c Add the "Lock Panels"/"Unlock Panels"-action to the context-menu of the Places Panel.
svn path=/trunk/KDE/kdebase/apps/; revision=1211709
2011-01-04 17:54:58 +00:00