Commit graph

469 commits

Author SHA1 Message Date
Peter Penz c1f220595b Use QBoxLayout::addStretch() instead of adding a custom "stretch widget"
svn path=/trunk/KDE/kdebase/apps/; revision=1132029
2010-05-29 11:49:25 +00:00
Peter Penz c62cb08d14 Fix the nasty layout reparenting by adding the InformationPanelContent into a layout. Thanks to Sebastian Trüg for the hint!
CCMAIL: trueg@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=1132028
2010-05-29 11:44:28 +00:00
Peter Penz 5e47c22e21 Fix wrong description: The selection is meant for the information panel, not the tooltips.
svn path=/trunk/KDE/kdebase/apps/; revision=1128630
2010-05-19 19:49:47 +00:00
Peter Penz cf5d93c3d2 Use the term "Select" instead of "Configure", as it is less technical (at least I hope as non-native English speaker that this is the case ;-))
svn path=/trunk/KDE/kdebase/apps/; revision=1126705
2010-05-14 17:00:11 +00:00
Peter Penz cb9669d71c If an information entry will be added to KFileItemDelegate (like done recently), adjusting the corresponding code in Dolphin is a real pain, as the new information will be shown in Dolphin the following way:
- As additional columns in the details view
 - As additional lines in the icons view
 - As menu entries in the "Sort By" and "Additional Information" groups
 - As popup menu entries in the details view header popup
 - As checkable entries in the View Properties dialog

To prevent similar painful transitions in future, the class AdditionalInfoManager has been introduced. All parts in Dolphin that access/show/store additional information, use the AdditionalInfoManager now. If a new information entry will be added in KFileItemDelegate in future, only a small adjustment in AdditionalInfoManager will be required.

Still open currently:
- AdditionalInfoDialog does not use AdditionalInfoManager yet
- DolphinView::Sorting should be replaced by KFileItemDelegate::Information, so that the sorting can also be done in a generic way.
- The data for KFileItemDelegate::PathOrUrl is not determined

The open issues will get fixed during the next days.

Kudos to the brave warriors Sebastian and Frank, that tried to add a new information ;-)

CCMAIL: sebastian@trueg.de
CCMAIL: frank78ac@googlemail.com

svn path=/trunk/KDE/kdebase/apps/; revision=1126410
2010-05-13 22:06:10 +00:00
Peter Penz d64bbc333c Reset the location to the home URL, if a place has been removed (e. g. a DVD has been ejected).
Thanks to Christian Mühlhäuser for the patch!

BUG: 231518

svn path=/trunk/KDE/kdebase/apps/; revision=1126336
2010-05-13 18:23:04 +00:00
Frank Reininghaus 7e74c6f23b Provide the destination of a symbolic link as a column in Dolphin's
(and Konqueror's) Details View in KDE SC 4.5.

This is based on the changes to KFileItemDelegate from commit 1124981.

FEATURE: 211690

svn path=/trunk/KDE/kdebase/apps/; revision=1124982
2010-05-10 12:49:41 +00:00
Peter Penz 72d6d85323 The KFileMetaInfoWidget does not use a hardcoded small font anymore, so it must be set manually nowidget
svn path=/trunk/KDE/kdebase/apps/; revision=1115496
2010-04-16 16:00:06 +00:00
Peter Penz 47d3113922 Split the class DolphinController into the two classes DolphinViewController and ViewModeController.
The ViewModeController offers a defined interface to control view mode implementations like icons view, details view and column view. The DolphinViewController allows those view mode implementations to control the parent DolphinView in a limited way.

svn path=/trunk/KDE/kdebase/apps/; revision=1109228
2010-03-30 20:19:32 +00:00
Peter Penz dd743f9d98 Open the meta data configuration dialog modeless
svn path=/trunk/KDE/kdebase/apps/; revision=1107448
2010-03-25 17:36:39 +00:00
Peter Penz a3cc212100 Enable the meta data configuration dialog again after the KFileMetaDataWidget code has been moved to kdelibs
svn path=/trunk/KDE/kdebase/apps/; revision=1107432
2010-03-25 16:34:40 +00:00
Peter Penz caf017c2fe Use KFileMetaDataWidget from kdelibs. Still open: Provide dialog which wraps KFileMetaDataConfigurationWidget.
svn path=/trunk/KDE/kdebase/apps/; revision=1106465
2010-03-22 22:23:02 +00:00
Peter Penz a57925a23d Send CTRL+C to the terminal instead of of backspaces. Thanks to the FiNeX and g111 for the hint.
CCBUG: 161637

svn path=/trunk/KDE/kdebase/apps/; revision=1106403
2010-03-22 18:28:16 +00:00
André Wöbbeking 4ab20ea043 -pedantic
svn path=/trunk/KDE/kdebase/apps/; revision=1104133
2010-03-16 20:15:48 +00:00
Peter Penz f2885d1ac2 Fix issue that the current terminal line does not get cleared before sending a cd command.
The terminal interface does not provide an API for this, so as workaround backspaces are send. Not nice, but as the issue can lead to data loss, this solution is better than having nothing.

BUG: 161637

svn path=/trunk/KDE/kdebase/apps/; revision=1103207
2010-03-14 16:21:35 +00:00
Peter Penz fbc221c4ff Fix compile issue if HAVE_NEPOMUK is not defined
svn path=/trunk/KDE/kdebase/apps/; revision=1102862
2010-03-13 20:34:43 +00:00
Peter Penz 5c80286726 Meta data configuration dialog improvements
* use the data provided by the model instead reading it again
* allow to enable/disable also custom meta data 

svn path=/trunk/KDE/kdebase/apps/; revision=1102852
2010-03-13 20:05:21 +00:00
Peter Penz 7b8a3ae800 Let the custom widgets stay invisible per default after constructing them. This prevent a possible flickering when starting Dolphin.
svn path=/trunk/KDE/kdebase/apps/; revision=1102837
2010-03-13 19:17:38 +00:00
Peter Penz 5f54238912 Allow to provide custom widgets for meta data in a generic way.
By this it is possible that other applications like e. g. Gwenview provide custom widgets to change EXIF data directly within the meta data widget.

svn path=/trunk/KDE/kdebase/apps/; revision=1102834
2010-03-13 19:07:40 +00:00
Peter Penz 6b9c4f7b45 Allow to specify a group for a meta data item.
The sorting of the meta data items is now done by the group. Within the group the sorting is done by their translated labels.

svn path=/trunk/KDE/kdebase/apps/; revision=1102778
2010-03-13 15:32:48 +00:00
Peter Penz 54a1499586 Provide a KMetaDataModel for KMetaDataWidget.
This allows to extend the model with custom meta data (might e. g. be useful for Gwenview).

svn path=/trunk/KDE/kdebase/apps/; revision=1102749
2010-03-13 13:38:40 +00:00
Andrew Coles 2f16883fe7 Proof-reading: file name -> filename, for consistency.
svn path=/trunk/KDE/kdebase/apps/; revision=1101351
2010-03-09 23:16:23 +00:00
Peter Penz 2b286a9f04 Rename NfoTranslator to KNfoTranslator, so that KMetaDataWidget can be moved to kdelibs for KDE SC 4.5 (some interfaces of KMetaDataWidget need to be cleaned up first).
KNfoTranslator is marked as private class, as it is not clear yet whether it should be used by other classes like KFileMetaInfo.

svn path=/trunk/KDE/kdebase/apps/; revision=1098897
2010-03-04 16:24:20 +00:00
Peter Penz a0b010bb00 Only access the data of the thread that has been created most recently. Data of older threads will just get ignored.
svn path=/trunk/KDE/kdebase/apps/; revision=1097289
2010-02-28 21:03:58 +00:00
Peter Penz 072dacbb55 Fix possible memory leak when invoking KLoadMetaDataThread::cancelAndDelete().
svn path=/trunk/KDE/kdebase/apps/; revision=1097154
2010-02-28 15:01:33 +00:00
Peter Penz 77d9413d07 Meta data configuration cleanups:
- Use RDF labels internally.
- Provide better default settings, which meta data are hidden.
- Allow to configure which meta data is shown also if Nepomuk is turned off.

svn path=/trunk/KDE/kdebase/apps/; revision=1096571
2010-02-26 22:03:32 +00:00
Peter Penz 65106c3037 use NFO URI to check whether the width and height should be merged as one label
svn path=/trunk/KDE/kdebase/apps/; revision=1096542
2010-02-26 20:08:09 +00:00
Peter Penz 6479605c84 remove duplicate entries
svn path=/trunk/KDE/kdebase/apps/; revision=1096541
2010-02-26 20:07:26 +00:00
Peter Penz 4e370297de Show meta information also for files, which are not indexed (or in the case if Nepomuk is turned off).
Beside the new translations the fix is based on several other fixes in kdelibs + strigi and cannot be backported to KDE SC 4.4.x.

As soon as the meta data widget has been moved to kdelibs, this meta data information will also be available in the properties dialog.

BUG: 193592

svn path=/trunk/KDE/kdebase/apps/; revision=1096472
2010-02-26 18:03:13 +00:00
Peter Penz 5dee68a061 The number of fixed meta-info items may vary dependent on whether Nepomuk is enabled or not. Avoid the nasty hack to hardcode the value within the slotLoadingFinished() method.
BUG: 228540

svn path=/trunk/KDE/kdebase/apps/; revision=1096347
2010-02-26 14:42:47 +00:00
Peter Penz e488496286 Also show meta informations of files, if Nepomuk is not running or if the file is not indexed.
Still a lot of cleanups are required (e. g. the labels are not human readable currently).

svn path=/trunk/KDE/kdebase/apps/; revision=1096092
2010-02-25 19:34:58 +00:00
Sebastian Trueg 3beca2e7f1 * No need to reload all tags when one is deleted.
* Use Resource::genericLabel() always for consistency.

svn path=/trunk/KDE/kdebase/apps/; revision=1096036
2010-02-25 15:41:27 +00:00
Sebastian Trueg 5e079195bc Another fix for the metadata rows: properly clean up unused rows in case no metadata is added.
svn path=/trunk/KDE/kdebase/apps/; revision=1081502
2010-01-28 14:09:22 +00:00
Sebastian Trueg 950d3ad78b * Do not hide the parent folder since we can now browse into it by simply clicking the link.
* Fixed index bug which caused the last information item to be deleted.
* Why make merge-sort more complicated than it is? ;)

svn path=/trunk/KDE/kdebase/apps/; revision=1080377
2010-01-26 09:25:22 +00:00
Friedrich W. H. Kossebau 5accf42fc8 changed: made static const data symbols really static const
svn path=/trunk/KDE/kdebase/apps/; revision=1080302
2010-01-26 02:57:09 +00:00
Peter Penz d1099ee5bf assure that the widgets of the panels are resized after receiving the Polish event
svn path=/trunk/KDE/kdebase/apps/; revision=1075076
2010-01-15 14:20:09 +00:00
Peter Penz b4f7d12803 fixed issue that the Information Panel might show some (for the user confusing) information about a nepomuk protocol
svn path=/trunk/KDE/kdebase/apps/; revision=1075065
2010-01-15 13:55:13 +00:00
Peter Penz 6fcfb3c96c don't try to access invalid files
BUG: 222364

svn path=/trunk/KDE/kdebase/apps/; revision=1075029
2010-01-15 11:47:09 +00:00
Peter Penz 199f9af8b6 Fixed issue that the Information Panel might show the old filename after renaming an item.
Added implementation note, as a working code had been removed some time ago because of a performance bottleneck.

BUG: 198375

svn path=/trunk/KDE/kdebase/apps/; revision=1071287
2010-01-07 20:14:43 +00:00
Peter Penz ef3b7d8991 When changing the selection, the currently shown file item should be reset. This fixes the issue that changing the selection with the keyboard might not have an effect if an item is hovered with the mouse.
BUG: 210177

svn path=/trunk/KDE/kdebase/apps/; revision=1070745
2010-01-06 17:01:38 +00:00
Peter Penz 4fdc3bad9c Fixed issue that Ctrl+A sometimes did not result in an update of the Information Panel. As a sideeffect some code simplification has been done, which was possible because of the column view refactorization some time ago.
svn path=/trunk/KDE/kdebase/apps/; revision=1070740
2010-01-06 16:56:01 +00:00
Peter Penz c96d6dea10 Don't show the size information, if only one directory is shown. This issue only occured in the context of tooltips, as updateRowsVisibility() is invoked after setItems()...
svn path=/trunk/KDE/kdebase/apps/; revision=1063483
2009-12-18 17:01:40 +00:00
Peter Penz e15a9f3a8d * respect the --select startup option
* minor cleanups related to selecting items in general

svn path=/trunk/KDE/kdebase/apps/; revision=1063329
2009-12-17 21:07:18 +00:00
Peter Penz df0b75e8c8 use the same link style as used for tags
svn path=/trunk/KDE/kdebase/apps/; revision=1061705
2009-12-12 18:53:05 +00:00
Peter Penz 50e9debc1b align the rating widget of the Information Panel left (or right for r2l) instead of horizontally centered
svn path=/trunk/KDE/kdebase/apps/; revision=1061598
2009-12-12 13:05:37 +00:00
Sebastian Trueg d326572a72 Do not show links for unsupported protocols, ie. pre-4.4 resources which used URNs instead of nepomuk:/res/<uuid> URIs.
svn path=/trunk/KDE/kdebase/apps/; revision=1060341
2009-12-08 15:51:51 +00:00
Peter Penz 1b05d108a1 don't crash if the Information Panel is updated by file changes
BUG: 214060

svn path=/trunk/KDE/kdebase/apps/; revision=1060022
2009-12-07 22:15:54 +00:00
Peter Penz 207cb06316 Activated "clicking on tags" fix from Sebastian Trüg. By providing a different link color the difference to the "Change tags..." link is visible.
svn path=/trunk/KDE/kdebase/apps/; revision=1059985
2009-12-07 20:45:20 +00:00
Sebastian Trueg 25b9640456 Added all code necessary for clickable tags in the KTaggingWidget. As soon as we figured out how to
only show links on hover we are good to go.
This is actually a fix as resources in the rest of the info view are already clickable.

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=1059908
2009-12-07 16:41:37 +00:00
Sebastian Trueg f4067a705a Added versioning information to the list of hidden properties. This fixes hiding in case an old kmetainformationrc exists.
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=1059900
2009-12-07 16:31:05 +00:00
Laurent Montel 456fa7054b Fix mem leak
svn path=/trunk/KDE/kdebase/apps/; revision=1057381
2009-12-02 08:14:31 +00:00
Sebastian Trueg bd47f7f978 Use KFileItem::text() instead of KUrl::fileName() to display the entry's name in the metadata panel. This way Nepomuk results and all entries from KIO slaves that make use of UDS_DISPLAY_NAME look nice.
svn path=/trunk/KDE/kdebase/apps/; revision=1056260
2009-11-29 18:16:36 +00:00
Sebastian Trueg d324e790d6 * Fixed execution of links in the metadata widget.
* Do not try to list non-listable URLs.

svn path=/trunk/KDE/kdebase/apps/; revision=1054300
2009-11-25 20:53:37 +00:00
Peter Penz 2a02ac7d02 Let KMetaDataWidget and all the child widgets respect the foreground role that might be set by the client. This allows KMetaDataWidget to get embedded inside a tooltip having correct tooltip colors.
svn path=/trunk/KDE/kdebase/apps/; revision=1052509
2009-11-21 22:50:22 +00:00
Sebastian Trueg ccd9a32988 Simplified the clickable resource metadata display. This also fixes a bug where sometimes resources are not displayed at all
svn path=/trunk/KDE/kdebase/apps/; revision=1052237
2009-11-21 09:33:37 +00:00
Peter Penz 2b6cceb0f6 Provide clickable resources for the Information Panel. Thanks to Sebastian Trüg für the patch!
CCMAIL: trueg@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=1051553
2009-11-19 19:38:34 +00:00
Peter Penz d4a983d98c don't crash if Nepomuk gets activated/deactivated during Dolphin is running
svn path=/trunk/KDE/kdebase/apps/; revision=1050611
2009-11-17 18:32:53 +00:00
Nicolas Lécureuil fb1380b183 Fix crash
svn path=/trunk/KDE/kdebase/apps/; revision=1050466
2009-11-17 11:09:28 +00:00
David Faure 5328ae8942 Stop crashing (apparently I have HAVE_NEPOMUK but the runtime check fails so the widget isn't created)
svn path=/trunk/KDE/kdebase/apps/; revision=1048851
2009-11-14 01:49:16 +00:00
Peter Penz 3eb05a06bb fixed issue that the rating was not applied to the Information Panel
svn path=/trunk/KDE/kdebase/apps/; revision=1048811
2009-11-13 23:25:38 +00:00
Peter Penz bd30bb6ca9 search finetuning:
* trigger progress information when starting a search
* let the information panel hide the meta data for the search string
* get the search string from the configurator

svn path=/trunk/KDE/kdebase/apps/; revision=1048721
2009-11-13 21:03:19 +00:00
Peter Penz 1c62d0accf SVN_SILENT: constify
svn path=/trunk/KDE/kdebase/apps/; revision=1048143
2009-11-12 20:05:30 +00:00
Peter Penz f0cab33518 Don't show the search options, if no Nepomuk is available. Hopefully Nepomuk will get a hard build dependency quite soon, those #ifdef-code is really ugly and difficult to maintain...
svn path=/trunk/KDE/kdebase/apps/; revision=1048135
2009-11-12 19:45:55 +00:00
Peter Penz d3f37b1af4 SVN_SILENT: removed unnecessary include
svn path=/trunk/KDE/kdebase/apps/; revision=1048117
2009-11-12 19:16:09 +00:00
Peter Penz 56bccf8f2f let the user also delete the created tags
svn path=/trunk/KDE/kdebase/apps/; revision=1047714
2009-11-11 21:47:09 +00:00
Peter Penz 98f0289c76 Images: Instead of showing the meta data for "Width:" and "Height:" separately with other items in between, they are merged as "Width x Height:" and added to the top of the sort order.
CCBUG: 193592

svn path=/trunk/KDE/kdebase/apps/; revision=1047680
2009-11-11 19:47:07 +00:00
Peter Penz 36ae0b6185 * don't show the "Add Tags..." and "Add Comments..." links for the meta data inside a tooltip
* minor cleanup of thread-interface to allow a proper sorting/merging on client side

svn path=/trunk/KDE/kdebase/apps/; revision=1047662
2009-11-11 18:59:29 +00:00
Andrew Coles b90e618a82 Two minor proof-reading changes:
- missing space in one message in string split across two lines
 - Servicemenu -> Service Menu.


svn path=/trunk/KDE/kdebase/apps/; revision=1046089
2009-11-07 13:24:03 +00:00
Peter Penz 18a2989794 move the position of the filename below the preview
svn path=/trunk/KDE/kdebase/apps/; revision=1045798
2009-11-06 20:06:00 +00:00
Peter Penz a9f8714fc1 fixed calculation of the height size hint: don't forget the spacing and margin of the layout
svn path=/trunk/KDE/kdebase/apps/; revision=1045768
2009-11-06 18:39:01 +00:00
Peter Penz 49a1a72d50 allow to set a custom description for the KMetaDataConfigurationDialog
svn path=/trunk/KDE/kdebase/apps/; revision=1045712
2009-11-06 17:06:33 +00:00
Sebastian Trueg d07b3d9ddb Handle lists of resources nicer. Maybe a list separated by new-lines is not the best though...
svn path=/trunk/KDE/kdebase/apps/; revision=1045283
2009-11-05 17:12:38 +00:00
Sebastian Trueg 8955d51666 fancy date formatting
svn path=/trunk/KDE/kdebase/apps/; revision=1045013
2009-11-05 08:56:42 +00:00
Sebastian Trueg e3d68e709f Nicer formatting of the values - only a temp solution just like tuneLabel. To many temp solutions...
svn path=/trunk/KDE/kdebase/apps/; revision=1044996
2009-11-05 08:04:54 +00:00
Peter Penz 565bd3bf23 Don't call QThread::wait() in the destructor - in the worst case an issue in Nepomuk will block Dolphin for several seconds. Refactored the load-meta-data-thread in a way that the meta data widget does not require to wait for a result of the thread.
svn path=/trunk/KDE/kdebase/apps/; revision=1044848
2009-11-04 19:14:39 +00:00
Peter Penz f5f2ccf8ee Fixed link issue - I'm sorry: I had installed a temporary version of KMetaDataWidget from kdelibs and did not recognize the issue...
svn path=/trunk/KDE/kdebase/apps/; revision=1044545
2009-11-04 00:46:45 +00:00
Patrick Spendrin af50b02f78 some more export fixes
svn path=/trunk/KDE/kdebase/apps/; revision=1043907
2009-11-02 16:54:10 +00:00
Patrick Spendrin 7f76ab761d do not export this widget with a wrong export define
svn path=/trunk/KDE/kdebase/apps/; revision=1043889
2009-11-02 16:05:52 +00:00
Peter Penz 73007f7d63 After some discussions at http://reviewboard.kde.org/r/1938 it turned out that moving KMetaDataWidget and KMetaDataConfigurationDialog to kdelibs should be postponed to KDE 4.5. The main reason is that adding application specific properties is not possible with the current API in a generic way. Also the topic how to hide properties application specific is an open point...
So now all adjustments from the review have been adapted to the Dolphin code. After KDE 4.4 has been released some refactoring will be done so that the open topics above are handled in a nice way.

svn path=/trunk/KDE/kdebase/apps/; revision=1041547
2009-10-28 07:18:00 +00:00
Peter Penz ba9a4972a0 assure that the "size" information can be hidden by the user
svn path=/trunk/KDE/kdebase/apps/; revision=1038142
2009-10-20 17:36:28 +00:00
Raphael Kubo da Costa 5e6f3b87ed Fix some spelling mistakes in comments.
svn path=/trunk/KDE/kdebase/apps/; revision=1037779
2009-10-19 23:32:21 +00:00
Peter Penz dd6febd314 use correct name for the tags-entry, otherwise disabling of tags won't work...
svn path=/trunk/KDE/kdebase/apps/; revision=1037727
2009-10-19 20:53:24 +00:00
Peter Penz d6db9ac22c the configuration menu should be shown also for multiple selections
svn path=/trunk/KDE/kdebase/apps/; revision=1037684
2009-10-19 19:52:25 +00:00
Sebastian Trueg 002787543f xesam is deprecated
svn path=/trunk/KDE/kdebase/apps/; revision=1036703
2009-10-17 16:47:48 +00:00
Sebastian Trueg e1dde0669f Use the magic QFlags I love so much.
svn path=/trunk/KDE/kdebase/apps/; revision=1036578
2009-10-17 13:16:45 +00:00
Peter Penz 59c430bb3f Use the tunedLabel() workaround also for the configuration dialog. Hopefully this can be cleaned up until KDE 4.4...
CCMAIL: trueg@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=1036559
2009-10-17 12:43:58 +00:00
Peter Penz 998b88f304 * get rid of MetaDataWidget::openConfigurationDialog()
* allow to hide specific data for applications
* check whether Nepomuk has been activated (the check with #idfef HAVE_NEPOMUK is not sufficient in the case if Nepomok is available but not activated)

svn path=/trunk/KDE/kdebase/apps/; revision=1036556
2009-10-17 12:23:38 +00:00
Peter Penz 71b292e95b provide an URI for the tag
svn path=/trunk/KDE/kdebase/apps/; revision=1036306
2009-10-16 23:28:13 +00:00
Peter Penz e512e98b41 * allow editing of tags
* minor adjustments for the default settings of visible meta data

svn path=/trunk/KDE/kdebase/apps/; revision=1036296
2009-10-16 22:53:27 +00:00
Peter Penz ee08881486 remove unnecessary 'const'
svn path=/trunk/KDE/kdebase/apps/; revision=1036229
2009-10-16 20:54:50 +00:00
Peter Penz 0bd6e46b2b prepare the behavior-settings dialog to configure the shown meta data for tooltips
svn path=/trunk/KDE/kdebase/apps/; revision=1036100
2009-10-16 15:50:30 +00:00
Peter Penz a6355d1ca4 prepare MetaDataConfigurationDialog to be a public class in the Nepomuk libs
svn path=/trunk/KDE/kdebase/apps/; revision=1036074
2009-10-16 14:17:49 +00:00
Peter Penz 7d4242d2c7 Fixed compilation issue if HAVE_NEPOMUK is not set. This #ifdef HAVE_NEPOMUK stuff is really a pain :-(
svn path=/trunk/KDE/kdebase/apps/; revision=1036067
2009-10-16 13:45:47 +00:00
Peter Penz 3852f31c30 * improved interface + documentation of MetaDataWidget
* provide a configuration dialog for adjusting the visibility of the meta data

svn path=/trunk/KDE/kdebase/apps/; revision=1036058
2009-10-16 13:01:11 +00:00
Peter Penz 660c1fd767 restore functionality that ratings, comments and tags get stored after the user changed the values
svn path=/trunk/KDE/kdebase/apps/; revision=1034884
2009-10-13 20:48:38 +00:00
Peter Penz ba444ba8d0 adjust margins + spacing
svn path=/trunk/KDE/kdebase/apps/; revision=1033755
2009-10-10 23:15:13 +00:00
Peter Penz 984378d7f7 layout improvements
svn path=/trunk/KDE/kdebase/apps/; revision=1033744
2009-10-10 22:29:05 +00:00
Peter Penz b786c28e04 Reactivate showing of general meta information. This is also done as part of the LoadFilesThread and is no special case anymore like in the old code base.
svn path=/trunk/KDE/kdebase/apps/; revision=1033722
2009-10-10 21:28:37 +00:00
Peter Penz a56d2e78ce Reactivate reading of the meta data for the rating, comments and tags. All expensive operations are done in a separate thread to assure that the Dolphin UI never gets blocked.
svn path=/trunk/KDE/kdebase/apps/; revision=1033696
2009-10-10 20:12:58 +00:00
Peter Penz eaeee9f7d6 Start of refactoring so that the metadata widget can be moved outside of Dolphin for other applications. The temporary removed code will be integrated again within the next 10 days (-> currently no meta data is shown and cannot be updated).
svn path=/trunk/KDE/kdebase/apps/; revision=1033585
2009-10-10 14:13:50 +00:00
Sebastian Trueg 647e1469b5 Use the new fancy UDS_NEPOMUK_URI entry
svn path=/trunk/KDE/kdebase/apps/; revision=1031670
2009-10-05 18:16:13 +00:00
David Faure 6a20b9c962 Make "most local url" determination asynchronous so that it doesn't block the GUI for a long time
(e.g. when accessing the non-existing sftp://192.168.1.100/home)
and only run this job if the terminal panel is shown (or at the time when it is made visible).
Sorry kdebase users, you get to update kdelibs again.
BUG: 202176

svn path=/trunk/KDE/kdebase/apps/; revision=1030480
2009-10-02 10:55:59 +00:00
Tom Albers 48825e6b5b Cross port from local Mailody copy:
SVN commit 1026747 by vkrause:
 
    Fix deadlock when changing the rating and the comment of the same
    object, in that order. The harmless looking setEnabled() call two lines
    down from here triggers a convoluted chain of (q)events that eventually
    ends up calling a method that tries to lock the mutex itself.

Thanks Volker!
CCMAIL:vkrausse@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=1026888
2009-09-22 19:18:04 +00:00
Laurent Montel 4d13af697e warning--
svn path=/trunk/KDE/kdebase/apps/; revision=1026432
2009-09-21 19:55:55 +00:00
Peter Penz d84909dc36 * Use the term "version control" instead of "revision control" to be consistent with the naming in kdevplatform.
* Renamed VersionControlPlugin to KVersionControlPlugin so that the interface can be moved out of Dolphin.

svn path=/trunk/KDE/kdebase/apps/; revision=1011058
2009-08-13 20:48:58 +00:00
Peter Penz 54093338c4 Fix possible crash when opening Dolphin with an enabled Terminal. Thanks to Dario Andres for the analyses!
BUG: 202953

svn path=/trunk/KDE/kdebase/apps/; revision=1011008
2009-08-13 19:12:49 +00:00
Laurent Montel 0dd0f27f83 Fix forward declaration
svn path=/trunk/KDE/kdebase/apps/; revision=1004949
2009-07-31 07:14:20 +00:00
Peter Penz fddd17030c replace list.count() > 0 by !list.isEmpty()
svn path=/trunk/KDE/kdebase/apps/; revision=1001386
2009-07-23 06:14:57 +00:00
Darío Andrés Rodríguez 17b8ac7458 Call MediaObject::play() on Audio files mode.
BUG: 196243


svn path=/trunk/KDE/kdebase/apps/; revision=998153
2009-07-17 01:49:08 +00:00
Peter Penz fa4680cb38 Enable Dolphin to show the revision states of files that are under revision control systems like SVN, Git, CVS, ... The current code is an early draft and it is planned that all plugins (SVN, Git, CVS, ...) are maintained outside Dolphin. If the API is stable enough, a discussion will be done at kfm-devel@kde.org regarding the location of the plugins (the current implementation of SubversionPlugin is only temporary located in Dolphin for testing purposes).
RevisionControlObserver is implemented in a way that no recognizable slowdown is given for directories that are not under revision control.

CCBUG: 192158

svn path=/trunk/KDE/kdebase/apps/; revision=995351
2009-07-12 14:00:45 +00:00
Peter Penz 7c539fd12f Fixed regression when refactoring the Information Panel: Don't forget to give a visual indication if the generation of the preview takes long.
svn path=/trunk/KDE/kdebase/apps/; revision=993584
2009-07-08 22:31:45 +00:00
Peter Penz dc29afa688 The complexity of the class InformationPanel has grown a lot from KDE 4.0 to KDE 4.3. One main reason is that a lot of things are done now asynchronously with timers to prevent a blocking UI and unnecessary expensive operations.
To keep the Information Panel maintainable and prepared for future features a cleanup has been done. The whole user interface handling has been moved into the class InformationPanelContent that offers a straight forward interface: showItem(const KFileItem& item) and showItems(const KFileItemList& items).

The class InformationPanel is responsible for calling those methods in a way that hovering items, changing directories, doing selections, rename and delete operations, ... don't result in calling showItem() 10 times per second.

This cleanup won't be backported to KDE 4.3.x

svn path=/trunk/KDE/kdebase/apps/; revision=991902
2009-07-05 22:54:37 +00:00
Peter Penz b4aacaf4d2 Improve performance of Dolphin:
- When changing a directory the receiving of the meta data is done now with a short delay. This gives the directory lister the chance to show the directory as fast as possible.
- Prevent that DolphinInformationPanel::reset() is invoked when changing a directory. The method only needs to get invoked if an item has been deleted or renamed.
- Cache an unknown file item. This improves the startup time of Dolphin (-> KFileItem constructor is invoked only once instead of up to 6 times).

svn path=/trunk/KDE/kdebase/apps/; revision=991840
2009-07-05 19:10:20 +00:00
Peter Penz 0dd138d147 Use the name of the property instead of the label, otherwise the stored keys would get invalid as soon as we get translated labels.
svn path=/trunk/KDE/kdebase/apps/; revision=984677
2009-06-21 11:33:53 +00:00
Peter Penz 2f233f27da fixed issue the label texts with spaces might overlap with other labels
svn path=/trunk/KDE/kdebase/apps/; revision=984673
2009-06-21 11:23:25 +00:00
Peter Penz 1c351eac8f disable Nepomuk legacy code to eliminate deprecated-warnings
svn path=/trunk/KDE/kdebase/apps/; revision=984621
2009-06-21 09:40:05 +00:00
Peter Penz 6e3e08e33c Simplify how Nepomuk comments can be edited by the user:
- don't provide any mode for editing, just let the user directly manipulate the comment inside the text widget
- automatically save changes, no explicit confirmation required

svn path=/trunk/KDE/kdebase/apps/; revision=984592
2009-06-21 08:16:03 +00:00
Peter Penz 356c81cbf8 Disable additional properties per default as discussed with Sebastian Trüg.
svn path=/trunk/KDE/kdebase/apps/; revision=984493
2009-06-20 20:48:27 +00:00
Peter Penz 514566db88 use a style dependend border instead of a black box
svn path=/trunk/KDE/kdebase/apps/; revision=984301
2009-06-20 14:58:34 +00:00
Peter Penz 0a1048a445 We won't get translated labels for Nepomuk literals in KDE 4.3.0... At least assure that camelcase labels like "fileLocation:" are replaced by "File location:" (thanks to Sebastian Trüg for the code)
svn path=/trunk/KDE/kdebase/apps/; revision=984190
2009-06-20 11:45:34 +00:00
Peter Penz f8c3c95a40 Fix bottleneck when renaming several hundrets of items (the expensive update of m_selection is not required).
svn path=/trunk/KDE/kdebase/apps/; revision=984020
2009-06-19 19:13:08 +00:00
Peter Penz 26b6d3b8ff fixed resizing issues when having long comments:
* embed the comment label inside a scrollarea
* assure that the "add comment..."/"change comment..." link is always visible
* assure that the maximum width of the meta data widget is set to the panel width (otherwise the panel would be increased in an unlimited way when having a text without spaces)

CCMAIL: trueg@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=979621
2009-06-10 10:04:33 +00:00
Albert Astals Cid 83e89e112e add missing ? to the question
svn path=/trunk/KDE/kdebase/apps/; revision=977582
2009-06-04 18:19:28 +00:00
Peter Penz 173bad0b0c fixed xmllint --validate issues reported by krazy
svn path=/trunk/KDE/kdebase/apps/; revision=973297
2009-05-26 19:11:00 +00:00
Peter Penz 3775e23908 fixed krazy string warning
svn path=/trunk/KDE/kdebase/apps/; revision=973291
2009-05-26 18:54:15 +00:00
Peter Penz c1ea2c3491 krazy qtclasses fixes
svn path=/trunk/KDE/kdebase/apps/; revision=973289
2009-05-26 18:52:14 +00:00
Peter Penz c848b945d4 fixed krazy issues (see http://www.kdedevelopers.org/node/3919)
svn path=/trunk/KDE/kdebase/apps/; revision=973269
2009-05-26 18:24:23 +00:00
Peter Penz 232dcda76c SVN_SILENT: fixed typo in comment
svn path=/trunk/KDE/kdebase/apps/; revision=969877
2009-05-19 07:29:18 +00:00
Peter Penz ec859058c6 krazy fixes
svn path=/trunk/KDE/kdebase/apps/; revision=969874
2009-05-19 07:25:40 +00:00
Frank Reininghaus 07ad9b3726 Update the directory of the Terminal Panel if the current URL is not a
"file:" URL, but is nevertheless local (e.g., "desktop:").

This fix is also applied to the new "Open external Terminal" action
which will be in KDE 4.3.

BUG: 167810 

svn path=/trunk/KDE/kdebase/apps/; revision=969265
2009-05-17 19:57:07 +00:00
Peter Penz c2e6c55c88 Don't crash if the the metadata widget is 0 (this can happen if Nepomuk has not been started).
svn path=/trunk/KDE/kdebase/apps/; revision=964469
2009-05-06 18:16:58 +00:00
Peter Penz 7431f4566c initialize m_canceled property in the constructor
svn path=/trunk/KDE/kdebase/apps/; revision=961194
2009-04-29 16:13:29 +00:00
Sebastian Trueg ba93d931e8 properly initialize m_canceled.
svn path=/trunk/KDE/kdebase/apps/; revision=960323
2009-04-28 10:41:50 +00:00
Sebastian Trueg 3e6bcdde69 Gracefully end the metadata loading thread. This should fix
BUG: 190165

svn path=/trunk/KDE/kdebase/apps/; revision=960318
2009-04-28 10:10:20 +00:00
Sebastian Trueg f8e5a0064c Fixed context menu to delete tags.
BUG: 165188

svn path=/trunk/KDE/kdebase/apps/; revision=960282
2009-04-28 08:17:59 +00:00
Stephan Binner 74f07c7860 i18n style guide fixes: http://techbase.kde.org/Projects/Usability/HIG/Capitalization
svn path=/trunk/KDE/kdebase/apps/; revision=959655
2009-04-26 19:40:38 +00:00
Peter Penz ed0df8dc1f fixed issue that the video preview size was wrong during resizing the information panel
svn path=/trunk/KDE/kdebase/apps/; revision=958762
2009-04-24 15:34:42 +00:00
Peter Penz 9854069549 - Postpone the video player initialization until the play button has been pressed.
- Assure that the video player has the same size as the preview widget. Convincing the embedded video player to dynamically resize during playing a video seems to be impossible - I need to check the Phonon::VideoPlayer source code to get the root cause for the currently strange behavior :-(

svn path=/trunk/KDE/kdebase/apps/; revision=958332
2009-04-23 19:46:08 +00:00
Pino Toscano f6e3d85133 make it compile w/o nepomuk
svn path=/trunk/KDE/kdebase/apps/; revision=955566
2009-04-17 23:23:00 +00:00
Peter Penz b6e31438cb Workaround: Phonon::BackendCapabilities::isMimeTypeAvailable(...) returns true for PNG images, but it makes no sense showing a play/stop button in this case.
svn path=/trunk/KDE/kdebase/apps/; revision=954485
2009-04-15 20:10:03 +00:00
Peter Penz b2c1a2a03c Initialize the name-label widget with a maximum size. This is important, otherwise at least one resize event would be needed to apply a maximum width. This gets a problem if the dock is overlapped by another dock: No resize event is emitted and the preferred size increases in an unlimited way. Result: when hovering files with very long filenames, the overall dock width will increase in an unexpected way.
BUG: 189596

svn path=/trunk/KDE/kdebase/apps/; revision=954371
2009-04-15 18:01:37 +00:00
Peter Penz 897f481e96 - hide the video player in any case when the stop-button has been pressed
- provide a custom member for the audio media object

svn path=/trunk/KDE/kdebase/apps/; revision=952886
2009-04-12 19:17:56 +00:00
Peter Penz e9b697bdf6 The feature freeze is near: Add video support to the Information Panel. Phonon is quite cool BTW :-)
svn path=/trunk/KDE/kdebase/apps/; revision=952882
2009-04-12 19:00:59 +00:00
Peter Penz cc124237db Allow to enable/disable which information should be shown in the Information Panel.
BUG: 156205

svn path=/trunk/KDE/kdebase/apps/; revision=952833
2009-04-12 16:41:14 +00:00
David Faure 402a17bf1f KonqFileItemCapabilities -> KFileItemListProperties
svn path=/trunk/KDE/kdebase/apps/; revision=948007
2009-04-01 23:34:33 +00:00
Rahman Duran 53a9373a38 BUG: 164489
Make Dolphin benefit from new TerminalInterfaceV2 functions.


svn path=/trunk/KDE/kdebase/apps/; revision=946382
2009-03-29 11:54:40 +00:00
Peter Penz b2bda0d410 disable rating, comments and tags if no meta data is available
svn path=/trunk/KDE/kdebase/apps/; revision=945040
2009-03-26 18:53:00 +00:00
Christian Ehrlicher af49caa18e a lot of more KUrl::path() -> KUrl::toLocalFile() changes (mostly after a check for KUrl::isLocalFile())
svn path=/trunk/KDE/kdebase/apps/; revision=939835
2009-03-15 20:20:33 +00:00
Peter Penz 6c81158a2f allow to disable the preview of the Information Panel
svn path=/trunk/KDE/kdebase/apps/; revision=937927
2009-03-10 19:59:22 +00:00
Peter Penz 045fca17ef insert the meta text information alphabetically sorted
svn path=/trunk/KDE/kdebase/apps/; revision=937920
2009-03-10 19:36:55 +00:00
Peter Penz 27a4b76871 allow to hide the rating, comments and tags of the Information Panel
svn path=/trunk/KDE/kdebase/apps/; revision=937915
2009-03-10 19:21:21 +00:00
Peter Penz 7361b724e4 provide a context menu for the Information Panel, which allows to show/hide meta information
svn path=/trunk/KDE/kdebase/apps/; revision=937910
2009-03-10 19:04:45 +00:00
Peter Penz 69cb2c5db6 Fixed issue that when renaming an item that still the old item name will be shown in the Information Panel.
CCBUG: 181534
CCBUG: 186071

svn path=/trunk/KDE/kdebase/apps/; revision=937630
2009-03-10 07:44:56 +00:00
Peter Penz aed1525abc added dialog to configure which meta data should be shown in the Information Panel
svn path=/trunk/KDE/kdebase/apps/; revision=934828
2009-03-03 21:17:35 +00:00
Peter Penz 87eb2a2ff3 don't show the phonon widget, if more than one file is selected
svn path=/trunk/KDE/kdebase/apps/; revision=934812
2009-03-03 20:38:07 +00:00
Peter Penz d98f9c673b reset the information panel if an item is shown that got deleted
BUG: 186071

svn path=/trunk/KDE/kdebase/apps/; revision=934807
2009-03-03 20:20:44 +00:00
Peter Penz 93b955c3e6 assure that the size hint calculation and the painting code are consistent
svn path=/trunk/KDE/kdebase/apps/; revision=927623
2009-02-17 22:24:14 +00:00
Peter Penz 684ab89c7d SVN_SILENT: forgot to remove this include after doing some tests
svn path=/trunk/KDE/kdebase/apps/; revision=927585
2009-02-17 21:27:17 +00:00
Peter Penz b1c9b5126d * Use Nepomuk for getting the meta data instead of KFileMetaInfo.
* Use a QScrollArea widget to embedd the meta data, as Nepomuk provides so much meta information that it might not fit into the panel.

Open issues:
* Add the possibility to configure which kind of meta information should be shown.
* Check whether the receiving of the meta data for one file also might block the UI like when using KFileMetaInfo in combination with strigi.

CCMAIL: sebastian@trueg.de
BUG: 180742
BUG: 181592

svn path=/trunk/KDE/kdebase/apps/; revision=927542
2009-02-17 20:37:34 +00:00
Peter Penz fda792a1f5 removed m_minimumSizeHint member, it is redundant
svn path=/trunk/KDE/kdebase/apps/; revision=927537
2009-02-17 20:22:04 +00:00
Shaun Reich b9f1ebca00 SVN_SILENT Added newline at EOF.
svn path=/trunk/KDE/kdebase/apps/; revision=922440
2009-02-07 02:01:18 +00:00
Peter Penz 8e13b80d5f Replace patch for bug 181226 by a different approach, as the previous patch resulted in a changed behavior when using the double-click mode (-> a treeview item had to be pressed twice to show it in the main view).
CCBUG: 172360
CCBUG: 181226

svn path=/trunk/KDE/kdebase/apps/; revision=919648
2009-02-01 14:08:40 +00:00
Peter Penz e5edeb7446 Postpone the creating of the media object until the play- or stop-button has been pressed. This solves the issue that Dolphin might get blocked during hovering media files. Dolphin still gets blocked when requesting a media object the first time, but for the user this "just" means that after pressing the play-button the first time, that the playing starts a little bit later.
CCMAIL: kretz@kde.org
CCMAIL: kdedevel@etotheipiplusone.com

svn path=/trunk/KDE/kdebase/apps/; revision=919063
2009-01-31 13:04:40 +00:00
Peter Penz 68a7ed8bcf Don't delete and recreate the phonon widget each time the URL changes, use the existing widget instance if possible.
svn path=/trunk/KDE/kdebase/apps/; revision=919058
2009-01-31 12:42:01 +00:00
Simon Paul St James 9d3ed99ab0 Initial import of Matthias's draft patch for adding video and audio previewing (similar to the file dialog) to Dolphin's metadata panel. Since Phonon is currently in-process only with the memory/ stability issues that come with this, this might have to be disabled by default - we'll see how it goes. Thanks, Matthias!
CCMAIL:kretz@kde.org
CCMAIL:peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=917389
2009-01-27 19:50:21 +00:00
Sebastian Trueg 02781d747d Only actually change the resource if tags were changed.
svn path=/trunk/KDE/kdebase/apps/; revision=914234
2009-01-20 17:41:56 +00:00
Peter Penz 185f35da3a Pressing "Enter" in the folders panel should open the folder in the main view. Thanks to Darío Andrés for the patch!
BUG: 172360

svn path=/trunk/KDE/kdebase/apps/; revision=911855
2009-01-16 10:28:25 +00:00
Peter Penz f37ecd6ecf Cleanup panel related class names: The terms "sidebar"/"sidebarpage" are relicts from the KDE 3 version of Dolphin and are called "Panels" in the KDE 4 version of Dolphin. Yes, renaming classes may take more than 1 year ;-)
svn path=/trunk/KDE/kdebase/apps/; revision=911089
2009-01-14 20:14:36 +00:00
Peter Penz 307285e963 Group classes into folders, Dolphin is too big in the meantime for having a flat directory hierarchy. dolphin/src/CMakeLists.txt will be cleaned up later.
svn path=/trunk/KDE/kdebase/apps/; revision=911065
2009-01-14 19:26:23 +00:00