Commit graph

12912 commits

Author SHA1 Message Date
Script Kiddy 62e5bc3fb7 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=778131
2008-02-22 16:21:46 +00:00
Peter Penz 44149c049e KDE 4.1 requires Qt4.4 -> remove the #ifdefs...
svn path=/trunk/KDE/kdebase/apps/; revision=778095
2008-02-22 13:56:16 +00:00
Peter Penz 082425a026 SVN_SILENT: updated comment with the Qt-bugtracker ID
svn path=/trunk/KDE/kdebase/apps/; revision=778039
2008-02-22 10:08:11 +00:00
Peter Penz 609a11cab7 Fixed wrong comments. Discussed with David Faure: installing an event filter works for the icons-view and details-view, but not for the column-view which uses QListView child widgets internally... We decided to leave it as it is.
svn path=/trunk/KDE/kdebase/apps/; revision=777838
2008-02-21 18:45:22 +00:00
Peter Penz 92bd149807 stay consistent with the QListView behavior: changed the current index also changes the selection
svn path=/trunk/KDE/kdebase/apps/; revision=777817
2008-02-21 17:34:14 +00:00
Peter Penz b147a1d77c * Install an event-filter for the view implementations. Whenever a view implementation gets the focus, it should request it's activation.
* Let the metadata widget only get the focus by clicking.

* Tried to install a similar filter for the wheel-event code duplication in the view-implementations, but the event filter is invoked _after_ the view implementation gets the wheel event... -> added a note the the 3 implementations as hint.

svn path=/trunk/KDE/kdebase/apps/; revision=777757
2008-02-21 14:01:40 +00:00
Peter Penz 9f8520e9c3 don't let the selection toggle steal the keyboard focus of the view
svn path=/trunk/KDE/kdebase/apps/; revision=777738
2008-02-21 12:53:56 +00:00
Peter Penz e39af90e0a Let the DolphinController be aware on which QAbstractItemView instance he is working. This allows to connect signals from the view implementations (icons view, details view, column view) directly to the slots of the DolphinController without a helper slot.
svn path=/trunk/KDE/kdebase/apps/; revision=777737
2008-02-21 12:49:11 +00:00
Peter Penz 19b22eacba Prevent code duplication by moving the duplications into the DolphinController.
Maybe it might be a good idea to let the DolphinController be aware also about his QAbstractItemView -> it might be possible to directly connect signals of the dolphin view implementations with the controller. I'll check this...

(I did not backport this cleanup as I think it has too many changes to be handled as bugfix)

CCMAIL: faure@kde.org 
CCMAIL: edulix@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=777719
2008-02-21 11:56:31 +00:00
Eduardo Robles Elvira f0a14f7fa7 Bugfix: Currently, if you open dolphin, select a bunch of files, and right click and
select Open With > whatever, all the files are opened. Which is the right 
thing. However, if you hit enter to open those selected files, no file is 
opened. Currently, the file is only opened if there's only *one* file 
selected. The attached patch fixes this problem.


svn path=/trunk/KDE/kdebase/apps/; revision=777695
2008-02-21 09:55:08 +00:00
Script Kiddy dced0cc971 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=777485
2008-02-20 18:43:33 +00:00
George Goldberg 9cfec4d7f3 ebn copyright checks: reformatting fixes
svn path=/trunk/KDE/kdebase/apps/; revision=777267
2008-02-20 09:32:22 +00:00
Laurent Montel ef2e2131ce Add title to submenu
(see bug with subversion action menu)

svn path=/trunk/KDE/kdebase/apps/; revision=777249
2008-02-20 07:30:24 +00:00
Urs Wolfer b3771e04d1 Apply patch John Varouhakis. Patch looks clean an makes sense, even when I am not able to reproduce the bug.
BUG:158024

svn path=/trunk/KDE/kdebase/apps/; revision=777174
2008-02-19 21:57:03 +00:00
David Faure 7c7104df77 Performance: finally optimized "konqueror <url>" so that it doesn't load the about page first.
if (serviceName == "konq_aboutpage" && forcedUrl.protocol() != "about") {
    // No point in loading the about page if we're going to replace it with a KHTML part right away
    serviceType = "text/html";
    serviceName = "html";
}

svn path=/trunk/KDE/kdebase/apps/; revision=777016
2008-02-19 11:54:20 +00:00
David Faure bc0dceffed Fix warning from KConfigGroup::readXdgListEntry in about:plugins
svn path=/trunk/KDE/kdebase/apps/; revision=777013
2008-02-19 11:43:32 +00:00
Christian Ehrlicher 3212d8f0c5 LIB_INSTALL_DIR -> INSTALL_TARGETS_DEFAULT_ARGS
svn path=/trunk/KDE/kdebase/apps/; revision=776849
2008-02-18 21:51:54 +00:00
Script Kiddy ba35e0fd0d SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=776784
2008-02-18 20:27:57 +00:00
Bill Egert 0672125200 No longer use Obsolete Member for QWidget:
topLevelWidget() => window() 

svn path=/trunk/KDE/kdebase/apps/; revision=776408
2008-02-18 01:06:50 +00:00
Laurent Montel d2af4f8aa5 Fix build with enable-final
svn path=/trunk/KDE/kdebase/apps/; revision=776225
2008-02-17 17:07:59 +00:00
Peter Penz 72ab507fa4 * if the system font is changed during Dolphin is open, take care to update the used font of all views too (assuming that the user selected "system font" as font)
* store the font weight instead of a bool property "isBold"

Thanks to Rafael for the patch!

CCMAIL: ereslibre@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=776188
2008-02-17 15:50:06 +00:00
Peter Penz bd71832bc8 let F6 also select the whole text of the URL navigator to stay consistent with Konqueror and Firefox
BUG: 157589

svn path=/trunk/KDE/kdebase/apps/; revision=775977
2008-02-16 22:05:34 +00:00
Script Kiddy fa66a84a0b SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=775970
2008-02-16 21:43:04 +00:00
Peter Penz 2bd3ef34a6 update the selection-toggle (+/-) when the selection has been changed "outside" by the rubberband or e. g. "Select All"
svn path=/trunk/KDE/kdebase/apps/; revision=775828
2008-02-16 18:53:28 +00:00
Peter Penz c78aefe747 Bypassed a bug in QTreeView::mouseMoveEvent() (see comment in code). Submitted a bug-report to Trolltech, bug tracker ID is still pending (will add the ID into the code as soon as I get it).
svn path=/trunk/KDE/kdebase/apps/; revision=775736
2008-02-16 14:37:13 +00:00
Peter Penz b2dc9bc06e Provide an option for the details view to expand folders (= tree view), as this is required for Konqueror to get back this functionality from KDE 3. It is possible in Dolphin to enable this option too, but it is set to false per default.
BUG: 155571

svn path=/trunk/KDE/kdebase/apps/; revision=775621
2008-02-16 13:16:59 +00:00
Peter Penz 2902785174 SVN_SILENT: coding style fix (m_metadataWidget -> m_metaDataWidget)
svn path=/trunk/KDE/kdebase/apps/; revision=775612
2008-02-16 12:42:48 +00:00
Peter Penz 7a68c17714 fix possible crash, as MetaDataWidget::metaDataAvailable() can change during runtime
BUG: 157915

svn path=/trunk/KDE/kdebase/apps/; revision=775610
2008-02-16 12:40:38 +00:00
Peter Penz bbc2e8a15e Initially I thought it's better not having code as default value inside dolphin_generalsettings.kcfg. But the check for an empty home URL in DolphinMainWindow::init() must also be done when invoking GeneralSettings::setDefaults() in StartupSettingsPage, otherwise the home URL would get empty... Using QDir::homePath() as default-value inside the *.kcfg file prevents such issues.
CCMAIL: michael.a.oshea@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=775494
2008-02-15 23:13:47 +00:00
Peter Penz 2911481357 Currently when the general font of KDE has been changed, the used fonts for the view in Dolphin have not been changed.
This has been fixed by differing between a "Use system font" setting (= default) or a "Use custom font" setting.

TODO: if the general font of KDE is changed during Dolphin is open, no update is done yet

CCMAIL: ereslibre@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=775487
2008-02-15 22:51:23 +00:00
Peter Penz e8e68e124c David says: "PixmapViewer::setSizeHint should call updateGeometry() instead of all those layout hacks :)" - and as always David was right :-)
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=775421
2008-02-15 19:40:27 +00:00
Peter Penz 4457eee3e8 don't connect to a non-existent slot (the code for updateCutItems() is now part of the IconManager)
svn path=/trunk/KDE/kdebase/apps/; revision=775418
2008-02-15 19:32:14 +00:00
Robert Knight 47338e1816 Fix flicker when resizing the central view area in Dolphin. Only applicable with Qt 4.4 with alien widgets enabled. Any widgets passed to KDirLister::setMainWindow() become native widgets because of a call to QWidget::winId() inside KIO. This fix passes the top level Dolphin window to setMainWindow() (which is already a native window) instead of the item view widget.
svn path=/trunk/KDE/kdebase/apps/; revision=775396
2008-02-15 18:18:21 +00:00
David Faure 2c50b333b5 Add unit test for #149736 (an old bug where a javascript handler closes the window on click - and crashed konqueror again in kde 4)
(the fix is r775367 in kdelibs)
(side node: kapp->setTopWidget call removed since it doesn't care for the icon anymore, only for some startupid stuff)

svn path=/trunk/KDE/kdebase/apps/; revision=775373
2008-02-15 17:01:03 +00:00
David Faure 4ef6572639 Add unit test for #149736 (an old bug where a javascript handler closes the window on click - and crashed konqueror again in kde 4)
(the fix is r775367 in kdelibs)
(side node: kapp->setTopWidget call removed since it doesn't care for the icon anymore, only for some startupid stuff)

svn path=/branches/KDE/4.0/kdebase/apps/; revision=775368
2008-02-15 16:41:46 +00:00
Script Kiddy 096a418b29 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=775353
2008-02-15 15:48:52 +00:00
Script Kiddy 3d4c8c2b6a SVN_SILENT made messages (.desktop file)
svn path=/branches/KDE/4.0/kdebase/apps/; revision=775258
2008-02-15 10:07:26 +00:00
Peter Penz e20cea3c92 Bypass a temporary (?) regression (?) with the current Qt 4.4 beta version: it seems like QLayout::activate()/update() don't do a relayout anymore if the sizehint of a sub widget has been changed. I'll check this again with Qt 4.4.0.
svn path=/trunk/KDE/kdebase/apps/; revision=775119
2008-02-14 22:57:00 +00:00
Peter Penz d5e7c3b31f display an error message if the the user tries to set an invalid home URL in the settings dialog
svn path=/trunk/KDE/kdebase/apps/; revision=775098
2008-02-14 21:35:57 +00:00
Peter Penz 45db1058f7 minor code cleanup
svn path=/trunk/KDE/kdebase/apps/; revision=775094
2008-02-14 21:25:36 +00:00
Peter Penz 9b892cf6e8 backport: fixed issue that the item height does not match to the number of lines in the default setup of Dolphin
svn path=/branches/KDE/4.0/kdebase/apps/; revision=775067
2008-02-14 20:29:29 +00:00
Peter Penz 1b6bc79e40 fixed issue that the item height does not match to the number of lines in the default setup of Dolphin
svn path=/trunk/KDE/kdebase/apps/; revision=775065
2008-02-14 20:26:11 +00:00
Peter Penz 983cac5103 ~ is no useful home folder in a Windows environment (thanks to Michael O'Shea for the patch!)
BUG: 156463
CCMAIL: michael.a.oshea@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=775056
2008-02-14 20:11:51 +00:00
Script Kiddy 72aeaf1f95 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=774936
2008-02-14 13:04:07 +00:00
Script Kiddy fa7b430bfb SVN_SILENT made messages (.desktop file)
svn path=/branches/KDE/4.0/kdebase/apps/; revision=774850
2008-02-14 08:26:29 +00:00
Dirk Mueller b43f14a405 more readable
svn path=/trunk/KDE/kdebase/apps/; revision=774782
2008-02-13 23:23:32 +00:00
David Faure ae8ed1a047 Provide the "sort by" actions in dolphinpart (konqueror); share and simplify the code by connecting to the actiongroup's signal.
svn path=/trunk/KDE/kdebase/apps/; revision=774699
2008-02-13 20:52:21 +00:00
David Faure e86892de09 Provide the "sort by" actions in dolphinpart (konqueror); share and simplify the code by connecting to the actiongroup's signal.
svn path=/branches/KDE/4.0/kdebase/apps/; revision=774697
2008-02-13 20:51:00 +00:00
David Faure 427593bead change i18n in trunk
svn path=/trunk/KDE/kdebase/apps/; revision=774674
2008-02-13 20:05:42 +00:00
David Faure 266e53ba32 --deprecated
svn path=/trunk/KDE/kdebase/apps/; revision=774649
2008-02-13 18:49:30 +00:00