Commit graph

211 commits

Author SHA1 Message Date
Peter Penz 8d7a2c96ea Don't select items if the selection toggle has been disabled 2012-01-15 10:51:46 +01:00
Peter Penz 8306a0fa6c Don't show a expanding-toggle in the Folders Panel if there are no subdirectories
BUG: 290745
FIXED-IN: 4.8.0
2012-01-15 10:41:44 +01:00
Peter Penz b09986ef27 Fix current-item indicator in combination with the cleanlooks style
Thanks to Christoph Feck for the hint.

BUG: 290536
FIXED-IN: 4.8.0
2012-01-14 11:31:06 +01:00
Peter Penz d5d65f545a Fix selection issue when expanding a tree
The selection anchor must be reset when changing the current item
to the root of the tree.

BUG: 290832
FIXED-IN: 4.8.0
2012-01-12 07:01:24 +01:00
Peter Penz 6584f06cd1 Prevent accessing an item with an invalid index 2012-01-11 16:15:19 +01:00
Peter Penz 5289e852c1 Fix issue that shift + drag does not move files
BUG: 291103
FIXED-IN: 4.8.0
2012-01-10 17:23:56 +01:00
Peter Penz 69f68a2349 Prevent generating previews all the time during downloading a large file
When downloading a large file the preview should not be recreated each time
a change-notification has been received. Create the preview after getting
the first file change, but postpone creating the next previews until no change
has been done during a longer period of time.

BUG: 290698
FIXED-IN: 4.8.0
2012-01-09 22:18:24 +01:00
Peter Penz fc600ed255 Revert patch using the native graphicssystem as default
I'm trusting Christoph Feck's advice here. Additionally the smooth scaling
has been activated to fix bug 290865.

BUG: 290865
FIXED-IN: 4.8.0
2012-01-07 18:21:21 +01:00
Peter Penz 636292bfcb Details view: Fix wrong expansion level
The calculation of the root-expansion level had been incorrect which
lead to a wrong indentation on some directories.

BUG: 290757
FIXED-IN: 4.8.0
2012-01-06 18:03:15 +01:00
Peter Penz afc55cc985 Fix issue that an empty directory is shown in the split mode
Root-cause was that the signal KDirLister::completed(KUrl) must be watched
by the model and not KDirLister::completed().

BUG: 290182
FIXED-IN: 4.8.0
2012-01-05 21:25:33 +01:00
Peter Penz 33eea8c929 Folders Panel: Activate folders on single-click
Even if double-click is used as default setting, the folders panel should
open folders with a single-click.

BUG: 289971
FIXED-IN: 4.8.0
2012-01-05 20:44:46 +01:00
Peter Penz c8d8556950 Fix style-issues in items when not using Oxygen
Thanks to Jonathan Marten and Christoph Feck for the analyses
and the patch.

Still open: The focus frame in cleanlooks is not drawn.

CCBUG: 290536
2012-01-05 20:18:21 +01:00
Peter Penz 7953913c9f Fix inconsistency in selection manager
When a selection has been done with non-linear ranges, it was possible that
the anchor item pointed to an invalid index that resulted into an invalid
selection.

As part of this fix the sorting for DolphinView::selectedItems() has been
disabled (if the caller assumes a sorted selection he must manually adjust it).

BUG: 288908
FIXED-IN: 4.8.0
2011-12-30 00:09:42 +01:00
Peter Penz 3e9d31d293 Fix issue that dragging pictures/videos to Google-Search/YouTube fails
BUG: 289917
BUG: 278236
FIXED-IN: 4.8.0
2011-12-27 15:53:49 +01:00
Peter Penz 8b977e91fb Fix group-header clipping in compact mode 2011-12-27 09:11:08 +01:00
Peter Penz 7be14d0cde Fix icon alignment issue in the details view
BUG: 289889
FIXED-IN: 4.8.0
2011-12-27 08:34:15 +01:00
Peter Penz 8403383926 Minor cleanup: Rename m_keyboardAnchorXPos to m_keyboardAnchorPos 2011-12-26 22:44:26 +01:00
Peter Penz 2e2a6ae24c Improve item offset scrolling
Don't check whether the m_layoutTimer is active: Changing the
item offset must always trigger a synchronous layout, otherwise
the smooth-scrolling might get jerky.
2011-12-26 22:30:15 +01:00
Peter Penz 118fe89449 Fix keyboard issues when groups are enabled
When groups are enabled in Dolphin the key-up and key-down keys did not behave
consistent in comparison to traditional views or like done in editors.

CCBUG: 261995
CCBUG: 262038
2011-12-26 22:22:50 +01:00
Peter Penz 4dc5714016 Fix grouping issue
When switching to a group that is not shown currently, the group headers
won't be updated. The root-cause was that the m_groups-cache must be reset
when the roles have been changed.

CCBUG: 289654
2011-12-25 22:38:34 +01:00
Peter Penz ee26791cee Fix wrong grouping of types
- Uninitialized types count as one group
- Let the receiver of the signal itemsMoved() decide whether unmoved items
  really result in an unchanged visual appearance. This might e.g. be the case
  if the grouping is turned on and the group-names change although the items
  themselves have not changed their position.

BUG: 289654
FIXED-IN: 4.8.0
2011-12-25 11:39:46 +01:00
Peter Penz 00b0bfcd01 Fix sort-issue for trees
If a protocol like fish is used, the sorting of sub-trees was wrong. The root
cause was a wrong comparing of URLs where the protocol was not initialized.

BUG: 289697
FIXED-IN: 4.8.0
2011-12-24 14:16:10 +01:00
Peter Penz b5b8d48bb7 Don't show the name as part of the "path" role
This allows a useful grouping by paths when e.g. searching files.

BUG: 269335
FIXED-IN: 4.8.0
2011-12-23 23:38:38 +01:00
Peter Penz b2cb38214e Introduce "isExpandable" role
The role is used to determine whether a directory can be expanded at all. This
is e.g. not the case if a directory has 0 items or the target-URL is different
from the item-URL.

The expansion toggle will get hidden if a directory is not expandable.

CCBUG: 288521
2011-12-23 23:19:48 +01:00
Peter Penz 2cafa66f00 Fix possible double entries in details view
The patch 30ae57ba80 did not resolve the
issue completely: The pending items to insert must be dispatched before
checking for duplicates.

Related to this report the expanding for the remote-protocol has been
disabled.

BUG: 288521
FIXED-IN: 4.8.0
2011-12-23 21:15:48 +01:00
Peter Penz 6f699495b5 The key "space" should select the current item
Also in case if only one item is shown the navigation-keys should
trigger a selection of the current item. This works now consistent
within all view-modes (there have been been behavior differences
in Dolphin 1.7 depending on the used mode).

BUG: 289589
FIXED-IN: 4.8.0
2011-12-23 16:04:32 +01:00
Peter Penz 32faa14c1a Don't show child items of collapsed parent items
If a parent item got expanded and collapsed again, KDirLister keeps
the items of the previously expanded directory. Hence inserting new
items there will result in emitting the signal newItems() and a check
must be done whether the parent is still expanded.

BUG: 289598
FIXED-IN: 4.8.0
2011-12-22 21:50:30 +01:00
Peter Penz 2c77176c9c Fix first visible index calculation
When having a row with different item-heights, the calculation of the
first visible index might have been wrong.
2011-12-21 23:18:38 +01:00
Peter Penz 965107fd02 Update previews when the preview-plugin settings have changed
Thanks to Janardhan Reddy for the initial patch.

BUG: 288726
FIXED-IN: 4.8.0
2011-12-21 21:48:24 +01:00
Peter Penz a8622c7a1e Fix autoscroll issue when selecting items
If items get selected with the rubberband the scroll offset must stay inside
the visible range.

BUG: 282353
FIXED-IN: 4.8.0
2011-12-20 23:08:26 +01:00
Peter Penz e76affea64 Remove child items when a parent item gets deleted
BUG: 289447
FIXED-IN: 4.8.0
2011-12-20 22:22:24 +01:00
Frank Reininghaus a3c41997db KFileItemModel: Always use upper case letters to group by name
This fixes the following problems:
1. In a folder containing the items ~a and b, the first group,
   containing ~a, is named "Others".
2. In a folder containing the items a, ~b, ~c, and ~d, the first group
   "A" contains a and ~b, and the other two items are in the group
   "Others".
2011-12-20 02:03:31 +01:00
Peter Penz 023ab306c7 Hide tooltips when dragging items 2011-12-18 20:29:34 +01:00
Peter Penz 45a42d6a42 Turn off animations if they are globally disabled
Respect the graphicseffect level in the system settings. This will disable
all item-animations if the graphicseffect level is "NoEffect".

The smooth scrolling won't be disabled in this case, but the duration has been
made smaller so that it is not recognized as an animation.

BUG: 289238
FIXED-IN: 4.8.0
2011-12-18 15:38:42 +01:00
Peter Penz 422da53333 Force a root-expansion level for the trash protocol 2011-12-17 23:17:12 +01:00
Peter Penz 999e498a68 Determine the path of the trash-protocol correctly 2011-12-17 23:11:59 +01:00
Peter Penz fd60b81573 Animation finetuning
If dynamic item sizes are used don't animate the size of the widget
in along the dynamic direction. This prevents unnecessary animations when
increasing the window width in combination with e.g. the details view.
2011-12-16 23:57:33 +01:00
Peter Penz d0ba75d13e Minor layout and coding style cleanups
- Disable performance debugging output
- Force a synchronous layout during scrolling. This prevents having a jerky
  scroll-animation if there are pending operations ongoing in parallel.
- Minor coding style cleanups
2011-12-16 23:39:57 +01:00
Peter Penz ea2ed61cd1 Update the roles if items have been changed
The code "// TODO..." in slotItemsChanged() obviously was not
sufficient ;-)

BUG: 288691
BUG: 288824
BUG: 288921
FIXED-IN: 4.8.0
2011-12-16 22:06:12 +01:00
Frank Reininghaus dbfba7dfed Start an anchored selection when clicking a selection marker
BUG:200782
FIXED-IN:4.8.0
2011-12-15 00:36:30 +01:00
Peter Penz 065244fac9 Fix descending sort order issue
If the sort order is descending and directories and files are
shown on the same hierarchy level, the sorting was partly wrong.
2011-12-15 00:24:33 +01:00
Peter Penz 756c648f62 Don't show an expansion toggle for locked expansions 2011-12-15 00:05:33 +01:00
Peter Penz b27aefa798 Fix expansion levels for search results
Force an expansion level of 0 for search results to prevent
showing tabbed child items without parent items.
2011-12-14 23:46:12 +01:00
Peter Penz 0c1ad320d1 Fix filtering issue in combination with expanded items
When items have been expanded they should never get filtered, as
each child item must have a parent item.
2011-12-14 22:59:10 +01:00
Peter Penz 10659d97af Improve private method KFileItemModel::expansionLevelsCompare()
Get rid of the hack to access the m_itemData member for getting
the parent of an item during sorting. ItemData has been extended
by a parent-member which allows a fast and save way to do this.

Sadly this makes the unit-test for expansionLevelsCompare() more
complex and it has been temporary deactivated. I'll take care to
fix this during the next week.
2011-12-14 22:33:34 +01:00
Peter Penz ee8d9bb4ab Fix comment 2011-12-14 00:03:40 +01:00
Peter Penz 67783026f5 Fix several sort-issues
- Treeview: When sorting descending assure that the parent item is still
  ordered before the child items and not afterwards.
- Treeview: When sorting by other roles than names expansionsLevelCompare()
  had been buggy and resulted in ordering child items below wrong parent
  items.
- General: When sorting by another role than names and the role of
  two items had been equal a case sensitive sorting of the names had
  been done. This has been fixed by using the default name sorting
  as fallback.

BUG: 286726
FIXED-IN: 4.8.0
2011-12-13 23:43:28 +01:00
Michael Drueing bd9f6e49d3 dolphin: DLLEXPORT is not valid for template class
MSVC tries to import the specialized class from the library, which fails because only the generic version can be exported.
GCC probably silently ignores the export.
2011-12-13 23:07:24 +01:00
Christoph Feck a390d12de8 Respect style's viewport scrollbar layout policy
REVIEW: 103381
2011-12-12 17:36:19 +01:00
Peter Penz 42adf258b6 Remember sort settings
If the user has changed the sort-role or sort-order by clicking on the view-header of the details-view, the settings have been adjusted to the model but not remembered in the directory settings.
2011-12-11 20:24:38 +01:00