Commit graph

54 commits

Author SHA1 Message Date
David Faure
77780fb6dd - rename updater.cpp to faviconupdater.cpp to match classname
- connect to completed(bool) so that we get notified even in case of a delayed redirect (testcase: http://www.citefutee.com/orienter/rer.php). This was another case of "update all favicons" hanging forever.
CCBUG: 23102

svn path=/trunk/KDE/kdebase/apps/; revision=1119159
2010-04-26 17:46:35 +00:00
David Faure
3b5ccaacf5 Fix memory leak
svn path=/trunk/KDE/kdebase/apps/; revision=1119153
2010-04-26 17:29:02 +00:00
David Faure
f55ff68840 Move the bookmark model (+commands +commandhistory) into a lib of its own, for future sharing with other parts of kdebase
(e.g. bookmark toolbar and bookmark sidebar).
Not sure if it should end up in libkonq or libkio...
CCMAIL: hein@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=1118280
2010-04-24 09:06:17 +00:00
David Faure
7f5e80a8d3 Unbreak favicon checking; in many error cases it wouldn't proceed to the next item.
Also when the cached favicon was recent enough, then the kded module wouldn't emit anything;
fixed by adding a "forceDownloadHostIcon" and an error signal in the favicons kded module.
CCBUG: 23102
 (and probably others)

svn path=/trunk/KDE/kdebase/apps/; revision=1116050
2010-04-18 14:24:11 +00:00
David Faure
1cd5acff40 remove dep on globalbookmarkmanager.h; move m_model to holder
svn path=/trunk/KDE/kdebase/apps/; revision=1115823
2010-04-17 16:01:46 +00:00
David Faure
c2dee9346d Get rid of two more singletons (how many singletons can one have in a single program?)
svn path=/trunk/KDE/kdebase/apps/; revision=1115716
2010-04-17 08:10:35 +00:00
David Faure
4c3122d106 Fix the display of link and favicon status, by using KBookmark::metaDataItem/setMetaDataItem
rather than the ugly and wrong recursive descent that was done here [wrong because it was writing
into the freedesktop.org metadata rather than into the www.kde.org metadata]

svn path=/trunk/KDE/kdebase/apps/; revision=1112544
2010-04-08 12:50:34 +00:00
David Faure
054cbc204c Port favicon and testlink to having their own model pointer.
Try to repair these things (the status wasn't returned by the model), but doesn't seem to work yet.

svn path=/trunk/KDE/kdebase/apps/; revision=1112533
2010-04-08 12:16:33 +00:00
David Faure
310cc60143 Move CurrentMgr to its own header file and rename it to GlobalBookmarkManager for lack of a better idea.
svn path=/trunk/KDE/kdebase/apps/; revision=1101672
2010-03-10 14:37:11 +00:00
David Faure
76f5efc051 SVN_SILENT #include cleanups
svn path=/trunk/KDE/kdebase/apps/; revision=1050546
2009-11-17 15:46:55 +00:00
Tom Albers
671b224bd8 RELICENSE: GPL2->GPL2+/GPL23
svn path=/trunk/KDE/kdebase/apps/; revision=751022
2007-12-20 22:23:07 +00:00
Daniel Teske
153180367e Better. Make some things work.
Like drag and dropping bookmarks.
Filtering.
And various fixes all over the place.
Still not really where it should be for a release.

svn path=/trunk/KDE/kdebase/apps/; revision=748964
2007-12-16 01:47:07 +00:00
Laurent Montel
264d696087 Adapt to new KWarning/kFatal/kDebug api
svn path=/trunk/KDE/kdebase/apps/; revision=695870
2007-08-03 06:40:12 +00:00
Hamish Rodda
e7d5dfa47f Merging in from bleeding edge kdebase branch
- i18n ported
- KAccel removed
- Some fixes for OS X

svn path=/trunk/KDE/kdebase/kfind/; revision=528190
2006-04-10 11:57:13 +00:00
Laurent Montel
aed1a8b78d deprecated--
svn path=/trunk/KDE/kdebase/konqueror/; revision=506335
2006-02-06 15:07:10 +00:00
Laurent Montel
df86b65639 QString::null->QString()
svn path=/trunk/KDE/kdebase/kfind/; revision=493574
2006-01-02 17:28:18 +00:00
Dirk Mueller
40b74b7fc1 SVN_SILENT: fix typo
svn path=/trunk/KDE/kdebase/nsplugins/; revision=467416
2005-10-05 08:44:32 +00:00
Daniel Teske
36476349bf Should compile now.
svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=467290
2005-10-04 20:42:32 +00:00
Daniel Teske
40c354dcc3 Remove Q3PtrList from BookmarkIterator and derived classes.
Replave QVector<KBookmark> by QList<KBookmark> (== KBookmark::List).


svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=464923
2005-09-28 16:16:52 +00:00
Daniel Teske
aa3cb7cfe7 Forgot to remove these #includes
svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=462406
2005-09-20 23:47:35 +00:00
Daniel Teske
edb22adbd2 Make g++ not complain about a few unused function arguments.
svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=452349
2005-08-23 03:49:45 +00:00
Daniel Teske
fddf326d4e Port keditbookmarks to Qt4's model/view framework.
Editing, creating and selecting bookmarks works.
For deleting you have to run apply-patches in your qt-copy directory.
All other things are broken. (E.g. drag'n'drop, the edit fields at the bottom, the searchline...)

I wrote down some of my learned lessons while working with Qt4's model/view framework
at http://www.squorn.de/kde/qtmodelview.html


svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=448977
2005-08-13 20:13:21 +00:00
Stephan Kulow
e77f20dbaf svn merge svn+ssh://coolo@svn.kde.org/home/kde/trunk/KDE/kdebase@438057
svn+ssh://coolo@svn.kde.org/home/kde/branches/work/kde4/kdebase
          .

I couldn't resolve one kicker conflict that results from different
development directions, so I rely on Aaron to sort it out - the file
is commited with conflicts

svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=439627
2005-07-28 14:59:42 +00:00
Dirk Mueller
b3736b51bc update FSF address
svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=431577
2005-07-04 19:02:09 +00:00
Daniel Teske
1d51ccad92 Fix merge-while-modified by removing it.
(It used a broken design.)
Instead immediately forward changes in keditbookmarks
to all other kbookmarkmanagers.

BUG: 77355


svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=425768
2005-06-15 14:41:18 +00:00
David Faure
41aff60420 Fix compiler warning, and fix wrong mode in emacs (this is C++, not perl)
svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=412727
2005-05-12 12:15:44 +00:00
Alexander Kellett
6bf8aa8bab finish off bookmarkinfo functionality, adds one string
commented out various pieces of pointless debug info
use new dcop signal in kbookmarkmanager to signal bookmark config changes
added setNodeText minor refactor of NodeEditCommand::execute
use listview->setSelected(item, bool) rather than item->setSelected(bool)
various minor logic cleanups to help listview bug fixing
fix possible crash in updateListViewItem
various fixes to current item / selected item updates after bookmark deletion
update listview items based on changes in bookmarkinfo dialog
illustrate more clearly when a bookmark is in the selection:
   a lighter highlight is used than the actual qt selection highlighting
don't select the first listview item when someone clicks in the search linedit
don't notify all konquerors using deprecated notifyCompleteChange when saving:
   reuse waldo's dcop signal emitter - emitChanged()

strings added:
   "Times Visited"
   "Click here and type to search..."
      (was "Type here to search...", which looks very stupid)
sorry translators!!!! (for backgrounder, i am without internet so couldn't commit :()

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=264167
2003-11-03 10:33:23 +00:00
Alexander Kellett
adc71c9a93 fix a bunch of favicon updating crashes
load/save the status columns size in init, was defaulting to 0
init m_canPaste to false, no idea why this doesn't fix the vg bt

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=260183
2003-10-19 16:23:37 +00:00
Alexander Kellett
abe30eb0fb vim sucks, fix indentation
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=260112
2003-10-19 11:01:37 +00:00
Alexander Kellett
807e476f82 indent to 4 spaces
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=257985
2003-10-11 13:39:50 +00:00
Alexander Kellett
7f65c026be sick of having two different coding styles between kio/bookmarks and here,
so, add 4 space modelines to all files. i'll gradually fix the files over
the coming days.

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=256804
2003-10-06 18:31:25 +00:00
Alexander Kellett
0458ac2248 reorder includes - $0.h, "*.h", <*.h>
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=251057
2003-09-14 18:07:31 +00:00
Alexander Kellett
84f0b66e1d move data to privates and provide important const accessors
more const-ness fixes
cleanup (removal & renames) of member variables

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=212373
2003-03-08 15:26:42 +00:00
Alexander Kellett
7ccdbac059 const fixes in bookmarkiterator and subclasses
enum for paintstyle
method and variable renames
url()

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=212337
2003-03-08 13:22:06 +00:00
Alexander Kellett
49396d6ff7 fix the bug jens reported finally.
please $deity forgive me.

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=211895
2003-03-06 20:24:26 +00:00
Alexander Kellett
c78d55307d renames:
doBlah -> doAction
   isBlahable -> isApplicable

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=211136
2003-03-03 20:52:39 +00:00
Alexander Kellett
852c087df9 quick hack for jens
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=209566
2003-02-26 08:18:45 +00:00
Alexander Kellett
16033d764f split faviconupdater class into updater.{cpp,h}
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=208423
2003-02-21 21:28:33 +00:00
Alexander Kellett
5cecdebd4f replace another ugly ERROR comparison with hasParent use
favicons: don't crash on empty bookmark lists
make sure root qlistviewitem doesn't get added as bookmark

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=207858
2003-02-19 01:06:22 +00:00
Alexander Kellett
16dffadf69 more code section lines
shuffles

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=207152
2003-02-16 00:05:39 +00:00
Alexander Kellett
d30dd8bd74 KEBTopLevel -> KEBApp
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=207089
2003-02-15 19:00:14 +00:00
Alexander Kellett
35d5674e0e minor
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=207087
2003-02-15 18:58:36 +00:00
Alexander Kellett
1645189f9a minnor include fixups
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=206033
2003-02-10 14:37:56 +00:00
Alexander Kellett
29a80afc3f remove warning
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=206031
2003-02-10 14:31:53 +00:00
Alexander Kellett
20fd681e08 todo items
less startup time debug
revert accidental private -> public

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=206015
2003-02-10 13:50:01 +00:00
Alexander Kellett
859ba99bb2 shuffle compile fix make wonderful and a few other things
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=205237
2003-02-06 13:16:40 +00:00
Alexander Kellett
baba9e4c7e shuffles and cleanups
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=205216
2003-02-06 09:59:59 +00:00
Volker Augustin
6720f59d62 Replace comparison to QString::null with a call to member function .isNull().
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=202678
2003-01-25 08:39:50 +00:00
Alexander Kellett
4ff4b0c3e6 merge in make_it_even_cooler_branch
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=201732
2003-01-21 16:16:53 +00:00
Alexander Kellett
2e20b0f60b renamed a few one letter vars :)
fix most of the remaining TestLink bugs
CCMAIL:dfaure@kde.org

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=184517
2002-10-18 17:13:11 +00:00