Commit graph

1995 commits

Author SHA1 Message Date
Peter Penz 4eaced49cd assure that the autoresizing still works in combination with the "automatically expand folders during drag operations" feature
svn path=/trunk/KDE/kdebase/apps/; revision=879152
2008-11-02 14:29:27 +00:00
Peter Penz 4469d4d5a4 Assure that automatically expanding of a folder also works when the new folder has a different view mode.
CCMAIL: simon@etotheipiplusone.com

svn path=/trunk/KDE/kdebase/apps/; revision=879143
2008-11-02 13:57:35 +00:00
Pino Toscano 651ebed54b initialise in the correct order
svn path=/trunk/KDE/kdebase/apps/; revision=878498
2008-11-01 12:47:33 +00:00
Simon Paul St James dea4444c4a Be better behaved in the presence of scroll events in the middle of an elastic band selection by storing the last selection elastic band in view (rather than viewport) coordinates.
svn path=/trunk/KDE/kdebase/apps/; revision=878316
2008-10-31 21:45:51 +00:00
Simon Paul St James 76376eb22d Yet more corner cases in commitToggleIndexRange - include them, and refactor to make things a bit more logical.
svn path=/trunk/KDE/kdebase/apps/; revision=877164
2008-10-28 19:47:31 +00:00
Simon Paul St James 6e41855512 If ignoreOldInfo, we should manually clear oldSelectionRect - an obscure bug where it is no longer possible to use rubber band selection(!) occurs otherwise!
svn path=/trunk/KDE/kdebase/apps/; revision=877160
2008-10-28 19:42:40 +00:00
Simon Paul St James 1984e18ad1 Use nameColumnRect rather than duplicating code (change the local variable of the same name to prevent clashes!)
Use KFileItem::text() instead of KFileItem::name() there, too.

svn path=/trunk/KDE/kdebase/apps/; revision=877159
2008-10-28 19:40:51 +00:00
Simon Paul St James a124b15cfe Sometimes, the penultimate item in the bounds would get deselected when it shouldn't - this is because lastIndex is always included in the toggle range, even if it needn't be toggled. Fixed now - hopefully, there are no more "elastic band selection" bugs, now :)
svn path=/trunk/KDE/kdebase/apps/; revision=876724
2008-10-27 21:49:16 +00:00
Simon Paul St James ad647bd0a0 Restore behaviour (I don't have an old version to check against, though!) - if CTRL is pressed when initiating elastic band, respect the item selection at that time while dragging the band.
CCMAIL : peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=876690
2008-10-27 20:55:54 +00:00
Simon Paul St James 75480d07cd Essential validity check that fell through the cracks when setSelectionRecursive was removed.
svn path=/trunk/KDE/kdebase/apps/; revision=876682
2008-10-27 20:32:29 +00:00
Simon Paul St James 74bb633cbd KFileItem name() and text() needn't be the same, and we should prefer text(). Testcase - very (very) recent settings:/ in Konqueror. Thanks to dfaure for clairvoyant diagnosis!
CCMAIL : peter.penz@gmx.at
CCMAIL : faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=876681
2008-10-27 20:29:02 +00:00
Andreas Hartmetz 1fabd1bab5 link with gold
svn path=/trunk/KDE/kdebase/apps/; revision=876282
2008-10-26 23:55:34 +00:00
Simon Paul St James accafbf95e If we commit a toggle range due to a change of parent, check to see if we should immediately form a new range with the current index. This stops child items from sometime being missed by the band.
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=876240
2008-10-26 21:21:58 +00:00
Simon Paul St James 382ac5f01d When restoring the index, we don't necessarily want to scroll to it.
BUG:165551

svn path=/trunk/KDE/kdebase/apps/; revision=876177
2008-10-26 17:25:14 +00:00
Simon Paul St James 0d8aebb7ba Fix a very obscure previews-in-tooltip bug.
svn path=/trunk/KDE/kdebase/apps/; revision=876175
2008-10-26 17:23:24 +00:00
Simon Paul St James c1e7177075 Revert http://websvn.kde.org/?view=rev&revision=876107 - it introduced a massive performance regression and also didn't really fix the issue. Use new way that fixes the issue in a less direct but more general way.
Also - ;-- :)

svn path=/trunk/KDE/kdebase/apps/; revision=876137
2008-10-26 15:48:29 +00:00
Peter Penz 5735251bbb improved drag & drop support for Ark
CCMAIL: haraldhv@stud.ntnu.no

svn path=/trunk/KDE/kdebase/apps/; revision=876115
2008-10-26 14:39:13 +00:00
Peter Penz 883ef3c9b2 more straight forward syntax (no change of behavior is done)
svn path=/trunk/KDE/kdebase/apps/; revision=876110
2008-10-26 14:27:04 +00:00
Simon Paul St James c648d4ae96 Minor fix - ensure that the horizontal elastic band optimisation info works with filenames that are wider than the name column.
svn path=/trunk/KDE/kdebase/apps/; revision=876107
2008-10-26 14:17:34 +00:00
Peter Penz 82908b442b Improve the selection performance of the details view by factor of 5 (patch provided by Simon St. James).
CCMAIL: kdedevel@etotheipiplusone.com


svn path=/trunk/KDE/kdebase/apps/; revision=876099
2008-10-26 14:04:17 +00:00
Peter Penz 22d22a9cd7 Show the iconsize of zoom sliders as tooltip (code shamelessly stolen from Rafael's patch in kfilewidget ;-))
svn path=/trunk/KDE/kdebase/apps/; revision=876081
2008-10-26 13:04:33 +00:00
Peter Penz d133875139 assure that the zoom level is updated when refreshing the view
svn path=/trunk/KDE/kdebase/apps/; revision=876079
2008-10-26 13:02:40 +00:00
Peter Penz b1aadb8cce If the context menu is opened above a directory, add the actions "Open in New Window" and "Open in New Tab" to the context menu.
Thanks to Mathias Soeken for the patch!

CCMAIL: msoeken@tzi.de

svn path=/trunk/KDE/kdebase/apps/; revision=875711
2008-10-25 10:32:55 +00:00
Peter Penz 0ff69a11b8 use the DolphinDirLister instead of KDirLister
svn path=/trunk/KDE/kdebase/apps/; revision=875703
2008-10-25 09:49:57 +00:00
Peter Penz 5d69f066db * renamed "[x] Show Full Location" to "[x] Editable Location"
* renamed "Edit Location" to "Replace Location"

svn path=/trunk/KDE/kdebase/apps/; revision=875699
2008-10-25 09:41:39 +00:00
Peter Penz 6efdfda500 SVN_SILENT: minor coding style fixes
svn path=/trunk/KDE/kdebase/apps/; revision=875696
2008-10-25 09:21:20 +00:00
Mathias Soeken 75bf8edaeb You can now switch the tabs in dolphin via keyboard shortcuts like in konqueror
svn path=/trunk/KDE/kdebase/apps/; revision=875689
2008-10-25 09:00:28 +00:00
Peter Penz e7bd514a39 * Move code from DolphinDropController to DragAndDropHelper.
* Move code which checks whether the dragging of a MIME type is supported to DragAndDropHelper. This allows adding an improved support for dropping compressed files from Ark to Dolphin later...

CCMAIL: haraldhv@stud.ntnu.no

svn path=/trunk/KDE/kdebase/apps/; revision=875611
2008-10-24 22:19:23 +00:00
Peter Penz a96437d600 Provide a UI option for the "auto expand folders during drag operations" feature. The feature is not 100 % finished yet (dragging into a folder having a different view type does not work yet), but it's important to get in the UI string for the translators.
svn path=/trunk/KDE/kdebase/apps/; revision=875582
2008-10-24 21:12:11 +00:00
Peter Penz dc6bd8046f Assure that no reloading is done if KDirLister emits a redirection, only change the the URL. Thanks to David Faure and Albert Alstals Cid for the detailed analysis!
BUG: 155591

svn path=/trunk/KDE/kdebase/apps/; revision=875554
2008-10-24 19:52:28 +00:00
Peter Penz 6f49557ceb performance improvement when selecting items
svn path=/trunk/KDE/kdebase/apps/; revision=875518
2008-10-24 17:57:10 +00:00
Enrique Matías Sánchez e900b5a32e SVN_SILENT Fix typos in kdebase
svn path=/trunk/KDE/kdebase/apps/; revision=875089
2008-10-23 09:31:44 +00:00
Peter Penz e028a702ff use a smaller radius for the tooltip borders to stay consistent with the Oxygen style
svn path=/trunk/KDE/kdebase/apps/; revision=874948
2008-10-22 21:04:03 +00:00
Peter Penz 0190459ebd KBallonTipDelegate is not used at all in Dolphin.
svn path=/trunk/KDE/kdebase/apps/; revision=874947
2008-10-22 21:02:55 +00:00
Peter Penz c916e5ff27 Don't draw a frame for previews in tooltips by code duplication: Now we had 3 different frame types in Dolphin (frames from KFilePreviewGenerator, no frame in the Information Panel and an outdated frame by code duplication from the old file preview generator).
Until we find a nice way to make the code for drawing frames in KFilePreviewGenerator public, better don't draw any frame at all.

svn path=/trunk/KDE/kdebase/apps/; revision=874942
2008-10-22 20:52:45 +00:00
Peter Penz cb928888f7 * don't show a tooltip if a rubberband selection is done
* hide a tooltip if a drag operation has been started

BUG: 173148
CCMAIL: simon@etotheipiplusone.com

svn path=/trunk/KDE/kdebase/apps/; revision=874641
2008-10-22 06:11:59 +00:00
Frederik Schwarzer 4516323b9b global typo
more then -> more than
other then -> other than

svn path=/trunk/KDE/kdebase/apps/; revision=872169
2008-10-16 13:59:07 +00:00
Peter Penz 0a15626099 fixed regression: don't change the state, otherwise when having a split view it is not possible dragging an item from the inactive to the active view (only the rubberband gets active in this case)
CCMAIL:  simon@etotheipiplusone.com

svn path=/trunk/KDE/kdebase/apps/; revision=871928
2008-10-16 06:00:07 +00:00
Peter Penz 49fd5b1c4b assure that the minimized width can never get larger than the default width
svn path=/trunk/KDE/kdebase/apps/; revision=871881
2008-10-15 21:41:59 +00:00
Peter Penz d39451d6d1 SVN_SILENT: coding style fix
svn path=/trunk/KDE/kdebase/apps/; revision=871877
2008-10-15 21:36:16 +00:00
Peter Penz 994095076c Assure that the item delegate draws the hover effect and the selection for the details view only above the icon + name. Open issue: The performance when selecting files by the rubberband is too slow (will be fixed before KDE 4.2).
CCBUG: 165999
CCMAIL: simon@etotheipiplusone.com

svn path=/trunk/KDE/kdebase/apps/; revision=871874
2008-10-15 21:23:42 +00:00
Peter Penz d6a2d5594f First step for having a details view, where only the icon + name act as selectable area (not the whole width of the name column - similar to KDE3). Thanks to Simon St. James for the original patch!
Currently it is very confusing that although only the icon + name is selectable, still the selection and hovering is drawn above the whole column width. This will be fixed before KDE 4.2.

CCBUG: 165999
CCMAIL: simon@etotheipiplusone.com

svn path=/trunk/KDE/kdebase/apps/; revision=871834
2008-10-15 19:23:09 +00:00
Simon Paul St James 20587e7f14 - Fix crash found while investigating https://bugs.kde.org/show_bug.cgi?id=170927
svn path=/trunk/KDE/kdebase/apps/; revision=871808
2008-10-15 17:47:27 +00:00
Peter Penz e0bef260da Assure that the docks get informed about an URL change before the GUI is setup (thanks to Frank Reininghaus for the patch!). This prevents that slots from the docks are called with invalid URLs.
BUG: 169103
CCMAIL: frankreininghaus@web.de>

svn path=/trunk/KDE/kdebase/apps/; revision=871525
2008-10-15 06:03:41 +00:00
David Faure 256f361e40 Don't show an empty error dlg box when aborting deletion.
svn path=/trunk/KDE/kdebase/apps/; revision=871137
2008-10-14 00:24:54 +00:00
David Faure 76fa5aec6b Konq popupmenu fix: we don't show the "Create new" submenu over subdirs in an iconview because you wouldn't see the just-created file/dir,
but let's show it in the case of the hiearchical details view ("folders expandable" option), since you can indeed see the new file/dir in that case. Peter: problem solved with itemsExpandable().
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=871109
2008-10-13 21:54:03 +00:00
Peter Penz 3b77f108ae Simplify the treeview panel implementation (thanks to David Faure for pimping KDirModel::expandToUrl() :-)).
svn path=/trunk/KDE/kdebase/apps/; revision=869982
2008-10-11 14:13:14 +00:00
Peter Penz 5ab9dca1f9 make it compile if no nepomuk is available
svn path=/trunk/KDE/kdebase/apps/; revision=869739
2008-10-09 22:09:14 +00:00
Peter Penz 9e42591422 assure that the zoom slider/capacity bar gets hidden correctly if the width is too small for having a fitting text
svn path=/trunk/KDE/kdebase/apps/; revision=869727
2008-10-09 21:32:06 +00:00
Peter Penz a6754078cc Improve performance of information panel. Depending on the used backend reading the meta information like rating, tags and comments can be slow (especially when e. g. selecting 1000 files at once having items that are not cached yet). The reading of the meta information is now forwarded to a separate thread, so that Dolphin never gets blocked.
CCMAIL: sebastian@trueg.de
BUG: 170017
BUG: 164309
BUG: 166057

svn path=/trunk/KDE/kdebase/apps/; revision=869401
2008-10-08 21:46:25 +00:00