KFilePlacesModel creates the Desktop and Downloads bookmarks only if
their folder exists.
This should hopefully fix the failing test on the CI (actual count = 15,
expected count = 17), since the CI runs in docker and probably doesn't
have those two folders by default.
Summary:
Root and Trash test cases are currently failing because of
commit e133c4557e.
Reviewers: #dolphin
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D16005
Summary:
With the new uds implementation, when some data is meant to replace an old one, it has to use replace() instead of insert() to avoid an assert of data already exists.
Use 3 different entries and only insert().
Test Plan:
before: crash in the uds assert
after: passes the test
Reviewers: #dolphin, #frameworks, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Subscribers: bcooksley, bshah, nalvarez, cfeck, dfaure, aacid, ngraham, bruns, elvisangelaccio, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D13813
Summary:
With the new uds implementation, when some data is meant to replace an old one, it has to use replace() instead of insert() to avoid an assert of data already exists.
Use 3 different entries and only insert().
Test Plan:
before: crash in the uds assert
after: passes the test
Reviewers: #dolphin, #frameworks, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Subscribers: dfaure, aacid, ngraham, bruns, elvisangelaccio, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D13813
Otherwise the test executable will not be able to find the .rc file
while creating a DolphinMainWindow instance.
We also need to force the component name to `dolphin`, otherwise kxmlgui
will default to the name of the binary (which in this case would be
dolphinmainwindowtest rather than dolphin).
We deactivate the previously active view container whenever we change the active
split view, but we never do the same when we close the split view.
Long term we should probably even delete the secondary view after
closing the split view, because it will never be used again and the
pointer will be overwritten the next time the user opens the split view.
Summary:
Make sure that the place can be edited after the creation.
Depends on D9333
BUG: 389147
Test Plan:
Create an item in dolphin places panel, make sure that you
can rename it
Reviewers: #dolphin, ngraham
Reviewed By: ngraham
Subscribers: michaelh, elvisangelaccio, lbeltrame, ngraham, #dolphin
Differential Revision: https://phabricator.kde.org/D9985
Summary:
BUG: 389401
KIO model now provides Baloo URLs; we need to remove the old ones
created by Dolphin places model
BUG: 387888
Depends on D9332
Test Plan: unit test
Reviewers: mwolff, #dolphin, ngraham, elvisangelaccio
Reviewed By: #dolphin, ngraham, elvisangelaccio
Subscribers: elvisangelaccio, broulik, ervin, ngraham, #dolphin
Differential Revision: https://phabricator.kde.org/D9333
Summary:
Make sure that hidden devices loaded after module initialization does
not appear in the view.
Check for item visibility before add it on the model.
Test Plan: Unit test created
Reviewers: franckarrecot
Reviewed By: franckarrecot
Subscribers: cfeck, ervin, #dolphin
Differential Revision: https://phabricator.kde.org/D9441
Summary:
Use Kio::KPlacesModel as source model for PlacesItemModel avoiding
duplicated code.
Depends on D8862
Depends on D8332
Depends on D8434
Depends on D8348
Depends on D8630
Test Plan: Unit test created
Reviewers: elvisangelaccio, emmanuelp, mlaurent, mwolff
Reviewed By: elvisangelaccio, mlaurent, mwolff
Subscribers: mwolff, mlaurent, anthonyfieroni, nicolasfella, ngraham, #dolphin
Differential Revision: https://phabricator.kde.org/D8855
Summary: Make sure that PlacesItemModel is covered by unit test
Reviewers: ervin, elvisangelaccio, mwolff
Reviewed By: ervin, elvisangelaccio, mwolff
Subscribers: mwolff, elvisangelaccio, ngraham, #dolphin
Differential Revision: https://phabricator.kde.org/D8630
Summary:
This patch aims to improve user experience by not allowing the user to drag and drop a folder into itself.
The current behavior shows a red message at the top which can then be closed by the user, instead of relying on that, this patch disables the option of dropping onto self and uses the "Invalid drop target cursor" to highlight the behavior.
BUG: 307747
Since spectacle is unable to screenshot the cursor overlay, find attached a photo of the screen.
{F3787651}
Test Plan:
1. Drag a folder.
2. Drop it onto itself.
Reviewers: #dolphin, elvisangelaccio, ngraham, rkflx, dfaure
Reviewed By: #dolphin, elvisangelaccio, rkflx, dfaure
Subscribers: rkflx, ngraham, elvisangelaccio, dfaure, anthonyfieroni, #konqueror
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D6281
For now it contains a test case for the crash in bug #379135
CCBUG: 379135
Reviewers: emmanuelp, dfaure
Differential Revision: https://phabricator.kde.org/D5936
This allows us to speed up the compilation because we don't need to
build twice the source files we use in the unit tests.
Test Plan: Builds, dolphin works and tests pass.
Reviewers: emmanuelp, dfaure
Differential Revision: https://phabricator.kde.org/D5935
Summary: This enables us to run the tests on Windows.
Reviewers: elvisangelaccio, kfunk, dfaure
Reviewed By: elvisangelaccio
Subscribers: #konqueror, #dolphin
Differential Revision: https://phabricator.kde.org/D5810
This is merge of #128964 and #128942. This will impelement changing the "Date" field to "Modified" and allow a new "Accessed" time field to be available. This also includes changes to update configuration files.
REVIEW: 129077
The test was not saving its changes to the global settings, so it was
passing on the CI only because the default value of GlobalViewProps is
already false. If GlobalViewProps was set to true instead, testAutoSave()
would fail because save() was not called and GlobalViewProps was not
