Commit graph

3894 commits

Author SHA1 Message Date
Peter Penz
80ac5847a3 Update the URL if the accessibility has been changed
CCBUG: 301071
2012-06-15 11:37:50 +02:00
Peter Penz
e9463ffe2a Fix regression: Open file if entering it in the URL-navigator
The regression has been introduced when hiding the DolphinDirLister
inside KFileItemModel. Now the signal urlIsFileError() gets forwarded
to the container again where the file will be opened.

BUG: 301757
FIXED-IN: 4.9.0
2012-06-13 15:18:21 +02:00
Peter Penz
fb15dac975 Drag pixmap: Turn off the hover-state 2012-06-12 13:26:23 +02:00
Peter Penz
c95255eb90 Drag-pixmap fixes
- Don't use the selection-tinted icon when dragging a single item
- Decrease the vertical gap for the hotspot
- Prevent drawing tree-lines when dragging items for the Places Panel

CCBUG: 301624
2012-06-12 13:21:17 +02:00
Peter Penz
6c15705528 Update "isExpandable" and "size"-roles
If the "isExpandable"- or "size"-role is shown for a folder, the
number of sub-items must be watched to be able to update the
state of those 2 roles.

This fixes the issue that e.g. no expanding-toggle is shown
if an sub-directory has been created inside an empty directory.

BUG: 293972
FIXED-IN: 4.9.0
2012-06-11 15:46:55 +02:00
Peter Penz
dbf233ea28 Folders Panel: Also count directory links
... otherwise no expansion toggle will be shown. The implementation
is a compromise between performance and correctness: If the directory
contains links that are not directories, an unnecessary expansion
toggle will be shown. But this is better than showing no expansion
toggle in case if the directory contains links that point to other
directories.

BUG: 299997
FIXED-IN: 4.9.0
2012-06-09 13:37:42 +02:00
Peter Penz
57cde56158 Inline renaming: ESC should cancel the renaming
When emitting the roleEditingCanceled-signal it must be prevented
that a roleEditingFinished-signal is emitted because of some
action taken in the receiver-slot.

BUG: 301480
FIXED-IN: 4.9.0
2012-06-09 13:12:23 +02:00
Peter Penz
1ddd9c4032 Inline renaming: Improve focus handling
Fix issue that cancelling the inline-renaming by clicking
on the other split view applies the wrong focus.

Thanks to Frank Reininghaus for the initial patch and noticing
this issue.

CCBUG: 301252
2012-06-08 22:51:01 +02:00
Peter Penz
ba6b4a6632 Fix wrong loading of sort-role 2012-06-08 22:30:29 +02:00
Peter Penz
b2f5de9744 Krazy fixes 2012-06-08 22:08:29 +02:00
Peter Penz
98a4aa10ef Inline renaming fixes
- Don't use an outdated KFileItem when renaming an item more than once
- Use the same font as the view
- Don't lose the focus when an editor-popup is shown

BUG: 299327
BUG: 298883
BUG: 301253
FIXED-IN: 4.9.0
2012-06-08 16:40:01 +02:00
Peter Penz
0c206bda8e Emit zoomLevelChanged() if the preview gets toggled 2012-06-07 23:28:52 +02:00
Peter Penz
5c163a41c5 Hide "Recently Accessed" and "Search for" if indexing is disabled
The bookmarks for "Recently Accessed" and "Search for" require
enabled indexing not only an enabled Nepomuk.

BUG: 301340
FIXED-IN: 4.9.0
2012-06-07 23:10:04 +02:00
Peter Penz
c214b3751f Setup storage device if needed
BUG: 301071
FIXED-IN: 4.9.0
2012-06-07 23:00:57 +02:00
Frank Reininghaus
c0533e1aaa Ctrl+Shift+click should have the same effect as Shift+click
This makes Dolphin 2.0's behaviour consistent with Dolphin 1.x.

BUG: 300788
FIXED-IN: 4.9.0
2012-06-03 23:03:27 +02:00
Frank Reininghaus
16b3b82900 Prepend "cd" and "clear" commands with a space in the Terminal Panel
This prevents that these commands, which have not been enetered by the
user, but generated automatically, appear in the shell history, provided
that the shell is configured appropriately.

BUG: 204039
FIXED-IN: 4.9.0
2012-06-03 22:50:05 +02:00
Peter Penz
86ce0d761d Hide tooltip when changing the zoomlevel
BUG: 301056
FIXED-IN: 4.9.0
2012-06-02 17:42:11 +02:00
Peter Penz
931e180400 Always support a moving animation in case of the details view
This fixes the issue that resizing items results in flickering
when expandable items are shown.
2012-06-02 16:09:24 +02:00
Peter Penz
5269938f24 Don't remove/insert an item if no moving has been done at all 2012-06-02 15:53:50 +02:00
Peter Penz
a2674f5184 Provide a default name when adding a search query to the places panel
BUG: 300430
FIXED-IN: 4.9.0
2012-06-02 15:47:17 +02:00
Peter Penz
12215d6f0f Use PlacesItemModel instead of KFilePlacesModel
This allows inserting items to the corresponding group.
2012-06-02 15:03:22 +02:00
Peter Penz
665c44821e Always use single-click for the places panels
BUG: 300924
FIXED-IN: 4.9.0
2012-05-31 14:03:57 +02:00
Frank Reininghaus
397f8783d9 Improve arrow key navigation in Details View with expanded folders
If the current folder is collapsed, pressing the left arrow key now
moves the focus to the parent folder.

CCBUG: 300582
(cherry picked from commit 93daadae28)
2012-05-30 09:26:31 +02:00
Peter Penz
203449110e Get rid of obsolete DolphinPlacesModel 2012-05-29 13:14:12 +02:00
Peter Penz
4e2f3dcffe Implement dropping of items into the Places Panel
Some polishing regarding the icons and group-alignment must still
be done, but at least the basic functionality is back again.
2012-05-28 23:11:52 +02:00
Peter Penz
276100dcec Fix triggering of Q_ASSERT in PlacesItemModel
Check the group-type of an item to decide whether the item
should be inserted as device or not.

BUG: 300671
FIXED-IN: 4.9.0
2012-05-26 22:01:37 +02:00
Mark Gaiser
a5c25d2de5 Make tooltip background blurred.
REVIEW: 105061
2012-05-26 18:05:25 +02:00
Frank Reininghaus
23ab605157 Show all items in the directory when the name filter is cleared
The problem was the following: While a QMutableSetIterator iterates the
items in the QSet m_filteredItems, all items that match the new filter
are removed from the set. However, to ensure that the iterator still
reaches all items in the set, one must not use QSet::remove(), but
rather the iterator's remove() method (see QMutableSetIterator docs).

CCBUG: 300504
(cherry picked from commit 288473a96c)
2012-05-26 16:35:31 +02:00
Frank Reininghaus
f061d2a6b3 Use an italic font for symbolic links
BUG: 298218
FIXED-IN: 4.9.0
2012-05-26 15:32:57 +02:00
Peter Penz
e76ec71536 Minor coding style fixes 2012-05-26 13:46:30 +02:00
Peter Penz
073f8cae13 Further preperations for drag & drop support in the places panel 2012-05-26 13:41:30 +02:00
Dawit Alemayehu
f7622d3239 Removed unused list iterators 2012-05-24 13:37:41 -04:00
Jekyll Wu
a5aa8d7bd6 Use KService to lookup the library name of konsolepart
See https://git.reviewboard.kde.org/r/105028/
2012-05-25 00:54:08 +08:00
Frank Reininghaus
0f70b60480 Enable the "Empty Trash" action if items are deleted by non-KDE apps
To achieve this, the Places Panel context menu now checks the icon of
the "Trash" item (which is updated by a dir lister that watches the
state of the trash), rather then reading a config file which is only
used by KDE applications.

BUG: 293651
FIXED-IN: 4.9.0
2012-05-21 23:19:08 +02:00
Peter Penz
ff9ce4dab3 Colorize icons when an item is selected
BUG: 295515
FIXED-IN: 4.9.0
2012-05-21 22:41:57 +02:00
Peter Penz
894232ebda Places Panel: Show drop indicator
The dropping itself has not been implemented yet.
2012-05-21 21:48:45 +02:00
Peter Penz
3b6892b685 Use flat control-buttons 2012-05-19 22:44:37 +02:00
Peter Penz
c318a3da6c Show video previews according to file content instead of the mimetype-string
Show a video widget depending on the video content instead of the mimetype
string: There are container formats which can be either audios or videos.
Besides, the rmvb video files have a mimetype of
"application/vnd.rn-realmedia", and these files can be recognized as videos
correctly now.

The patch has been provided by Hui Ni.

REVIEW: 104988
FIXED-IN: 4.9
2012-05-19 22:30:31 +02:00
Peter Penz
e9d29bcf30 Enable basic drag and drop support for the Places Panel
The dropping has not been implemented yet, however in the context of
this step the creating of the drag-pixmap is now forwarded to
the item-widgets. This allows creating some optimized dragging-pixmaps
e.g. for the details-view, where only the name and icon should
be provided as drag-pixmap.
2012-05-18 23:31:44 +02:00
Peter Penz
d9eab08fcb Don't create a .directory-file for each directory
This regression has been introduced on master and has not been
released yet: Due to the changed properties-format an update has
been done which resulted in writing a .directory file into each
newly entered directory.

The patch updates the view-properties and version only in the
constructor so that it is assured that reading properties never
accidently will change the internal version.

A unit-test has been added to catch regressions like this in future.

BUG: 300240
FIXED-IN: 4.9.0
2012-05-18 19:43:17 +02:00
Peter Penz
a6241cf8ea Fix index-range issue 2012-05-17 22:10:18 +02:00
Peter Penz
727fd64e12 Create unit-test for KStandardItemModel 2012-05-17 22:00:39 +02:00
Peter Penz
bd02faa982 KStandardItemModel: Fix inconsistent internal state
Assure that the index-cache is kept consistent with the items when
a removing or inserting is done. A unit-test will be created as soon
as possible.
2012-05-17 13:34:31 +02:00
Peter Penz
bca055a38e Add unit-test to test a possible crash when updating group-headers 2012-05-17 11:47:21 +02:00
Peter Penz
ff6e4341c5 Fix crash related to group-headers
If multiple ranges are inserted or removed, the updating of
the group-headers may only be done after _all_ ranges have been
inserted/removed and not after each individual range. Otherwise
the layouter-cache is not in a consistent state yet.
2012-05-17 11:16:19 +02:00
Peter Penz
855560dd32 Shorten the "path" content if possible
Replace the home-path by '~' for having a shorter content.
2012-05-16 23:42:13 +02:00
Peter Penz
3ad3dd5afb Fix default sort-role
The default sort-role property internally has been renamed from
"name" to "text" to be open for more generic usecases like in
the KStandardItemModel.
2012-05-16 23:27:36 +02:00
Peter Penz
3e2cf9721b Provide default view properties for system-places
For the "Recently Accessed"-places and "Search For"-places like
documents, images, audio-files and videos proper default properties
are created now (e.g. previews and images-sizes are shown when
searching for "images" etc).
2012-05-16 23:13:55 +02:00
Peter Penz
2fd31c8a95 Update trash-icon dependent on whether the thrash is empty or not
The class PlacesItemStorageAccessListener has been renamed to
PlacesItemSignalHandler and represents a generic signal handler
for the PlacesItem.
2012-05-16 19:19:57 +02:00
Peter Penz
a632e8b9ef Fix possible crash when hiding items 2012-05-16 16:51:17 +02:00