Commit graph

3714 commits

Author SHA1 Message Date
Peter Penz
e71bdb0cf6 Fix autoscroll issue when selecting items
If items get selected with the rubberband the scroll offset must stay inside
the visible range.

BUG: 282353
FIXED-IN: 4.8.0
2011-12-20 23:07:49 +01:00
Peter Penz
d9e1db6ea4 Remove child items when a parent item gets deleted
BUG: 289447
FIXED-IN: 4.8.0
2011-12-20 22:30:15 +01:00
Peter Penz
e76affea64 Remove child items when a parent item gets deleted
BUG: 289447
FIXED-IN: 4.8.0
2011-12-20 22:22:24 +01:00
Script Kiddy
8012fe7da2 SVN_SILENT made messages (.desktop file) 2011-12-20 16:23:36 +01:00
Peter Penz
090393599c Show an error when dragging above a folder without write access
Got OK from the translator team to add this new string.
2011-12-20 08:58:24 +01:00
Frank Reininghaus
a3c41997db KFileItemModel: Always use upper case letters to group by name
This fixes the following problems:
1. In a folder containing the items ~a and b, the first group,
   containing ~a, is named "Others".
2. In a folder containing the items a, ~b, ~c, and ~d, the first group
   "A" contains a and ~b, and the other two items are in the group
   "Others".
2011-12-20 02:03:31 +01:00
Script Kiddy
404d54fc4a SVN_SILENT made messages (.desktop file) 2011-12-19 15:32:33 +01:00
Peter Penz
023ab306c7 Hide tooltips when dragging items 2011-12-18 20:29:34 +01:00
Peter Penz
45a42d6a42 Turn off animations if they are globally disabled
Respect the graphicseffect level in the system settings. This will disable
all item-animations if the graphicseffect level is "NoEffect".

The smooth scrolling won't be disabled in this case, but the duration has been
made smaller so that it is not recognized as an animation.

BUG: 289238
FIXED-IN: 4.8.0
2011-12-18 15:38:42 +01:00
Script Kiddy
36a97150df SVN_SILENT made messages (.desktop file) 2011-12-18 09:51:34 +01:00
Peter Penz
422da53333 Force a root-expansion level for the trash protocol 2011-12-17 23:17:12 +01:00
Peter Penz
999e498a68 Determine the path of the trash-protocol correctly 2011-12-17 23:11:59 +01:00
Peter Penz
5f1ae054d7 Hide tooltips when the view is scrolled 2011-12-17 23:01:41 +01:00
Script Kiddy
e983cbeae5 SVN_SILENT made messages (.desktop file) 2011-12-17 09:44:01 +01:00
Peter Penz
fd60b81573 Animation finetuning
If dynamic item sizes are used don't animate the size of the widget
in along the dynamic direction. This prevents unnecessary animations when
increasing the window width in combination with e.g. the details view.
2011-12-16 23:57:33 +01:00
Peter Penz
d0ba75d13e Minor layout and coding style cleanups
- Disable performance debugging output
- Force a synchronous layout during scrolling. This prevents having a jerky
  scroll-animation if there are pending operations ongoing in parallel.
- Minor coding style cleanups
2011-12-16 23:39:57 +01:00
Peter Penz
ea2ed61cd1 Update the roles if items have been changed
The code "// TODO..." in slotItemsChanged() obviously was not
sufficient ;-)

BUG: 288691
BUG: 288824
BUG: 288921
FIXED-IN: 4.8.0
2011-12-16 22:06:12 +01:00
Peter Penz
f640e48bbe Assure that the general settings are refreshed
This fixes issues where Dolphin must get restarted after changing
a general setting.

BUG: 289131
FIXED-IN: 4.8.0
2011-12-16 19:43:10 +01:00
Peter Penz
d9222cd1ce RenameDialog: Don't disable the OK-button if nothing has been changed
This prevents using the RETURN-key when accidently opening the
renaming dialog.

Thanks to Thomas Murach for pointing this out and providing the patch!

REVIEW: 103414
2011-12-15 16:47:54 +01:00
Script Kiddy
9a11094790 SVN_SILENT made messages (.desktop file) 2011-12-15 09:09:04 +01:00
Frank Reininghaus
dbfba7dfed Start an anchored selection when clicking a selection marker
BUG:200782
FIXED-IN:4.8.0
2011-12-15 00:36:30 +01:00
Peter Penz
065244fac9 Fix descending sort order issue
If the sort order is descending and directories and files are
shown on the same hierarchy level, the sorting was partly wrong.
2011-12-15 00:24:33 +01:00
Peter Penz
756c648f62 Don't show an expansion toggle for locked expansions 2011-12-15 00:05:33 +01:00
Peter Penz
b27aefa798 Fix expansion levels for search results
Force an expansion level of 0 for search results to prevent
showing tabbed child items without parent items.
2011-12-14 23:46:12 +01:00
Peter Penz
0c1ad320d1 Fix filtering issue in combination with expanded items
When items have been expanded they should never get filtered, as
each child item must have a parent item.
2011-12-14 22:59:10 +01:00
Peter Penz
10659d97af Improve private method KFileItemModel::expansionLevelsCompare()
Get rid of the hack to access the m_itemData member for getting
the parent of an item during sorting. ItemData has been extended
by a parent-member which allows a fast and save way to do this.

Sadly this makes the unit-test for expansionLevelsCompare() more
complex and it has been temporary deactivated. I'll take care to
fix this during the next week.
2011-12-14 22:33:34 +01:00
Peter Penz
ee8d9bb4ab Fix comment 2011-12-14 00:03:40 +01:00
Peter Penz
67783026f5 Fix several sort-issues
- Treeview: When sorting descending assure that the parent item is still
  ordered before the child items and not afterwards.
- Treeview: When sorting by other roles than names expansionsLevelCompare()
  had been buggy and resulted in ordering child items below wrong parent
  items.
- General: When sorting by another role than names and the role of
  two items had been equal a case sensitive sorting of the names had
  been done. This has been fixed by using the default name sorting
  as fallback.

BUG: 286726
FIXED-IN: 4.8.0
2011-12-13 23:43:28 +01:00
Michael Drueing
bd9f6e49d3 dolphin: DLLEXPORT is not valid for template class
MSVC tries to import the specialized class from the library, which fails because only the generic version can be exported.
GCC probably silently ignores the export.
2011-12-13 23:07:24 +01:00
Script Kiddy
0fe72f9b8d SVN_SILENT made messages (.desktop file) 2011-12-13 15:50:11 +01:00
Christoph Feck
a390d12de8 Respect style's viewport scrollbar layout policy
REVIEW: 103381
2011-12-12 17:36:19 +01:00
Peter Penz
42adf258b6 Remember sort settings
If the user has changed the sort-role or sort-order by clicking on the view-header of the details-view, the settings have been adjusted to the model but not remembered in the directory settings.
2011-12-11 20:24:38 +01:00
Peter Penz
85d08ac7ed Fix KItemListView::scrollToItem()
Don't let the item be invisible if the header is shown.
2011-12-11 19:34:08 +01:00
Peter Penz
7b679cc956 Scroll the view when the current item has been changed
We need now explicitly to scroll to the item when the current item has been changed, as this is not done automatically in the scope of KItemListView.

BUG: 288745
FIXED-IN: 4.8.0
2011-12-11 19:23:02 +01:00
Script Kiddy
c02daeba1c SVN_SILENT made messages (.desktop file) 2011-12-11 08:36:39 +01:00
Peter Penz
bb6dda6500 Fix issue that icon overlay is missing for links
BUG: 288609
FIXED-IN: 4.8.0
2011-12-10 23:03:38 +01:00
Peter Penz
54713bab0b Show error-message when dropping a folder into itself
Thanks to Janardhan Reddy for the analysis of the issue!

BUG: 283646
FIXED-IN: 4.8.0
2011-12-10 21:50:24 +01:00
Peter Penz
542a80874b Minor fix in copyright header
This class is not based on the ItemViews-NG project.
2011-12-10 21:38:15 +01:00
Peter Penz
cf704d2db6 Support wildcards for the filter
Thanks to Janardhan Reddy for the patch!

BUG: 155986
FIXED-IN: 4.8.0
2011-12-10 21:30:07 +01:00
Peter Penz
780e42533a Resort items when they have been changed
This assures that when renaming an item the sort-position will be adjusted. Thanks to Frank Reininghaus and Janardhan Reddy for the patch and the tests.

BUG: 288311
2011-12-10 12:27:09 +01:00
Peter Penz
54745c440c Fix issue with duplicate items in details view
When expanding an item, collapsing it and expanding it again before the items for the first expanding could be loaded, it was possible that items have been inserted twice into the model.

BUG: 288521
FIXED-IN: 4.8.0
2011-12-09 21:52:31 +01:00
Peter Penz
9a7a77e973 Reloading is not necessary anymore on a settings change
The new view-engine can adjust the properties with the existing items.
2011-12-09 16:54:56 +01:00
Peter Penz
a237e085fc Fix font settings issue
The font settings have been ignored currently because of the transition to the new view-engine.

The patch is based on the work of Janardhan Reddy and has been extended by the helper class ViewModeSettings.

BUG: 288395
FIXED-IN: 4.8.0
2011-12-08 23:10:42 +01:00
Peter Penz
2827b96d98 Fix "show hidden files" issues
Use KFileItemModel instead of KDirLister for toggling the whether
hidden files should be shown. This assures that the signal
KFileItemModel::loadingCompleted() will be emitted.

In the longterm Dolphin should only use the KFileItemModel, so that
the KDirLister instance is used only internally as implementation
detail in KFileItemModel. Although there are only a few cases left
where KDirLister is used instead of KFileItemModel this cleanup
will be postponed to after the 4.8 release...

BUG: 287314
BUG: 288213
FIXED-IN: 4.8.0
2011-12-08 11:13:28 +01:00
Script Kiddy
d5bfe1863c SVN_SILENT made messages (.desktop file) 2011-12-08 09:02:45 +01:00
Peter Penz
1d27156cdc Prevent unwanted item animations (#2)
Use a cleaner approach to prevent item animations when showing
a hidden tab the first time. For Dolphin > 2.0 the tab-code should
be refactored from DolphinMainWindow and encapsulated into an
own module (but well, this is on my TODO-list since KDE SC 4.4...)
2011-12-07 23:49:58 +01:00
Peter Penz
b358e99280 Enable "menu key" functionality
Bring back the functionality that a context-menu is opened if the "menu key" has been pressed. In opposite to Dolphin 1.7 the context-menu is shown above the selected item and not on the (probably unrelated) mouse position.

A new method KItemListView::itemContextRect() has been introduced: The method is now also used as reference for tooltips which fixes the issue that tooltips had a wrong horizontal alignment in the details-view.

BUG: 288366
FIXED-IN: 4.8.0
2011-12-07 23:10:00 +01:00
Peter Penz
5a3e79e4ed Prevent unwanted item animations
When splitting the view or opening a new tab there should not be
any animation of the items due to a wrong initial viewport size.
2011-12-07 21:57:12 +01:00
Peter Penz
c2533317f2 Fix issue of unknown icon-types
If the split-view is used and/or the Folders Panel is activated
it might happen that the "unknown"-icon of an item is shown instead
of the correct icon. The root-cause is that one model might already
have been resolved the MIME-type of a KFileItem while the other
model has not updated the icon yet. As KFileItems are shared the
check whether the MIME-type has been resolved is wrong. As at that
stage it is assured anyhow that the MIME-type is known just
applying the icon-name in any case won't slow down the performance.
2011-12-07 18:39:58 +01:00
Peter Penz
6c29a1d98a Fix icon boundaries issue
The size of the icon boundaries should be as minimal as possible.
The patch for fixing the zooming-issues with the selection resulted
into a minor regression where the icon boundaries might be too large.
This patch remembers the original size of the pixmap to be able
to scale m_iconRect.
2011-12-07 15:34:34 +01:00