Commit graph

482 commits

Author SHA1 Message Date
Peter Penz 640696db72 Places panel: Internal cleanup
Move the bookmark handling into a custom model, so that the
PlacesPanel only contains UI + controller code.
2012-04-25 23:02:40 +02:00
Peter Penz 67f58d5082 Fix search-UI issues in combination with the new places entries
The places-entries for searching revealed some serious issues in
combination with the search-panel. Move the filtering away from
QDockWidget and bring it back below the search-bar.
2012-04-25 02:20:25 +02:00
Peter Penz 007907be20 Bring back basic bookmark support for the Places Panel
The folders-panel signals have been adjusted too for consistency.
2012-04-21 23:29:11 +02:00
Peter Penz ae4d11d918 Prepare view-engine for non-KFileItem usecase
Up to now the view-engine only provided a model-implementation that
supports file-items. The view-engine always had been designed to be able
to work with any kind of model, so now a KStandardItemModel is available.
The plan is to convert the places panel to the new view-engine. It should
be no problem to fix this until the feature freeze - in the worst case
the places-panel code could be reverted while still keeping the
KStandardItemModel changes.
2012-04-21 21:32:42 +02:00
Peter Penz beeb9078f5 Ensure authentication data is cached properly
The attached patch sets the main window on the main directory
lister in DolphinView and KIO jobs in DolphinMainWindow to ensure
that login data for remote protocols such as sftp, ftp are cached
properly for the duration of the application. Otherwise, the end
user is going to end up being unnecessarily re-prompted to enter
password login information.

Thanks to Dawit Alemayehu for the patch!

REVIEW: 104614
FIXED-IN: 4.9.0
2012-04-17 22:21:55 +02:00
Peter Penz b2e54c3a31 Implement inline-renaming for the new view-engine
BUG: 286893
FIXED-IN: 4.9.0
2012-04-17 18:15:12 +02:00
Peter Penz 31ee4085c2 Use KMessageWidget for error- and information-messages
See http://agateau.com/2011/04/21/kde-ux-2011/ for more details.
This simplifies the statusbar in Dolphin a lot and allows to
do a proper eliding in case if status-messages are too long: In
this case a tooltip will show the whole status-message (thanks
to Wolfgang Mader for the initial patch!).

There is still missing some finetuning but the general approach
seems to work quite nice.

BUG: 249638
BUG: 245618
BUG: 146533
FIXED-IN: 4.9.0
2012-04-13 00:11:36 +02:00
Peter Penz 40c71d5ce0 KFileItemModel: interface cleanups
Fix some naming inconsistencies regarding the usage of 'dir' vs.
'directory' vs. 'folder'.
2012-04-11 21:53:45 +02:00
Peter Penz b28a5a6248 Minor API-cleanups for DolphinView 2012-04-11 16:43:11 +02:00
Peter Penz 6c3d9acbc2 KItemViews: Internal directory restructuration
- Move all private headers from the kitemviews-directory into
the 'private' subdirectory.

- Get rid of DolphinDirLister and just use a directory-lister
  internally in KFileItemModel.

- Minor interface-cleanups for signals
2012-04-11 16:08:32 +02:00
Peter Penz d90da9a85e Remove toolbar-spacer if the menu has been disabled
Aligning the control-button to the right of Dolphin has the problem
that sub-menus might be opened on the left of the menu if the Dolphin
window reaches the right of the desktop. So the toolbar-spacer has
been removed and a default label has been applied to the control-button
to increase the target-area for opening the menu.
2012-04-08 00:11:17 +02:00
Peter Penz 5798e081f5 Let additional mouse buttons trigger history navigation
Thanks to Sebastian Dörner for the patch!

REVIEW: 101335
BUG: 181823
FIXED-IN: 4.9
2012-03-19 16:53:53 +01:00
Peter Penz 21a5a890b3 Whitespace cleanups and documentation fixes 2012-02-23 17:28:03 +01:00
Peter Penz e283a9f7d9 Synchronize view-mode settings before the settings dialog gets opened
BUG: 292698
FIXED-IN: 4.8.1
2012-01-30 16:38:24 +01:00
Peter Penz 1d7088b1ad Fix drag & drop issues with non-local URLs
BUG: 292821
BUG: 292355
FIXED-IN: 4.8.1
2012-01-30 12:09:36 +01:00
Peter Penz a4553c9747 Fix regression: Allow dragging items on a tab
BUG: 292505
FIXED-IN: 4.8.1
2012-01-27 22:01:05 +01:00
Peter Penz 329f6009a8 Don't crash when opening a tab with enabled split view
BUG: 292470
FIXED-IN: 4.8.1
2012-01-27 22:01:04 +01:00
Jekyll Wu f3a38fc51a Middle clicking the 'Home' button should open home folder in a new tab
The general idea is to make it behave consistently with other navigating
buttons.

BUG: 278194
FIXED-IN:4.8.0
REVIEW:103659
2012-01-10 20:06:26 +08:00
Peter Penz 1d27156cdc Prevent unwanted item animations (#2)
Use a cleaner approach to prevent item animations when showing
a hidden tab the first time. For Dolphin > 2.0 the tab-code should
be refactored from DolphinMainWindow and encapsulated into an
own module (but well, this is on my TODO-list since KDE SC 4.4...)
2011-12-07 23:49:58 +01:00
Peter Penz 5a3e79e4ed Prevent unwanted item animations
When splitting the view or opening a new tab there should not be
any animation of the items due to a wrong initial viewport size.
2011-12-07 21:57:12 +01:00
Peter Penz 36b8989179 Fix shortcut issue with panels
The KAction instance of the panels is added to the menu instance
now instead of the QDock-actions. It is assured that the state
between the actions gets synchronized. Now it's possible for
the user to apply custom shortcuts and the shortcuts are also
shown in the menu as expected.

CCMAIL: lueck@hube-lueck.de
2011-11-21 11:08:26 +01:00
Peter Penz 3c079ee3f9 Show panel shortcuts in menu 2011-11-20 20:03:59 +01:00
Peter Penz dc8ec1bf01 Fix crash when toggling the menu-bar visibility
Use a queued connection to prevent that the menu
gets hidden during it is still open. Thanks to
Christoph Feck for the hint!

Frank and I could not reproduce the issue in our
environments even when following the steps from
bug 278366, however Christoph's hint sounds sane
and let's hope it works (leaves a bad gut feeling
to "fix" bugs without being able to verify them).

CCBUG: 286822
CCBUG: 278366
FIXED-IN: 4.7.4
2011-11-19 06:51:31 +01:00
Peter Penz 3c77ffe832 Delete obsolete class DolphinSettings 2011-11-06 11:59:26 +01:00
Peter Penz 4fcb5662a7 Fix issues with applying wrong view-mode
- The view properties dialog mixed the details-view with
  the compact-view (#285848).

- The view properties have been reset when applying a
  setting from the "Dolphin Preferences" dialog. The rootcause
  was that the obsolete DolphinSettings class implemented
  the saving in a wrong way because of the recent refactoring
  (will remove this class completely now to prevent such
  issues in future).

BUG: 285848
FIXED-IN: 4.8.0
2011-11-06 09:56:14 +01:00
Peter Penz 90e39e3116 Allow changing shortcuts for the Panel actions
Until now the shortcuts of the Panel actions could not be changed
as they did not show up in the "Configure shortcuts..." dialog.

The patch is based on the work of "SiegeLord" and Fabian Henze
attached to bug 273050.

BUG: 273050
FIXED-IN: 4.8.0
2011-10-10 22:08:23 +02:00
Jaime Torres c9156fdaf9 avoid two possible null pointer dereferences
move the setToolTip lines outside the if(action) inside it.
do not crash if there is no action.
2011-10-09 11:12:22 +02:00
Peter Penz 6551c000fc Context menu cleanups
- Open the context menu on the mouse-press event, not on the
  mouse-release event.
- Provide an explicit position-information and don't use
  QCursor::pos(). This fixes the issue that opening a context-menu
  by the keyboard opens below the cursor.
- Provide different signals in the KItemListController for
  the different context-menu types (item vs. view vs. header).
- Implement turning on/off roles by the header-context-menu.
2011-10-08 21:43:55 +02:00
Chirag Anand 9ca11175a4 Fixed bug for selecting files with --select parameter.
Files selected via --select parameter did not get current item focus.
And if files were deleted while being current item, updating the view
would select the next item instead of the first item in the list.

BUG: 257805
CCMAIL: peter.penz19@gmail.com
CCMAIL: frank78ac@googlemail.com
2011-09-22 18:08:49 +05:30
Peter Penz 8266e456a1 Simplified code for the viewmode settings 2011-09-02 19:49:49 +02:00
Peter Penz e57bef0261 Remove "FirstRun" property
The property got obsoleted by the "Version" property.
2011-08-14 15:31:58 +02:00
Peter Penz d11de1855f Don't enable the search panel per default
Assure that the search panel also stays disabled when updating
from an older Dolphin version.

BUG: 279348
FIXED-IN: 4.7.1
2011-08-13 12:45:14 +02:00
Kai Uwe Broulik 6e76582694 Add missing separators to the "Help" sub-menu of Dolphin's menubar replacement like all KDE apps have
BUG: 276560
2011-08-01 18:26:18 +02:00
Montel Laurent 08d655c2bc normalize signals/slots 2011-07-31 13:33:56 +02:00
Peter Penz f23e9496f3 Merged very early alpha-version of Dolphin 2.0
Dolphin 2.0 will get a new view-engine with the
following improvements:
- Better performance
- Animated transitions
- No clipped filenames due to dynamic item-sizes
- Grouping support for all view-modes
- Non-rectangular selection areas
- Simplified code for better maintenance

More details will be provided in a blog-entry during
the next days.

Please note that the code is in a very
early alpha-stage and although the most tricky parts
have been implemented already very basic things like
drag and drop or selections have not been pushed yet.
Those things are rather trivial to implement but this
still will take some time.
2011-07-30 20:13:41 +02:00
Burkhard Lück 7ca4e389be Add missing actions to report bug + switch language to Help menu in dolphin whithout menubar
Using Dolphin in default mode in master/4.7 whithout menubar the user has no actions to report a bug or switch language.
Add these missing actions the Help menu launched from the toolbar button Configure and control Dolphin.
REVIEW: 101597
2011-06-13 08:26:07 +02:00
Peter Penz 8f6045bac7 Fix position of toolbar-menu
CCBUG: 274495
2011-06-10 16:27:39 +02:00
Sebastian Dörner 0a7c5997df Fix problems with commit 8d789f2626
- fix crash when Ctrl-D-ing in the terminal
 - don't respond to window manager actions, only when the dock itself is
   hidden

Refers to commit 8d789f2626
2011-06-01 21:53:44 +01:00
Peter Penz 2fcd3dd788 Fix position of Dolphin menu with multiple-screens setup
BUG: 274495
FIXED-IN: 4.7.0
2011-05-30 16:33:35 +02:00
Frank Reininghaus 009535d910 Fix build failure if Nepomuk is not available.
Thanks to Krzysztof Nowicki for the patch!
BUG: 274297
2011-05-28 00:17:17 +02:00
Sebastian Dörner 603ec47b8b Don't let hidden terminals prevent unmounting
Previous state: When the terminal is hidden, the cwd is not updated
anymore. If it was on a removable device when hiding, the hidden
terminal might prevent unmounting this device.
This patch fixes that bug by changing the cwd to "/" when hiding the panel.

REVIEW: 101387
BUG: 158264
FIXED-IN: 4.7.0
2011-05-25 22:19:11 +01:00
Peter Penz 371e718ec5 Fix enabled/disabled issue of Search Panel 2011-04-20 22:11:22 +02:00
Peter Penz ae488b1318 Improve usability of Search Panel
If the Search Panel is shown outside the context of the "Find" mode it
will be always enabled and does a global search. Only if the user is in
the "Find" mode and the searching is restricted to the current directory
the Search Panel might get disabled if the current directory is not
indexed. This solves the major usability issue that it was not clear
for the users whether a global or restricted search is done.
2011-04-20 20:09:08 +02:00
Peter Penz d4be11f205 Assure that the startup-settings are applied immediately 2011-04-15 20:53:13 +02:00
Peter Penz de077f8477 Let each DolphinMainWindow run in a custom process
A possible crash in one Dolphin window should not result in crashing
other Dolphin windows. Beside this it also prevents issues with
modal dialogs or notifications.

BUG: 269950
BUG: 206053
BUG: 196034
FIXED-IN: 4.7.0
2011-04-12 20:08:08 +02:00
Peter Penz 2baa9ec45a Optimize alignment of toolbar menu
Try to align the toolbar menu within the Dolphin window to
reduce the cases where the sub-menus overlap with the right
screen border.
2011-04-08 19:38:37 +02:00
Frederik Schwarzer 33635cd40c Add missing i18n call 2011-04-06 00:36:39 +02:00
Peter Penz 5ff682d852 Readd the "go home" action
It got accidently lost during the menu-button changes. Also the
clearStatusBar() calls have been removed as this is handled in the
DolphinViewContainer internally since a long time already.
2011-03-29 18:37:40 +02:00
Peter Penz c80b261505 Update the size of the menu toolbar-item
If the icon size of the toolbar has been changed, the manually added
menu toolbar-item must be updated.
2011-03-27 19:07:14 +02:00
Peter Penz 5647aab1e3 Minor optimizations for the menu toolbar-item 2011-03-27 18:46:08 +02:00