- connect to completed(bool) so that we get notified even in case of a delayed redirect (testcase: http://www.citefutee.com/orienter/rer.php). This was another case of "update all favicons" hanging forever.
CCBUG: 23102
svn path=/trunk/KDE/kdebase/apps/; revision=1119159
(e.g. bookmark toolbar and bookmark sidebar).
Not sure if it should end up in libkonq or libkio...
CCMAIL: hein@kde.org
svn path=/trunk/KDE/kdebase/apps/; revision=1118280
Added unittest for create and delete commands (which exercise the model code too).
Committed from the train to Lyon :)
svn path=/trunk/KDE/kdebase/apps/; revision=1111710
the question was more whether a konqueror instance is running; but all this for a kError
and a "return 1" is overkill anyway.
CCMAIL: raabe@kde.org
svn path=/trunk/KDE/kdebase/apps/; revision=844291
(He didn't have time to make it yesterday and will able to commit it next thursday)
This patch clean up some :
target_link_libraries(kfoo kdeinit_kfoo) which is already done in kde4_add_kdeinit_executable()
macro and use "INSTALL_TARGETS_DEFAULT_ARGS" in other place.
I tested all compile file, all works fine but if there is a pb send me a mail.
CCMAIL: neundorf@kde.org
svn path=/trunk/KDE/kdebase/apps/; revision=795711
* Delete KonqFavIconMgr, was merely a dbus interface wrapper, so generate a org::kde::FavIcon instead. This also spotted a typo in the .xml file...
* Call favicon.downloadHostIcon synchronously instead of with NoBlock; was racy [sounds like a possible kde3 bug too, it was using send instead of call]
Blocking during that method call isn't a big problem anyway, if a real download has to happen it will be delayed via a KIO job anyway (-> the method returns fast).
* One must connect to a dbus signal using a real connect, in unit tests; QSignalSpy isn't enough since it's connect() that triggers some DBUS magic which makes our process listen to the signal. That's quite tricky and unexpected...
svn path=/trunk/KDE/kdebase/apps/; revision=730878
some module compiles with enable-final now)
As discussed with Alex it's not necessary to have program name
into automoc macro
svn path=/trunk/KDE/kdebase/konqueror/; revision=598290
(there was not a dependancy between <name>_final.cpp file and
kcfg file => kfg files were never created)
Not necessary to rebuild all kdelibs just cp kdelibs/cmake/modules/KDE4Macros.cmake <path_kde4>/share/apps/cmake/modules
I ported all kde module (without enable-final argument, it compiles fines (test and program))
Don't try to use enable-final argument for the moment it doesn't compile (but dependancy works)
(I didn't test all compile for the moment I will fix all compile today (without enable-final argument)
kdelibs/kdepimlibs/kdebase/kdeutils compiles fine)
Regards
svn path=/trunk/KDE/kdebase/konqueror/; revision=595170
enable-final argument
(there was not a dependancy between <name>_final.cpp file and
moc generated files => moc files were never created)
Not necessary to rebuild all kdelibs just cp kdelibs/cmake/modules/KDE4Macros.cmake <path_kde4>/share/apps/cmake/modules
I ported and tested all kde module (without enable-final argument, it compiles fines (test and program))
Don't try to use enable-final argument for the moment it doesn't compile (but dependancy works)
Regards
svn path=/trunk/KDE/kdebase/konqueror/; revision=595039
Remaining errors consist only of #include not found (dcopclient.h, dcopref.h, kdatastream.h and kdirnotify_stub.h)
svn path=/trunk/KDE/kdebase/nsplugins/; revision=548395
-cleanup the toplevel CMakeLists.txt a bit
-remove include_directories( CMAKE_CURRENT_SOURCE_DIR CMAKE_CURRENT_BINARY_DIR)
in the subdirs, since this is done now automatically by cmake (the CMAKE_INCLUDE_CURRENT_DIR option
-include_directories(KDE4_INCLUDES) in the toplevel CMakeLists.txt, so it
doesn't have to be done in every subdir
Alex
svn path=/trunk/KDE/kdebase/konqueror/; revision=539914
${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR} in each and every file anymore [only when subdirs might depend on that].
Also ran a script which makes sure that ${KDE4_INCLUDE_DIR} and ${QT_INCLUDES} are added -last-,
so that installed headers are not preferred over (possibly more uptodate) local headers.
svn path=/trunk/KDE/kdebase/konqueror/; revision=521887
BE CARREFULL: Don't try to compile it for the moment (in progress)
Don't use kdelibs trunk for compile it (there is not again test to disable
compile when we compile with kdelibs trunk)
For the moment there was a lot of missing test etc.
I commit it just to allow to lose my changes if there is a pb on my HD.
I will sync cmake from kdelibs trunk to kdelibs-snapshot.
I hope to fix compile today or tomorrow.
CCMAIL: neundorf@kde.org
For the futur we must sync kdelibs/cmake/* to kdelibs-snapshot
to compile all the time with kdelibs-snapshot
svn path=/trunk/KDE/kdebase/konqueror/; revision=514380
