Commit graph

376 commits

Author SHA1 Message Date
Weng Xuetian
5d75c7afc5 Merge remote-tracking branch 'origin/KDE/4.10' 2013-03-16 00:47:11 -04:00
Weng Xuetian
61ea42b353 use plain text for information panel
REVIEW: 109129
BUG: 315693
CCBUG: 262464
2013-03-16 00:43:22 -04:00
Frank Reininghaus
31b0b565fe Merge remote-tracking branch 'origin/KDE/4.10' 2013-03-15 00:28:40 +01:00
Frank Reininghaus
4bcda6c7e7 Prevent accidental deletion of home directory in Terminal Panel
The protection against unwanted execution of "rm -rf" when changing the
directory while entering the command did not work if there was never any
automatic "cd" command sent to the terminal before.

This patch ensures that Terminal Panel's member m_clearTerminal is
false after the initialization of the panel, such that the protection is
effective after that.

BUG: 316300
FIXED-IN: 4.10.2
REVIEW: 109431
2013-03-15 00:12:49 +01:00
Frank Reininghaus
cc1455c0e6 Merge remote-tracking branch 'origin/KDE/4.10'
Conflicts:
	dolphin/src/tests/kfileitemmodeltest.cpp
	lib/konq/konq_operations.cpp
2013-02-19 15:45:44 +01:00
Frank Reininghaus
518b53feb4 Fix crash when clicking an action in context menu for a removed device
Devices can be added and removed while the context menu is open.
Sfter an action has clicked that needs to access a device, we therefore
have to check if its position in the model has changed, and more
importantly, if it is still there at all in order to prevent a crash.

BUG: 315298
FIXED-IN: 4.10.1
REVIEW: 108989
2013-02-18 23:58:31 +01:00
Frank Reininghaus
ced9de5b82 Merge remote-tracking branch 'origin/KDE/4.10' 2013-02-10 19:27:21 +01:00
Aniket Anvit
85ed71eb30 Apply changes of the KGlobalSettings::singleClick() setting immediately
Fixes a regression introduced by commit
7a364cbf48.

Patch reviewed and pushed by Frank Reininghaus.

BUG: 313342
FIXED-IN: 4.10.1
2013-02-05 19:58:06 +01:00
Weng Xuetian
ef248162d0 Merge branch 'KDE/4.10' 2013-01-27 14:13:04 -05:00
Weng Xuetian
2045a64ec6 escape the existing text instead of set to plain text
@info indicates it's rich text and will be added <html> tag by kdelibs,
so just escape the text that will be set to label for KDE/4.10

REVIEW: 108584
BUG: 313992
2013-01-27 14:09:12 -05:00
Luca Beltrame
ee2742f889 Merge remote-tracking branch 'origin/KDE/4.10' 2013-01-16 23:42:25 +01:00
Kai Uwe Broulik
7c43fce8bf Use proper IconSize for PlacesItemEditDialog's KIconButton
REVIEW: 108443
2013-01-16 22:54:32 +01:00
Kai Uwe Broulik
d7373195f0 Fix information panel interpreting html tags
Only fixes the most obvious file name, the other entries in the table
probably have to be fixed in the FileMetaDataWidget.
REVIEW: 108307
BUG: 262464
(cherry picked from commit 3d7d900d28)
2013-01-09 22:15:56 +01:00
Kai Uwe Broulik
1877eb74e8 Fix information panel interpreting html tags
Only fixes the most obvious file name, the other entries in the table
probably have to be fixed in the FileMetaDataWidget.
REVIEW: 108307
BUG: 262464
2013-01-09 22:10:04 +01:00
Emmanuel Pescosta
804d8119b3 Fix Bug 233335 - Wrong icons selected after pasting files and renaming them (because there exists items with it's names
Fixed the "same" buggy behavior when dropping files/folders

Select also putted files (PUT operation - SimpleJob) - e.g. Paste content from clipboard

BUG: 233335
REVIEW: 107351
2013-01-09 15:16:30 +01:00
Vishesh Handa
24c9bc6ce7 Dolphin: Make Nepomuk Support Optional
Use the KFileMetadataWidget if Nepomuk is not present.

REVIEW: 108236
2013-01-07 19:59:23 +05:30
Vishesh Handa
bf202f3931 Dolphin Information Panel: Use Nepomuk2::FileMetadataWidget
Instead of the KFileMetadataWidget. The Nepomuk widget is just a copy of
the KFileMetadataWidget which utilizes Nepomuk2.
2013-01-02 16:35:37 +05:30
Luc Menut
a39ba0acd8 Use correct value for autostart setting of Service-nepomukfileindexer
Fixes the problem that the "Recently accessed" entries in the Places
Panel might not be shown when using the default setup.

BUG: 310770
FIXED-IN: 4.10 Beta 2
REVIEW: 107464
2012-11-27 17:32:00 +01:00
Frank Reininghaus
15faff457d Merge remote-tracking branch 'origin/KDE/4.9' 2012-11-05 22:12:45 +01:00
Frank Reininghaus
07721cf764 Do not use a hardcoded size for the buttons in the Information panel
Thanks to Kai Uwe Broulok and Jekyll Wu for the investigation!

BUG: 309498
FIXED-IN: 4.9.4
2012-11-04 14:39:49 +01:00
Frank Reininghaus
c6eb4866d8 Use the standard sizes from KIconLoader, rather than hardcoded sizes. 2012-11-04 10:33:49 +01:00
Frank Reininghaus
6f8060fc6d Add an "Icon Size" submenu to the context menu of the Places Panel
FEATURE: 307475
FIXED-IN: 4.10.0
CCBUG: 301959
2012-11-01 00:58:32 +01:00
Alex Fiestas
951dbd6d67 Removed customm setText for mtp devices and check for kio_mtp
We are already checking if kio_mtp is installed when we build the
predicate so we don't need to check if it is installed again.

Also, the fix for "Showing the product as a name for some kind of
massive storage" will have to be delayed to 4.9.4, so removing this.
2012-11-01 00:28:18 +01:00
Frank Reininghaus
1353c92cce Fix some indentation issues 2012-10-30 08:25:21 +01:00
Emmanuel Pescosta
ecdb0c3f58 Extended/Completed Frank's commit 7ca682fe90.
* Implemented Rename-Inline-Option in Settings Dialog
* Re-enable renaming items with the rename dialog in Folderview-Panel

BUG: 306705
REVIEW: 107072
2012-10-28 20:12:04 +01:00
Alex Fiestas
996fe25208 Show MTP devices in case support for it is installed
Basically adds a conditional that in case that mtp kioslave is installed
devices with MTP are added to the predicated.
REVIEW: 106651
(cherry picked from commit a09a237950)
2012-10-24 01:22:31 +02:00
Alex Fiestas
434a6cf0a7 Show MTP devices in case support for it is installed
Basically adds a conditional that in case that mtp kioslave is installed
devices with MTP are added to the predicated.
REVIEW: 106651
2012-10-24 01:21:02 +02:00
Weng Xuetian
1c6d0c316a use better icon for timeline:/ in places
REVIEW: 106874
2012-10-16 07:55:00 -04:00
Emmanuel Pescosta
a9b04801db Port Dolphin from Nepomuk to Nepomuk2 according to the Nepomuk2Port mini guide on techbase - http://techbase.kde.org/Projects/Nepomuk/Nepomuk2Port
REVIEW: 106825
2012-10-15 21:46:59 +02:00
Dawit Alemayehu
b7a8327c30 Merge branch '4.9' 2012-09-27 17:48:56 -04:00
Vishesh Handa
9b01d1bcc1 Dolphin Places: Only show file results in Nepomuk Queries
Dolphin is a file manager, and shouldn't be concerned with non-file
resources like notes, contacts and other stuff.

Use FileQuery instead of Query.

This also results in a faster queries. With File Queries Nepomuk can
perform some internal optimizations.

BUG: 306029
REVIEW: 106274

Cherry-picked from 6892d39d29
2012-09-28 02:37:35 +05:30
Frank Reininghaus
831251d0f3 Add a new config option for the icon size in the Places Panel
To change the icon size in the Places Panel to, e.g., 60 pixels, add
the following lines to $KDEHOME/share/config/dolphinrc :

[PlacesPanel]
IconSize=60

A value of -1 means that the standard "Small" size should be used
(which has been the default before this commit).

It is planned to add an "Icon Size" submenu to the context menu of the
Places Panel in KDE 4.10, but we cannot do this in the 4.9 branch
because of the string freeze.

FIXED-IN: 4.9.2
BUG: 301959
2012-09-27 08:12:02 +02:00
Luca Beltrame
f1b822d926 Merge branch 'KDE/4.9'
Conflicts:
	konq-plugins/dirfilter/dirfilterplugin.cpp
	konq-plugins/dirfilter/dirfilterplugin.h
2012-09-21 10:55:08 +02:00
Emmanuel Pescosta
904d7b0701 Restore old behavior: Navigating by double-clicking in folder panel (Double-Click - show folder content and expand folder)
BUG: 295573
REVIEW: 106497
FIXED-IN: 4.9.2
2012-09-20 17:56:32 +02:00
Emmanuel Pescosta
4855b582b4 Fixes Bug 304878 - Dolphin shows "ghost" folders in places after autofs umount nfs shares
BUG: 304878
REVIEW: 106456
FIXED-IN: 4.9.2
2012-09-20 17:56:00 +02:00
Emmanuel Pescosta
580bcae62c Fixes Bug 293200 - Drag&drop files in dolphin doesnt preserve origin
Patch 106381 Comment #3:
When "Open folders during drag operations" is enabled, two things happen, both in the DolphinView and in the Folders Panel:

1) When hovering a folder that can be expanded (this is the case for folders with sub-folders in the Folders Panel and in the DolphinView if in Details View mode), toggle its "expanded" state.
2) When hovering a folder that can not be expanded (i.e., a folder without sub-folders or any folder in Icons or Compact View), open this folder in the DolphinView via the KItemListController's itemActivated(int) signal.

The bug described in bug 293200 comment 3 is that 1) is always wanted, but 2) is not wanted for the Folders Panel.

BUG: 293200
FIXED-IN: 4.9.2
2012-09-19 19:00:52 +02:00
Frank Reininghaus
40c513d477 Prevent unwanted URL changes when using the Terminal Panel
The root cause of the problem was that TerminalPanel's member
m_konsolePartCurrentDirectory, which is used to determine in
TerminalPanel::sendCdToTerminal(QString& dir) if the Konsole part's
directory is aleady 'dir', such that issuing the 'cd' command is not
needed, was updated too late, namely when the part's
currentDirectoryChanged(QString) signal was received, which may be up
to one second after the 'cd' command.

When changing the directory from "dir1" to "dir2" and going back to
the "dir1" in less than one second (either by using the 'Back' action
or by activating a tab which still had "dir1" open), the 'cd dir1'
command was therefore suppressed because the Terminal Panel still
thought that "dir1" was the current directory in the part. However,
the directory of the part was actually "dir2", and when the
currentDirectoryChanged(QString) signal was received from the part, the
view's URL was set to "dir2" as well.

BUG: 306349
BUG: 304838
FIXED-IN: 4.9.2
2012-09-19 09:28:35 +02:00
Emmanuel Pescosta
5fbc010179 Mount unmounted devices, when a file is dropped upon it in places-panel.
BUG: 176277
REVIEW: 106072
FIXED-IN: 4.9.2

(cherry picked from commit 824fa6a437)
2012-09-11 20:23:28 +02:00
Emmanuel Pescosta
bdfd49e7e7 Mount unmounted devices, when a file is dropped upon it in places-panel.
BUG: 176277
REVIEW: 106072
2012-09-11 20:17:56 +02:00
Emmanuel Pescosta
e280e7f68c Fixes Bug 242007 - "Open Folder during Drag operation" cannot go into different partition using "Places Panel"
BUG: 242007
REVIEW: 106380
2012-09-11 20:09:01 +02:00
Frank Reininghaus
f9ba9a7236 Use a better icon for recently accessed items, part 2
I had missed one places where the incorrect icon was used in my
previous commit d7e7ca53bb.

BUG: 304323
FIXED-IN: 4.9.2
2012-09-11 19:25:20 +02:00
Vishesh Handa
0016f150ae Dolphin Places: Only show file results in Nepomuk Queries
Dolphin is a file manager, and shouldn't be concerned with non-file
resources like notes, contacts and other stuff.

Use FileQuery instead of Query.

This also results in a faster queries. With File Queries Nepomuk can
perform some internal optimizations.

BUG: 306029
REVIEW: 106274
2012-08-30 17:33:11 +05:30
Emmanuel Pescosta
e7793132e8 Select the correct item in places-panel, when a directory is opened.
BUG: 304541
REVIEW: 106074
FIXED-IN: 4.9.1
(cherry picked from commit 1ec8de2c61)
2012-08-23 22:04:44 +02:00
Emmanuel Pescosta
9a8ffbe1d0 Select the correct item in places-panel, when a directory is opened.
BUG: 304541
REVIEW: 106074
2012-08-23 21:42:08 +02:00
Emmanuel Pescosta
15b687a270 Fix wrong text color in Places Group Header. Use QPalette::Window for base color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient.
BUG: 303133
FIXED-IN: 4.9.1
(cherry picked from commit b3c3da9851)
2012-08-15 15:04:55 +02:00
Emmanuel Pescosta
b039392f34 Fix wrong text color in Places Group Header. Use QPalette::Window for base color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient.
BUG: 303133
2012-08-14 22:02:24 +02:00
Emmanuel Pescosta
ab61d9d3ba Fix wrong text color in places and in folders panel.
FIXED-IN: 4.9.1
REVIEW: 105832
BUG: 303133
2012-08-13 19:10:50 +02:00
Emmanuel Pescosta
220d0d522d Fix wrong text color in places and in folders panel.
FIXED-IN: 4.9.1
REVIEW: 105832
BUG: 303133
2012-08-13 18:40:43 +02:00
Frank Reininghaus
e4d816a6aa Use a better icon for recently accessed items in the Places Panel
The problem with the icon "package_utility_time" that has been used
before was that it is not available on all distros. The new icon
"chronometer" should be available on every KDE install.

Thanks to Elias Probst for suggesting the new icon - I'm not that
familiar with the icons provided by KDE myself.

CCBUG: 304323
(cherry picked from commit d7e7ca53bb)
2012-08-09 23:55:21 +02:00
Frank Reininghaus
bed9699414 Follow-up to d7e7ca53bb - use correct icon
I overlooked that "actions/" is not part of the icon name. Just
rebuilding and re-running Dolphin did not reveal this issue, it seems
that the old icon "package_utility_time" was still cached somewhere.

I hope that it really works on all distros now.

CCBUG: 304323
2012-08-09 23:52:51 +02:00