Commit graph

5391 commits

Author SHA1 Message Date
Elvis Angelaccio
5413025f0b Merge branch 'Applications/18.04' 2018-04-05 23:29:29 +02:00
Elvis Angelaccio
e9192259f6 Improve QDialogButtonBox::Yes override text
Summary:
We are asking the users whether they are sure they want to quit.

But the "Quit" button can be ambiguous (am I quitting dolphin or just
this dialog?). If we use a "Quit Dolphin" button instead, that clearly
shows what will happen after triggering the action.

Test Plan: Close dolphin while multiple tabs are open.

Reviewers: #dolphin

Differential Revision: https://phabricator.kde.org/D11892
2018-04-05 23:28:58 +02:00
Elvis Angelaccio
30349ef1bd [RenameDialog] Fix crash when renaming single items
Summary:
`m_spinBox` is initialized only when renaming multiple items.

This commit restores the single-item rename logic which was wrongly
removed by commit c5eb4e3116.

BUG: 392743
FIXED-IN: 18.03.90

Test Plan: Disable inline renaming and try to rename single or multiple items (and also to undo the jobs).

Subscribers: #dolphin

Differential Revision: https://phabricator.kde.org/D11972
2018-04-05 23:15:50 +02:00
Nathaniel Graham
993c47f309 Show folder previews for items that have a Places Panel entry
Summary:
informationpanelcontent.cpp currently has an explicit check for whether or not a URL has a Places panel entry, and if it does, no folder preview is generated. It's not clear why this is done, but it was reported as a bug: https://bugs.kde.org/show_bug.cgi?id=392621. Removing the logic fixes the bug.

BUG: 392621
FIXED-IN: 18.08.0

Test Plan:
Before:
{F5782793}

After:
{F5782794}

Detailed test procedure:
- Open the Information Panel
- Turn on previews
- Put some pictures in ~/Pictures
- Hover over it and see that the Information Panel shows a preview of its contents
- Add ~/Pictures to the Places panel
- Hover over it again and see that previews are no longer displayed
- Apply the patch and restart Dolphin
- Hover over it once more and see that there are now previews, yay!

Reviewers: #dolphin, markg, elvisangelaccio

Reviewed By: markg, elvisangelaccio

Subscribers: markg, broulik

Differential Revision: https://phabricator.kde.org/D11894
2018-04-03 16:39:32 -06:00
Antonio Rojas
eab70b2ac4 Merge branch 'Applications/18.04' 2018-04-03 22:50:29 +02:00
Antonio Rojas
386a862de4 Initialize m_konsolePartMissingMessage
Otherwise it just crashes when trying to open the terminal panel

BUG: 392660
Differential Revision: https://phabricator.kde.org/D11904
2018-04-03 22:48:25 +02:00
l10n daemon script
f4e2593aa7 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-04-03 07:12:29 +02:00
l10n daemon script
aee551e80b SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-04-03 05:25:54 +02:00
Christoph Feck
4bd6e9fb13 GIT_SILENT Upgrade KDE Applications version to 18.03.90. 2018-04-02 21:18:14 +02:00
Julian Schraner
1441fefc07 Split Image Size into Width/Height
Summary:
This patch splits the single property "Image Size" into "Width" and "Height", providing more fine-tuned control for power users.

FEATURE: 374559

Test Plan:
- Sorting works correctly
- No real change, only exposed differently

Reviewers: #dolphin, elvisangelaccio, ngraham

Reviewed By: #dolphin, elvisangelaccio, ngraham

Subscribers: ngraham, elvisangelaccio

Differential Revision: https://phabricator.kde.org/D11816
2018-04-01 11:27:44 -06:00
Elvis Angelaccio
6f3b0e3d00 Fix detaching 2018-04-01 12:30:41 +02:00
Elvis Angelaccio
763933977b Use QHash rather than QMap
As recommended by the clazy qmap-with-pointer-key check.
2018-04-01 12:14:34 +02:00
Elvis Angelaccio
d0503ae8e0 Use rightRef() instead of right()
As recommended by the clazy qstring-ref check.
2018-04-01 12:08:23 +02:00
Yuri Chornoivan
4913493551 Fix minor typos 2018-03-30 08:19:37 +03:00
Scott Harvey
e0f7fe87bd Fix alignment of icons in Places panel and Compact view mode
Summary:
Adjust calculation of icon pixmap Y value; now based off center of text label bounding rectangle. Previously, icons appeared top-aligned when text size was larger than icon size.

Centering is done by obtaining the center point of the text frame (`m_textRect.center().y()`) and setting the top `Y` point of the icon to one-half of the scaled icon height (`m_scaled_PixmapSize.height()`)  Division is done by `2.0`, to ensure calculations are done with floating-point math, in keeping with `QPointF`, which returns floating-point values.

Also includes an adjustment named `midlineShift` (contributed by @zzag), which takes into account the font's midline in respect to the center of the text frame. Certain fonts (i.e. Noto Sans) can have a slightly offset midline, resulting in imperfect alignment of the icon. This small adjustment resolves that potential issue.

See before and after screenshots.
{F5764918}
Before, showing misalignment (with and without debugging wireframes)

{F5764920}
After, showing correction

BUG: 390771

Test Plan:
-- Compile Dolphin with patch
-- Increase system font size by several points (i.e. 15pt)
-- Check that Places panel icons remain centered with the text label
-- Select Compact View mode
-- Adjust icon size slider to minimum
-- Ensure that icons also remain centered in file listing
-- Check several combinations of icon size & font size to ensure centering is consistent

Reviewers: #dolphin, ngraham, cfeck, elvisangelaccio

Reviewed By: #dolphin, ngraham, elvisangelaccio

Subscribers: zzag, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D11650
2018-03-29 16:29:51 -06:00
Elvis Angelaccio
eed695710d Merge branch 'Applications/18.04' 2018-03-29 22:33:37 +02:00
Elvis Angelaccio
8d1cc850de Fix enum-compare-switch clang warnings
We were comparing a value of type `KStandardItemListView::ItemLayout`
with values of type `KStandardItemListWidget::Layout`.
2018-03-29 22:29:56 +02:00
Burkhard Lück
e91e18ae36 Update dolphin docbook to 18.04
proofread + update
bump date + releaseinfo
add missing option + new shortcuts

Differential Revision: https://phabricator.kde.org/D11724
2018-03-29 18:47:28 +02:00
Kai Uwe Broulik
40f9cfd519 [KItemListView] Check if KItemListStyleOption actually changed before emitting a change
This avoids work being done when it doesn't need to be.
For instance, the preview generator waits for everything to have settled using a 200ms timer before generating a preview.
This timer fired also in response to onStyleOptionChanged and needlessly delayed preview generation when navigating between folders
despite the style option (e.g. icon size, view mode) not having changed.

Differential Revision: https://phabricator.kde.org/D11481
2018-03-29 09:21:17 +02:00
Kai Uwe Broulik
1859d6455d [DolphinContextMenu] Fix excluding ourself from Open With menu
The desktop file name changed to org.kde.dolphin a long time ago. To avoid this breaking again, just use qApp->desktopFileName()

BUG: 391997

Differential Revision: https://phabricator.kde.org/D11540
2018-03-24 11:24:24 +01:00
Nathaniel Graham
49e0315584 Merge branch 'Applications/18.04' 2018-03-22 06:52:46 -06:00
Nathaniel Graham
f728d72864 Fix missing entries in context menu for links
Summary: https://cgit.kde.org/dolphin.git/commit/?id=86f4fcb8cd574f6d886627fc5e01c9edfc84e977 introduced a regression: the context menu for links no longer shows various items that were gated behind being a directory. However, a link can be both a link and a directory, from KIO's perspective. This patch resolves the issue.

Test Plan:
- Context menus for files, folders, and file links are unchanged.
- The missing context menu items for folder links have returned: {F5761809}

I should have tested that patch better, and for that I apologize and offer to fix this regression here. I will endeavor to up my reviewing game.

Reviewers: rominf, michaelh, #dolphin, rkflx

Reviewed By: rominf, rkflx

Subscribers: rkflx

Differential Revision: https://phabricator.kde.org/D11562
2018-03-22 06:52:11 -06:00
Kai Uwe Broulik
b2ff54be3b [DolphinContextMenu] Fix excluding ourself from Open With menu
The desktop file name changed to org.kde.dolphin a long time ago. To avoid this breaking again, just use qApp->desktopFileName()

BUG: 391997

Differential Revision: https://phabricator.kde.org/D11540
2018-03-21 15:53:59 +01:00
David Faure
c9acf79152 Merge branch 'Applications/18.04' 2018-03-21 15:34:36 +01:00
David Faure
1da0983c42 Fix compilation with -DQT_NO_URL_CAST_FROM_STRING 2018-03-21 15:30:51 +01:00
Albert Astals Cid
ffec5f17d3 GIT_SILENT Upgrade KDE Applications version to 18.07.70. 2018-03-19 23:50:00 +01:00
Albert Astals Cid
f536d396f9 GIT_SILENT Upgrade KDE Applications version to 18.03.80. 2018-03-19 23:35:33 +01:00
Kai Uwe Broulik
7cee23157f Introduce singleton for KFilePlacesModel
There are various places where Dolphin created a new KFilePlacesModel which would then query all storage devices and do other expensive work.

Differential Revision: https://phabricator.kde.org/D11283
2018-03-19 09:57:24 +01:00
Roman Inflianskas
6f05c66cc0 Add "Show Target" into symlink context menu and file menu
Summary:
Add "Show Target" into symlink context menu and file menu

FEATURE: 215069

Reviewers: ngraham, elvisangelaccio

Reviewed By: ngraham, elvisangelaccio

Subscribers: rkflx, ngraham, elvisangelaccio, markg, #dolphin

Differential Revision: https://phabricator.kde.org/D10990
2018-03-18 15:08:36 +03:00
Roman Inflianskas
eb68fae15c Show "Empty Trash" button inside trash directory
Summary:
Show "Empty Trash" button inside trash directory.

FEATURE: 163306

Test Plan: {F5734949}

Reviewers: ngraham, rkflx, markg, elvisangelaccio

Reviewed By: ngraham, markg, elvisangelaccio

Subscribers: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D10804
2018-03-18 13:46:06 +03:00
Roman Inflianskas
86f4fcb8cd Add "Open symlink destination folder" into symlink's context menu
Summary:
This is not complete. I'm wondering about "Open symlink destination folder in new tab/window".

Feature wants also "Copy symlink destination". I dislike this, because then it's good to have "Cut symlink destination" and that's too much.

FEATURE: 215069

Reviewers: #dolphin, ngraham

Reviewed By: #dolphin, ngraham

Subscribers: rkflx, ngraham, elvisangelaccio, markg, #dolphin

Differential Revision: https://phabricator.kde.org/D10990
2018-03-14 22:02:30 +03:00
l10n daemon script
6ab76d791c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-03-13 05:14:09 +01:00
Roman Inflianskas
68a924af05 Show a message if Konsole part is not installed
Summary:
Show a message if Konsole part is not installed

BUG: 371822
FIXED-IN: 18.04.0

{F5749731}

Reviewers: ngraham, progwolff, elvisangelaccio

Reviewed By: ngraham, progwolff, elvisangelaccio

Subscribers: rkflx, ngraham, elvisangelaccio, broulik, progwolff, #dolphin

Differential Revision: https://phabricator.kde.org/D11118
2018-03-11 20:41:54 +03:00
Roman Inflianskas
c0797e8ade Update trash icon after restore operation
Summary:
After restoring all the files from the trash, the trash icon remain 'full'. This patch fixes this.

BUG: 252483

Reviewers: elvisangelaccio

Reviewed By: elvisangelaccio

Subscribers: elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D11216
2018-03-11 19:47:31 +03:00
Elvis Angelaccio
69239fdf41 Removed unused variables spotted by clazy 2018-03-11 17:14:07 +01:00
Elvis Angelaccio
b46d57d5fb Align minimum ECM and KF5 versions
It doesn't make sense to require 1.6.0 which is years old.
2018-03-11 17:09:11 +01:00
Elvis Angelaccio
4aff36d148 Add missing this parameter
Forgot to mention it while reviewing D11012.
2018-03-11 17:07:20 +01:00
Roman Inflianskas
f16fbcba4e Add Trash (empty, isEmpty, emptinessChanged)
Summary: Add `Trash` class to handle all trash operations.

Reviewers: elvisangelaccio, markg, ngraham

Reviewed By: elvisangelaccio, markg, ngraham

Subscribers: ngraham, markg, rkflx, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D11012
2018-03-11 17:32:33 +03:00
Roman Inflianskas
0c9343d614 Fix some compile warnings
Reviewers: markg, elvisangelaccio

Reviewed By: markg, elvisangelaccio

Subscribers: chehrlic, rkflx, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D10995
2018-03-10 18:07:47 +03:00
Kai Uwe Broulik
8c1455f96f Fix build without Baloo
That include IS used
2018-03-07 08:55:04 +01:00
Elvis Angelaccio
2523442d4d Revert "Fix some compile warnings"
This reverts commit 533f050855.

D10995 has not been approved.
2018-03-05 21:56:15 +01:00
Roman Inflianskas
48b58f830a Remove unused #include
Summary: I used CLion inspection to hunt all unused #include

Reviewers: #dolphin, elvisangelaccio, markg

Reviewed By: #dolphin, elvisangelaccio, markg

Subscribers: bcooksley, markg, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D10985
2018-03-04 21:00:47 +03:00
Roman Inflianskas
533f050855 Fix some compile warnings
Reviewers: #dolphin, markg

Reviewed By: markg

Subscribers: elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D10995
2018-03-04 10:27:31 +03:00
Roman Inflianskas
848abc5922 Remove unused #include
Summary: I used CLion inspection to hunt all unused #include

Reviewers: #dolphin, elvisangelaccio, markg

Reviewed By: #dolphin, elvisangelaccio, markg

Subscribers: markg, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D10985
2018-03-03 17:08:01 +03:00
Roman Inflianskas
32bd8efc7f Modernize the syntax of shortcuts
Reviewers: #dolphin, markg

Reviewed By: markg

Subscribers: markg, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D10986
2018-03-03 16:44:29 +03:00
Roman Inflianskas
436ad965e9 Add an option to confirm trash emptying into settings
Summary:
Add an option to confirm trash emptying into settings.

BUG: 340572

Reviewers: #dolphin, ngraham, markg

Reviewed By: #dolphin, ngraham, markg

Subscribers: markg, ngraham, rkflx, #dolphin

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D10968
2018-03-03 08:46:55 +03:00
Roman Inflianskas
bf0d259ae5 Add default shortcut "/" for opening filter panel
Summary:
Add default shortcut "/" for opening filter panel.

FEATURE: 156381

Reviewers: #dolphin, ngraham

Reviewed By: #dolphin, ngraham

Subscribers: ngraham, #dolphin

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D10961
2018-03-03 08:38:03 +03:00
l10n daemon script
e46421bfee SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-03-03 05:23:49 +01:00
Nathaniel Graham
b95cc59091 Also use standard keyboard shortcut for "show/hide hidden files"
Summary:
Use Ctrl+H as another keyboard shortcut to show and hide hidden files, as it is already the standard used in other GTK-based Linux file managers (Nautilus, Nemo, Caja, Thunar, Pantheon Files). This doesn't replace any existing shortcuts, so existing KDE users' muscle memory is retained.

FEATURE: 390527
FIXED-IN: KDE Applications 17.12.3

Test Plan:
- Ctrl+H now shows and hides hidden files
- Alt+. still works to do the same
- F8 still works to do the same
- Toolbar button still changes state appropriately when any of the three shortcuts are used

Reviewers: #dolphin, elvisangelaccio

Reviewed By: elvisangelaccio

Subscribers: emateli, elvisangelaccio

Differential Revision: https://phabricator.kde.org/D10558
2018-02-18 15:02:07 -07:00
Kai Uwe Broulik
ae67f99195 [Information Panel] Adjust painting icons for high dpi scaling
Instead of creating our own KIconLoader (which takes ~5ms here) just use QIcon::fromTheme which already does everything right.

BUG: 390488

Differential Revision: https://phabricator.kde.org/D10532
2018-02-15 13:37:08 +01:00