Commit graph

80 commits

Author SHA1 Message Date
Frank Reininghaus
a3b5656a16 Remove duplicated slot
The slot DolphinViewContainer::focusView(), introduced in commit
2f0114730d, is actually unnecessary
because DolphinViewContainer::requestFocus() provides the same
functionality already.
2013-03-07 22:58:48 +01:00
Jens Rutschmann
0fee7ff266 Return the focus from the filter bar to the view if Enter is pressed
BUG: 297140
FIXED-IN: 4.11.0
REVIEW: 109020
2013-02-19 22:43:55 +01:00
Weng Xuetian
2af331b42c Automatically set url location bar to non-editable when focus out
BUG: 157593
REVIEW: 107748
2012-12-29 12:49:51 -05:00
Emmanuel Pescosta
3535a20207 Fix Bug 304299 - Dolphin launches multiple instances of a program when multiple files are selected
BUG: 304299
REVIEW: 107305
2012-12-13 22:54:09 +01:00
Emmanuel Pescosta
c503452d56 Fix Bug 153984 - Clicking cancel on the authentication dialog for fish/sftp/ftp kioslave gets dolphin stuck on "Loading folder"
BUG: 153984
REVIEW: 107116
2012-10-29 20:54:53 +01:00
Ivan Čukić
8268c0813a Dolphin reporting opened locations to activity manager 2012-08-15 08:22:30 +02:00
Peter Penz
e9463ffe2a Fix regression: Open file if entering it in the URL-navigator
The regression has been introduced when hiding the DolphinDirLister
inside KFileItemModel. Now the signal urlIsFileError() gets forwarded
to the container again where the file will be opened.

BUG: 301757
FIXED-IN: 4.9.0
2012-06-13 15:18:21 +02:00
Peter Penz
a2674f5184 Provide a default name when adding a search query to the places panel
BUG: 300430
FIXED-IN: 4.9.0
2012-06-02 15:47:17 +02:00
Peter Penz
4fad8f8f53 Reimplement search-filters
BUG: 270721
BUG: 280377
FIXED-IN: 4.9.0
2012-05-10 22:45:12 +02:00
Frank Reininghaus
12c239ae14 Update the view when changing the directory using 'cd' in the terminal
Thanks to Jekyll Wu for helping to implement this feature!

FEATURE: 156732
FIXED-IN: 4.9.0
2012-04-26 08:31:59 +02:00
Peter Penz
67f58d5082 Fix search-UI issues in combination with the new places entries
The places-entries for searching revealed some serious issues in
combination with the search-panel. Move the filtering away from
QDockWidget and bring it back below the search-bar.
2012-04-25 02:20:25 +02:00
Peter Penz
1ea09b24e1 Minor statusbar fixes
- Don't show information messages as KMessageWidget
- Assure that a set text in a statusbar will be shown for at least
  one second
2012-04-15 11:46:07 +02:00
Peter Penz
31ee4085c2 Use KMessageWidget for error- and information-messages
See http://agateau.com/2011/04/21/kde-ux-2011/ for more details.
This simplifies the statusbar in Dolphin a lot and allows to
do a proper eliding in case if status-messages are too long: In
this case a tooltip will show the whole status-message (thanks
to Wolfgang Mader for the initial patch!).

There is still missing some finetuning but the general approach
seems to work quite nice.

BUG: 249638
BUG: 245618
BUG: 146533
FIXED-IN: 4.9.0
2012-04-13 00:11:36 +02:00
Peter Penz
40c71d5ce0 KFileItemModel: interface cleanups
Fix some naming inconsistencies regarding the usage of 'dir' vs.
'directory' vs. 'folder'.
2012-04-11 21:53:45 +02:00
Peter Penz
b28a5a6248 Minor API-cleanups for DolphinView 2012-04-11 16:43:11 +02:00
Peter Penz
6c3d9acbc2 KItemViews: Internal directory restructuration
- Move all private headers from the kitemviews-directory into
the 'private' subdirectory.

- Get rid of DolphinDirLister and just use a directory-lister
  internally in KFileItemModel.

- Minor interface-cleanups for signals
2012-04-11 16:08:32 +02:00
Peter Penz
d9dbd3398a Improvements for slow sorting roles
If the sorting is done for data which is resolved asynchronously
(e.g. rating), it is important to give a visual feedback about
the state of the sorting. This is done now by a progress
indication in the statusbar.

Also optimizations for "Sort by type" have been done: Although
resolving a type can be expensive in the most often case it is a
very cheap operation. So it the sorting is done by type, try
to resolve the type synchronously for at least 200 ms to prevent
a asynchronous resorting. This is usually sufficient to have
resolved types even for directories with several thousands of
items.

BUG: 292733
FIXED-IN: 4.9.0
2012-04-10 16:36:26 +02:00
Peter Penz
e283a9f7d9 Synchronize view-mode settings before the settings dialog gets opened
BUG: 292698
FIXED-IN: 4.8.1
2012-01-30 16:38:24 +01:00
Peter Penz
1b88652b85 Renamed some signals for consistency with KItemViews classes 2011-08-29 20:14:33 +02:00
Peter Penz
f23e9496f3 Merged very early alpha-version of Dolphin 2.0
Dolphin 2.0 will get a new view-engine with the
following improvements:
- Better performance
- Animated transitions
- No clipped filenames due to dynamic item-sizes
- Grouping support for all view-modes
- Non-rectangular selection areas
- Simplified code for better maintenance

More details will be provided in a blog-entry during
the next days.

Please note that the code is in a very
early alpha-stage and although the most tricky parts
have been implemented already very basic things like
drag and drop or selections have not been pushed yet.
Those things are rather trivial to implement but this
still will take some time.
2011-07-30 20:13:41 +02:00
Peter Penz
ae488b1318 Improve usability of Search Panel
If the Search Panel is shown outside the context of the "Find" mode it
will be always enabled and does a global search. Only if the user is in
the "Find" mode and the searching is restricted to the current directory
the Search Panel might get disabled if the current directory is not
indexed. This solves the major usability issue that it was not clear
for the users whether a global or restricted search is done.
2011-04-20 20:09:08 +02:00
Sebastian Dörner
4b0dc69070 Make cursor keys always trigger a statusbar update
When the selection is changed using the cursor keys, the statusbar
should be updated. Until now, this didn't actually happen directly after
an operation ending in a OperationCompletedMessage, because the
OperationCompletedMessage was protected.

This patch changes the behaviour to only protect ErrorMessages in the
ViewContainer. When an OperationCompletedMessage was issued very
recently, it keeps being protected by DolphinStatusbar itself.

Statusbar updates in the ViewContainer are only triggered by
a) user actions (move keyboard focus, enter something in the filter bar)
b) finished filed jobs

In case a), the update is desired, also overriding
OperationCompletedMessages.
In case b), the OperationCompletedMessage issued by the file command is
issues so shortly before the call to updateStatusBar, that the
DolphinStatusBar skips the message anyway (see
DolphinStatusBar::setMessage).

BUG: 193847
FIXED-IN: 4.7.0
REVIEW: 100939
2011-03-24 22:43:45 +01:00
Peter Penz
fd74aa8e20 Update e-mail address from peter.penz@gmx.at to peter.penz19@gmail.com 2011-02-04 15:57:33 +01:00
Peter Penz
8eb9b508ca Use capitalized KDE includes 2011-02-04 15:43:21 +01:00
Peter Penz
51a4c273a0 SVN_SILENT: Coding style updates
svn path=/trunk/KDE/kdebase/apps/; revision=1216293
2011-01-22 14:08:11 +00:00
Peter Penz
bf4689bb64 Keeping DolphinDirLister and DolphinModel as DolphinViewContainers members is not needed anymore, as all the handling is encapsulated inside DolphinView in the meantime. The moving of the dirlister- and model-construction will be done after the 4.6 release, as some internal API adjustments are necessary.
svn path=/trunk/KDE/kdebase/apps/; revision=1206754
2010-12-15 18:55:25 +00:00
Peter Penz
adde3d4e3c Fix issue that the enabled state of the "Create New..." menu is not updated correctly in the column-view.
BUG: 258534
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1206749
2010-12-15 18:40:08 +00:00
Peter Penz
e587aaa9c4 Show an undetermined progress indication within one second after changing an URL.
Update to SVN commit 1205329:
- Fix issue that an undetermined progress is shown when switching between columns of the column-view.
- Fix issue that no undetermined progress is shown when editing the URL directly in the URL navigator

BUG: 234894
BUG: 163004
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1205345
2010-12-10 22:54:37 +00:00
Peter Penz
6ec1a1eb36 Allow to cancel the loading of search results.
BUG: 257421
FIXED-IN: 4.6.0


svn path=/trunk/KDE/kdebase/apps/; revision=1199112
2010-11-20 17:17:35 +00:00
Peter Penz
456d529295 Make the filter-behavior similar to applications like Kate, where activating the filter lets focus it again.
BUG: 256160
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1193912
2010-11-07 14:55:33 +00:00
Peter Penz
d83a4ce51d Rename the setter showFilterBar() to setFilterBarVisible().
svn path=/trunk/KDE/kdebase/apps/; revision=1193348
2010-11-05 17:12:35 +00:00
Peter Penz
3aa13c7a24 Assure that always the search-box is shown instead of the URL-navigator if a Nepomuk-URL is requested. We still have to think about how to show queries that cannot be represented by the facet-widget, but at least it is sure that this kind of information should not be shown by the URL navigator.
svn path=/trunk/KDE/kdebase/apps/; revision=1191912
2010-11-01 12:31:44 +00:00
Peter Penz
4383f4238e - Automatically show the filter-panel when a searching is done
- Remove filter-prototypes that conflict with the filterpanel


svn path=/trunk/KDE/kdebase/apps/; revision=1190445
2010-10-27 17:08:02 +00:00
Peter Penz
4ad4d4785c Update the statusbar also during loading the items, not only after the loading has been completed. This fixes the issue that no current item-count is shown when doing a search.
svn path=/trunk/KDE/kdebase/apps/; revision=1184520
2010-10-10 17:11:55 +00:00
Peter Penz
652d08c924 Sourcecode hierarchy cleanup: Create folder "views" and move view related sources to it
svn path=/trunk/KDE/kdebase/apps/; revision=1154146
2010-07-24 21:45:49 +00:00
Peter Penz
49eb864b03 Unify the search interface for non-indexed and indexed folders
svn path=/trunk/KDE/kdebase/apps/; revision=1154073
2010-07-24 16:37:07 +00:00
Frank Reininghaus
17ff26c355 Reorganise some code in DolphinView and DolphinViewContainer. This
makes it possible to restore the expanded folders in the Details View
when navigating in history (based on r1056438 and r1079843).

Also remove DolphinView::activateItem(const KUrl&) and DolphinView's
m_loadingDirectory member (they are not needed any more).

This will be in KDE 4.5.

BUG: 169886

svn path=/trunk/KDE/kdebase/apps/; revision=1080549
2010-01-26 12:18:08 +00:00
Peter Penz
e5eae108ca * Adjust code to use the improved KUrlNavigator API.
* Open a new tab if the URL navigator requests it.
* Get rid of a cyclic dependency between DolphinViewContainer and DolphinMainWindow.

BUG: 181223

svn path=/trunk/KDE/kdebase/apps/; revision=1079843
2010-01-25 07:58:24 +00:00
Peter Penz
2b6cceb0f6 Provide clickable resources for the Information Panel. Thanks to Sebastian Trüg für the patch!
CCMAIL: trueg@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=1051553
2009-11-19 19:38:34 +00:00
Frank Reininghaus
487215f0c4 When navigating back/forward in the DolphinPart inside Konqueror, remember
1. the current item,
2. the scroll position of the view, and
3. the expansion state of the details view.

Before 3. can be implemented in Dolphin itself, some changes in
KUrlNavigator are required.

This fix will be in KDE 4.4.

BUG: 193549
BUG: 198073
BUG: 213137

svn path=/trunk/KDE/kdebase/apps/; revision=1049164
2009-11-14 15:51:47 +00:00
Peter Penz
bd30bb6ca9 search finetuning:
* trigger progress information when starting a search
* let the information panel hide the meta data for the search string
* get the search string from the configurator

svn path=/trunk/KDE/kdebase/apps/; revision=1048721
2009-11-13 21:03:19 +00:00
Peter Penz
07f31c2087 Show a progress information when doing a Nepomuk search. As "sideeffect" some KDE3 relicts for the progress bar code have been removed too...
svn path=/trunk/KDE/kdebase/apps/; revision=1048225
2009-11-12 22:45:47 +00:00
Laurent Montel
0dd0f27f83 Fix forward declaration
svn path=/trunk/KDE/kdebase/apps/; revision=1004949
2009-07-31 07:14:20 +00:00
Peter Penz
8e6dbadef2 Fixed performance issues related to selections and deleting of files:
- Don't connect to KDirLister::itemDeleted(const KFileItem&), but KDirLister::itemsDeleted(const KFileItemList&). Otherwise Dolphin is informed about each single file deletion instead of getting the deleted items as a list. Thanks to David Faure for the hint!

- DolphinViewContainer::updateStatusBar() can be expensive when a lot of files are selected, as the file size must get retrieved. Assure that fast calls for updateStatusBar() don't trigger a synchronous update, do the update after 300 ms where no further update has been triggered.

- Dolphin provides a list of file items when emitting the selectionChanged() signal. Collecting the file items is a quite expensive operation, so use the same approach as when updating the statusbar: only emit the selection changed signal when no change has been done within 300 ms. This improves the performance when doing huge selections a lot.

- Make updateStatusBar() a private method, the main window should not need to take care about updating the statusbar (this is done internally now by DolphinViewContainer).

BUG: 199090
BUG: 195787
CCBUG: 199352
CCBUG: 188218

svn path=/trunk/KDE/kdebase/apps/; revision=995015
2009-07-11 17:48:05 +00:00
Peter Penz
a38f830144 Mark the last visitied directory as active when going back in history.
BUG: 192811

svn path=/trunk/KDE/kdebase/apps/; revision=978757
2009-06-08 05:55:46 +00:00
Peter Penz
540eeb0030 Remember the used URL completion mode of the URL navigator. Thanks to Frank Reininghaus for the patch!
BUG: 170502

svn path=/trunk/KDE/kdebase/apps/; revision=929111
2009-02-20 16:55:25 +00:00
Peter Penz
2f47863c68 - allow the view implementations to attach custom actions to the context menu
- let the "details view" show the "[x] Expandable Folders" action in the context menu

CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=924867
2009-02-11 20:45:12 +00:00
Peter Penz
3cfeee94d4 Fixed issue that the 'Create New' menu might be disabled although creating of files is allowed. Thanks to Frank Reininghaus for the patch!
BUG: 183812

svn path=/trunk/KDE/kdebase/apps/; revision=924120
2009-02-10 07:09:49 +00:00
Peter Penz
426a57997b Don't request the focus for the view because of a completed directory lister, instead directly request it when we know that the user has entered a new URL. This prevents that the focus gets stolen from the Terminal when somebody types "touch foo".
BUG: 178070

svn path=/trunk/KDE/kdebase/apps/; revision=898819
2008-12-19 06:41:26 +00:00
Peter Penz
37c5fc0813 If the users enters an URL that represents a file, open the file by the corresponding application instead of showing an error message.
BUG: 165877

svn path=/trunk/KDE/kdebase/apps/; revision=896189
2008-12-12 19:44:28 +00:00