Commit graph

3758 commits

Author SHA1 Message Date
Peter Penz acee6d0fc5 Fix inconsistency in selection manager
When a selection has been done with non-linear ranges, it was possible that
the anchor item pointed to an invalid index that resulted into an invalid
selection.

As part of this fix the sorting for DolphinView::selectedItems() has been
disabled (if the caller assumes a sorted selection he must manually adjust it).

BUG: 288908
FIXED-IN: 4.8.0
2011-12-30 00:08:37 +01:00
Script Kiddy d7a803cae0 SVN_SILENT made messages (.desktop file) 2011-12-29 10:43:55 +01:00
David Faure dec1a1b29d KDiskFreeSpace already uses KMountPoint internally, we can give it any path. 2011-12-29 09:49:12 +01:00
Peter Penz 3e9d31d293 Fix issue that dragging pictures/videos to Google-Search/YouTube fails
BUG: 289917
BUG: 278236
FIXED-IN: 4.8.0
2011-12-27 15:53:49 +01:00
Peter Penz 3f5d3cfd08 Fix issue that dragging pictures/videos to Google-Search/YouTube fails
BUG: 289917
BUG: 278236
FIXED-IN: 4.8.0
2011-12-27 15:53:23 +01:00
Peter Penz 8b977e91fb Fix group-header clipping in compact mode 2011-12-27 09:11:08 +01:00
Peter Penz 56f8ca24cc Fix group-header clipping in compact mode 2011-12-27 09:10:27 +01:00
Peter Penz 7be14d0cde Fix icon alignment issue in the details view
BUG: 289889
FIXED-IN: 4.8.0
2011-12-27 08:34:15 +01:00
Peter Penz 0fa4b713ae Fix icon alignment issue in the details view
BUG: 289889
FIXED-IN: 4.8.0
2011-12-27 08:33:42 +01:00
Peter Penz 8403383926 Minor cleanup: Rename m_keyboardAnchorXPos to m_keyboardAnchorPos 2011-12-26 22:44:26 +01:00
Peter Penz ba2c3e89f9 Minor cleanup: Rename m_keyboardAnchorXPos to m_keyboardAnchorPos 2011-12-26 22:43:20 +01:00
Peter Penz 2e2a6ae24c Improve item offset scrolling
Don't check whether the m_layoutTimer is active: Changing the
item offset must always trigger a synchronous layout, otherwise
the smooth-scrolling might get jerky.
2011-12-26 22:30:15 +01:00
Peter Penz c33c54be7d Improve item offset scrolling
Don't check whether the m_layoutTimer is active: Changing the
item offset must always trigger a synchronous layout, otherwise
the smooth-scrolling might get jerky.
2011-12-26 22:29:44 +01:00
Peter Penz 118fe89449 Fix keyboard issues when groups are enabled
When groups are enabled in Dolphin the key-up and key-down keys did not behave
consistent in comparison to traditional views or like done in editors.

CCBUG: 261995
CCBUG: 262038
2011-12-26 22:22:50 +01:00
Peter Penz 83c5692f5e Fix keyboard issues when groups are enabled
When groups are enabled in Dolphin the key-up and key-down keys did not behave
consistent in comparison to traditional views or like done in editors.

CCBUG: 261995
CCBUG: 262038
2011-12-26 22:22:04 +01:00
Peter Penz 4dc5714016 Fix grouping issue
When switching to a group that is not shown currently, the group headers
won't be updated. The root-cause was that the m_groups-cache must be reset
when the roles have been changed.

CCBUG: 289654
2011-12-25 22:38:34 +01:00
Peter Penz 6212ac6053 Fix grouping issue
When switching to a group that is not shown currently, the group headers
won't be updated. The root-cause was that the m_groups-cache must be reset
when the roles have been changed.

CCBUG: 289654
2011-12-25 22:37:44 +01:00
Peter Penz ee26791cee Fix wrong grouping of types
- Uninitialized types count as one group
- Let the receiver of the signal itemsMoved() decide whether unmoved items
  really result in an unchanged visual appearance. This might e.g. be the case
  if the grouping is turned on and the group-names change although the items
  themselves have not changed their position.

BUG: 289654
FIXED-IN: 4.8.0
2011-12-25 11:39:46 +01:00
Peter Penz a237f42ee3 Fix wrong grouping of types
- Uninitialized types count as one group
- Let the receiver of the signal itemsMoved() decide whether unmoved items
  really result in an unchanged visual appearance. This might e.g. be the case
  if the grouping is turned on and the group-names change although the items
  themselves have not changed their position.

BUG: 289654
FIXED-IN: 4.8.0
2011-12-25 11:39:17 +01:00
Peter Penz 00b0bfcd01 Fix sort-issue for trees
If a protocol like fish is used, the sorting of sub-trees was wrong. The root
cause was a wrong comparing of URLs where the protocol was not initialized.

BUG: 289697
FIXED-IN: 4.8.0
2011-12-24 14:16:10 +01:00
Peter Penz f07315deb0 Fix sort-issue for trees
If a protocol like fish is used, the sorting of sub-trees was wrong. The root
cause was a wrong comparing of URLs where the protocol was not initialized.

BUG: 289697
FIXED-IN: 4.8.0
2011-12-24 14:15:21 +01:00
Peter Penz b5b8d48bb7 Don't show the name as part of the "path" role
This allows a useful grouping by paths when e.g. searching files.

BUG: 269335
FIXED-IN: 4.8.0
2011-12-23 23:38:38 +01:00
Peter Penz f8d47e7e04 Don't show the name as part of the "path" role
This allows a useful grouping by paths when e.g. searching files.

BUG: 269335
FIXED-IN: 4.8.0
2011-12-23 23:37:53 +01:00
Peter Penz b2cb38214e Introduce "isExpandable" role
The role is used to determine whether a directory can be expanded at all. This
is e.g. not the case if a directory has 0 items or the target-URL is different
from the item-URL.

The expansion toggle will get hidden if a directory is not expandable.

CCBUG: 288521
2011-12-23 23:19:48 +01:00
Peter Penz 5f02a3e9ce Introduce "isExpandable" role
The role is used to determine whether a directory can be expanded at all. This
is e.g. not the case if a directory has 0 items or the target-URL is different
from the item-URL.

The expansion toggle will get hidden if a directory is not expandable.

CCBUG: 288521
2011-12-23 23:19:19 +01:00
Peter Penz 2cafa66f00 Fix possible double entries in details view
The patch 30ae57ba80 did not resolve the
issue completely: The pending items to insert must be dispatched before
checking for duplicates.

Related to this report the expanding for the remote-protocol has been
disabled.

BUG: 288521
FIXED-IN: 4.8.0
2011-12-23 21:15:48 +01:00
Peter Penz c2f86821b8 Fix possible double entries in details view
The patch 30ae57ba80 did not resolve the
issue completely: The pending items to insert must be dispatched before
checking for duplicates.

Related to this report the expanding for the remote-protocol has been
disabled.

BUG: 288521
FIXED-IN: 4.8.0
2011-12-23 21:14:28 +01:00
Peter Penz 6f699495b5 The key "space" should select the current item
Also in case if only one item is shown the navigation-keys should
trigger a selection of the current item. This works now consistent
within all view-modes (there have been been behavior differences
in Dolphin 1.7 depending on the used mode).

BUG: 289589
FIXED-IN: 4.8.0
2011-12-23 16:04:32 +01:00
Peter Penz 00c5d7a242 The key "space" should select the current item
Also in case if only one item is shown the navigation-keys should
trigger a selection of the current item. This works now consistent
within all view-modes (there have been been behavior differences
in Dolphin 1.7 depending on the used mode).

BUG: 289589
FIXED-IN: 4.8.0
2011-12-23 16:03:49 +01:00
Peter Penz f66f24c11e Increased version number 2011-12-23 14:39:44 +01:00
Peter Penz be1ea44cbb Increased version to 2.0 2011-12-23 14:37:47 +01:00
Script Kiddy 8129069dc8 SVN_SILENT made messages (.desktop file) 2011-12-23 10:33:39 +01:00
Peter Penz 531c88c840 Reenable drag & drop for the URL navigator
BUG: 289568
FIXED-IN: 4.8.0
2011-12-22 22:00:05 +01:00
Peter Penz 84263dd6dc Reenable drag & drop for the URL navigator
BUG: 289568
FIXED-IN: 4.8.0
2011-12-22 21:59:37 +01:00
Peter Penz 32faa14c1a Don't show child items of collapsed parent items
If a parent item got expanded and collapsed again, KDirLister keeps
the items of the previously expanded directory. Hence inserting new
items there will result in emitting the signal newItems() and a check
must be done whether the parent is still expanded.

BUG: 289598
FIXED-IN: 4.8.0
2011-12-22 21:50:30 +01:00
Peter Penz e0bbf1bf71 Don't show child items of collapsed parent items
If a parent item got expanded and collapsed again, KDirLister keeps
the items of the previously expanded directory. Hence inserting new
items there will result in emitting the signal newItems() and a check
must be done whether the parent is still expanded.

BUG: 289598
FIXED-IN: 4.8.0
2011-12-22 21:49:53 +01:00
Script Kiddy 42c07bebde SVN_SILENT made messages (.desktop file) 2011-12-22 11:37:00 +01:00
Peter Penz a63c476db2 Fix first visible index calculation
When having a row with different item-heights, the calculation of the
first visible index might have been wrong.
2011-12-21 23:19:08 +01:00
Peter Penz 2c77176c9c Fix first visible index calculation
When having a row with different item-heights, the calculation of the
first visible index might have been wrong.
2011-12-21 23:18:38 +01:00
Peter Penz 965107fd02 Update previews when the preview-plugin settings have changed
Thanks to Janardhan Reddy for the initial patch.

BUG: 288726
FIXED-IN: 4.8.0
2011-12-21 21:48:24 +01:00
Peter Penz 677f94c800 Update previews when the preview-plugin settings have changed
Thanks to Janardhan Reddy for the initial patch.

BUG: 288726
FIXED-IN: 4.8.0
2011-12-21 21:47:40 +01:00
Aaron Seigo 5e0e05e8f0 Merge remote branch 'origin/KDE/4.8'
Conflicts:
	plasma/applets/folderview/folderview.cpp
2011-12-21 17:08:23 +01:00
Script Kiddy 050e094e6b SVN_SILENT made messages (.desktop file) 2011-12-21 09:54:51 +01:00
Peter Penz a8622c7a1e Fix autoscroll issue when selecting items
If items get selected with the rubberband the scroll offset must stay inside
the visible range.

BUG: 282353
FIXED-IN: 4.8.0
2011-12-20 23:08:26 +01:00
Peter Penz e71bdb0cf6 Fix autoscroll issue when selecting items
If items get selected with the rubberband the scroll offset must stay inside
the visible range.

BUG: 282353
FIXED-IN: 4.8.0
2011-12-20 23:07:49 +01:00
Peter Penz d9e1db6ea4 Remove child items when a parent item gets deleted
BUG: 289447
FIXED-IN: 4.8.0
2011-12-20 22:30:15 +01:00
Peter Penz e76affea64 Remove child items when a parent item gets deleted
BUG: 289447
FIXED-IN: 4.8.0
2011-12-20 22:22:24 +01:00
Script Kiddy 8012fe7da2 SVN_SILENT made messages (.desktop file) 2011-12-20 16:23:36 +01:00
Peter Penz 090393599c Show an error when dragging above a folder without write access
Got OK from the translator team to add this new string.
2011-12-20 08:58:24 +01:00
Frank Reininghaus a3c41997db KFileItemModel: Always use upper case letters to group by name
This fixes the following problems:
1. In a folder containing the items ~a and b, the first group,
   containing ~a, is named "Others".
2. In a folder containing the items a, ~b, ~c, and ~d, the first group
   "A" contains a and ~b, and the other two items are in the group
   "Others".
2011-12-20 02:03:31 +01:00