Commit graph

21 commits

Author SHA1 Message Date
Felix Ernst
50ca5af7e0 Allow having the UrlNavigators below the tab bar
This commit restores the possibility to have the UrlNavigators below
the tab bar. This will happen automatically whenever the UrlNavigator
is removed from the toolbar.

It is also now again possible to have the toolbar on the side. This
option is disabled while the toolbar contains the UrlNavigators.

This commit makes no changes to the new default which is having the
UrlNavigators in the toolbar but makes sure that upgrading users won't
be affected.
2020-11-19 21:22:27 +00:00
Felix Ernst
63f4981fe0 Adress the third round of Angelaccio's review comments
Additionally remove some redundant code concerning UrlNavigator visuals.
2020-11-09 23:49:07 +01:00
Felix Ernst
a418d6229e Fix a crash and extract unrelated changes
The secondary UrlNavigator is now created when and only when:
- split view mode is activated for the active tab
OR
- switching to a tab that has split view already enabled.
This fixes a crash that occurs when the setting to always start in
split view mode is enabled.

An animation for activating split view is also removed from this and
moved into a separate MR. Another unrelated name change left over from
a previous commit (viewContainers() -> activeViewContainers()) is
dropped.
2020-11-09 23:49:07 +01:00
Felix Ernst
37327c9b0a Make UrlNavigators in the toolbar the only option
The UrlNavigators will be automatically added to the toolbar. The Sort By
action is removed from the default toolbar to make space.

Remove all options to have UrlNavigators outside the toolbar and remove
those code paths.

Make it so the new NavigatorsWidgetAction contains two UrlNavigators when
in split view mode. Spacing was also added to align these UrlNavigators
with the ViewContainers when enough space is available.

Force the toolbar to be either at the top or bottom of the window.

Set a sane sizeHint for DolphinUrlNavigator. It would be better to do this
in KUrlNavigator in the future.

This commit also contains a changes which should be moved to a separate
merge requests before this gets merged:
- Add an expansion animation when split view is enabled by the user
2020-11-09 23:49:07 +01:00
Elvis Angelaccio
954e8c4790 Output of licensedigger + manual cleanup afterwards.
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
2020-08-25 17:07:38 +00:00
Yuri Chornoivan
fd1a078cc4 Fix minor typos 2018-10-25 21:23:44 +03:00
Roman Inflianskas
48b58f830a Remove unused #include
Summary: I used CLion inspection to hunt all unused #include

Reviewers: #dolphin, elvisangelaccio, markg

Reviewed By: #dolphin, elvisangelaccio, markg

Subscribers: bcooksley, markg, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D10985
2018-03-04 21:00:47 +03:00
Kevin Funk
a6db5029ac Modernize: Use nullptr everywhere 2017-11-21 10:53:12 +01:00
Luca Beltrame
95f9dc9de0
Merge branch 'Applications/17.04' 2017-05-22 23:32:36 +02:00
Anthony Fieroni
43da84eefc Correct searchbox, split view transitions between tabs
Differential Revision: https://phabricator.kde.org/D5864

BUG: 379135
BUG: 380032
FIXED-IN: 17.04.2

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
2017-05-22 20:35:29 +03:00
Kevin Funk
f2758ec9f7 Fix some compiler warnings 2017-04-07 16:13:27 +02:00
arnav dhamija
d5e692d16d fixed arg 2017-02-13 17:08:10 +05:30
arnav dhamija
e7f6a1010a Changed default arg for the setSplitViewEnabled 2016-11-02 21:49:11 +05:30
arnav dhamija
2704b3693f Added the GUI button for quick stashing 2016-09-26 22:25:42 +05:30
Martin T. H. Sandsmark
b706108206 Use tab for switching active split
REVIEW: 128564
REVIEW: 110970
BUGS: 171743
2016-09-04 14:12:53 +02:00
Lukáš Tinkl
1b4572dac9 port Dolphin from KUrl to QUrl
REVIEW: 120688
2014-10-21 21:19:14 +02:00
Lukáš Tinkl
d9d7926c49 port Konqueror from KUrl to QUrl
REVIEW: 120650
2014-10-21 00:28:58 +02:00
Emmanuel Pescosta
2d2d55f3df Save the view states in addition to the view urls and splitter state in DolphinTabPage.
Also added version numbers to view and tab state.

REVIEW: 119792
2014-08-20 23:06:39 +02:00
Emmanuel Pescosta
39d8fb12c1 React on the redirection signal from DolphinView to properly update the tab and window titles.
REVIEW: 119697
BUG: 305721
2014-08-13 22:06:28 +02:00
Emmanuel Pescosta
38381bc6a2 Implemented DolphinTabWidget class to encapsulate the tab handling from DolphinMainWindow.
REVIEW: 119115
2014-08-10 18:52:06 +02:00
Emmanuel Pescosta
b0fb590ebd Implemented DolphinTabPage class to encapsulate the split view handling from DolphinMainWindow.
The signal activeViewUrlChanged in DolphinTabPage is currently unused, but we need it later when
we implement the tab widget and tab bar.

DolphinTabPage has saveState/restoreState which are using a QByteArray instead of the KConfigGroup to
be more generic.

REVIEW: 118964
2014-07-04 17:16:03 +02:00