Commit graph

6850 commits

Author SHA1 Message Date
Nate Graham 70e20a310a Make "don't run me with sudo/kdesu" message informative
We tell users what not to do, but we don't tell then what to do instead.
At one point we told them to just use Dolphin normally and the polkit
integration would kick in, but that work ended up being reverted and
abandoned. Instead, tell them to use kio-admin, which exists as a
released product and will hopefully not get removed anytime soon.

CCBUG: 467948
2023-04-05 16:17:56 +00:00
Felix Ernst 95905ce761 Add test for openFiles()
The basic mainWindow methods openFiles(), openDirectories(),
isUrlOpen(), and isItemVisibleInAnyView() have some non-obvious
behaviours that shouldn't regress. We never want to open
directories that are already open. We only want to open new tabs
when the currently open ones don't have the file that should be
highlighted in view already. This should work even if view modes
that allow folder expansion are in play. It should also work when
the view area is split.
2023-04-03 15:34:32 +00:00
Méven Car e190977a90 PlacesPanel: clean some warnings
NO_CHANGELOG
2023-04-03 15:34:16 +02:00
Méven Car 9061b22a0d Context menu: allow to show copy to/move to inactive split view
Prevent copying/moving to same folder as origin when copying/moving to inactive split view

BUG: 356436
2023-04-02 07:22:07 +00:00
l10n daemon script 5149ede257 GIT_SILENT made messages (after extraction) 2023-03-27 00:51:23 +00:00
l10n daemon script 080572c67a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-03-26 01:45:57 +00:00
l10n daemon script 09f25ee461 GIT_SILENT made messages (after extraction) 2023-03-26 00:50:38 +00:00
Oliver Beard 278380bf17 panels/information: Add option to not show information for hovered item
BUG: 364956
BUG: 453211
2023-03-25 10:01:52 +00:00
l10n daemon script 53eba0b14c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-03-21 01:43:27 +00:00
Méven Car 9967a5cdee Prevent dragging on non-writable directories
KFileItemModel::supportsDroppin now returns the rootItem when -1 is passed and checks for write access.
2023-03-16 14:27:52 +00:00
Méven Car 6e5460697b Prevent a non-initialized value access
NO_CHANGELOG
2023-03-09 19:00:27 +01:00
l10n daemon script 7b2a09511d SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-03-06 01:43:29 +00:00
l10n daemon script aabacff070 GIT_SILENT made messages (after extraction) 2023-03-05 00:56:55 +00:00
Ismael Asensio ba60b6ada3 search: Prevent the search box from enlarging the view
By default, the search filters widget calculates its
`minimumSizeHint` as the sum of its components' minimum widths.

This minimum width hint will scale up the widgets hierarchy,
finally imposing a minimum width to the contents view, which
in certain conditions can take the space from the side panels.

Let's set a minimum width hint of 0, so it is the filters widget
which always adapts to the available view size instead.

BUG: 466796
FIXED-IN: 23.04
2023-03-04 10:30:41 +00:00
Alexander Lohnau f8a6aba490 Remove unneeded metadata from KCM json files
We only load them in Konqueror, there are only the name, icon and doc path used.
The ServiceTypes are only a leftover from before the json conversion

Task: https://phabricator.kde.org/T14730
2023-03-04 09:22:06 +01:00
l10n daemon script 6adbb73b99 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-03-02 02:25:05 +00:00
Méven Car 6f778005b5 Save a in-thread stat call each time the context menu is displayed 2023-02-25 11:26:25 +00:00
Heiko Becker 4cf831a54e GIT_SILENT Update Appstream for new release
(cherry picked from commit 7fa24be461)
2023-02-24 20:51:45 +01:00
Nate Graham 5a5a82a0c9 Apply 1 suggestion(s) to 1 file(s) 2023-02-23 14:44:20 +00:00
Méven Car 87fc5b4e70 Move split view settings about miscellaneous 2023-02-23 14:44:20 +00:00
Felix Ernst 543378a670 Apply suggestions 2023-02-23 14:44:20 +00:00
Méven Car 77c30bddd8 Settings: move split views options to their own group 2023-02-23 14:44:20 +00:00
Méven Car 7a682f5e9c Fix header index are colIndex and not roleIndex 2023-02-23 12:29:20 +01:00
Aleix Pol 6e7a5760b4 Fix typo in m_hoveredColumnHearderRoleIndex 2023-02-21 13:16:42 +01:00
Aleix Pol fc04c8186d Fix uninitialised value
Do not read m_hoveredColumnHearderRoleIndex before it has been
initialised.

.6  0x00007fe00632182c in QList<KFileItemModel::RoleInfo>::Node::t
(this=<optimized out>, this=<optimized out>) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:153
.7  QList<KFileItemModel::RoleInfo>::at (i=3080252, this=0x7ffdf2e9bba8)
at /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:572
.8  DolphinView::eventFilter (this=0x5584bef25160,
watched=0x5584bef8a300, event=0x7ffdf2e9bd30) at
./src/views/dolphinview.cpp:978
.9  0x00007fe003ebbdda in
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*,
QEvent*) () from /lib/x86_64-linux-gnu/libQt5Core.so.5
.10 0x00007fe004b6c782 in QApplicationPrivate::notify_helper(QObject*,
QEvent*) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
.11 0x00007fe004b75411 in QApplication::notify(QObject*, QEvent*) ()
from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
.12 0x00007fe003ebc07a in QCoreApplication::notifyInternal2(QObject*,
QEvent*) () from /lib/x86_64-linux-gnu/libQt5Core.so.5
.13 0x00007fe004b72269 in QApplication::event(QEvent*) () from
/lib/x86_64-linux-gnu/libQt5Widgets.so.5
.14 0x00007fe004b6c793 in QApplicationPrivate::notify_helper(QObject*,
QEvent*) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
.15 0x00007fe003ebc07a in QCoreApplication::notifyInternal2(QObject*,
QEvent*) () from /lib/x86_64-linux-gnu/libQt5Core.so.5
.16 0x00007fe003f14e0b in QTimerInfoList::activateTimers() () from
/lib/x86_64-linux-gnu/libQt5Core.so.5
.17 0x00007fe003f15754 in ?? () from
/lib/x86_64-linux-gnu/libQt5Core.so.5
.18 0x00007fe001d20d3b in g_main_context_dispatch () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
.19 0x00007fe001d756c8 in ?? () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
.20 0x00007fe001d1e3e3 in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
.21 0x00007fe003f15ad8 in
QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>)
() from /lib/x86_64-linux-gnu/libQt5Core.so.5
.22 0x00007fe003eba99b in
QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from
/lib/x86_64-linux-gnu/libQt5Core.so.5
.23 0x00007fe003ec2f34 in QCoreApplication::exec() () from
/lib/x86_64-linux-gnu/libQt5Core.so.5
.24 0x00005584bd2a9aad in main (argc=<optimized out>, argv=<optimized
out>) at ./src/main.cpp:249

BUG: 466110
2023-02-21 13:15:37 +01:00
Méven Car da7ccef488 DolphinView: Allow to have tootips on columns headers
Add events columnHovered/columnUnHovered to KItemListview and
KItemListHeaderWidget.
2023-02-18 16:01:44 +00:00
Alexander Lohnau 54f62d22b0 Allow empty metadata for KOverlayIconPlugin
We do not read the metadata anywhere, consequently we can allow empty metadata.
Consumers now don't have to provide a file and we do no spend time parsing the JSON.

Task: https://phabricator.kde.org/T14538
2023-02-15 09:36:31 +00:00
Yuri Chornoivan 6b00c8b911 Consistent naming in tooltips 2023-02-15 09:02:49 +02:00
Méven Car a34768747f Fix a disconnect warning
NO_CHANGELOG
2023-02-14 18:26:40 +01:00
Serg Podtynnyi b7fa85a33d Add new settings for permissions column format
Ability to configure column for the file/dir permissions in
Numeric(Octal)/Textual/Combined style and update field display style to be right-alighed.
Add toolips to column menu items
BUG: 227745
2023-02-14 16:40:33 +00:00
Méven Car bb686052c7
Revert "Remove deprecated ConfigurePreviewPluginDialog"
This reverts commit d8de1c37e5.
2023-02-14 17:03:43 +01:00
Méven Car 1c98a50d83
Revert "Remove deprecated KServiceTypeTrader"
This reverts commit 648c2db6e4.
2023-02-14 17:03:33 +01:00
Nicolas Fella 4fbc5302e7 Fix 'Show Target' for non-local URLs
Links are not always local files, e.g. 'remote:/zeroconf' links to 'zeroconf:/'

The current code fails there

Instead of using QFile API that does not work on non-local URLs use QUrl::resolved to resolve relative links

Furthermore, QFile::exists doesn't work for non-local URLs. Instead do a KIO stat to check whether the target exists
2023-02-14 14:54:29 +01:00
Méven Car ba930ddb36 Optimize Directory size counting
Two changes:
 * Prioritise size counting for visible path
 * stop the worker when switching dirs
2023-02-12 11:21:53 +00:00
l10n daemon script d185e21887 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-02-12 02:02:18 +00:00
l10n daemon script f885d2f1be GIT_SILENT made messages (after extraction) 2023-02-12 01:01:24 +00:00
Dāvis Mosāns 648c2db6e4 Remove deprecated KServiceTypeTrader 2023-02-10 09:44:23 +00:00
Dāvis Mosāns d8de1c37e5 Remove deprecated ConfigurePreviewPluginDialog 2023-02-10 09:44:23 +00:00
Friso Smit b168f9a98b Fix zooming for high resolution scroll wheels
BUG: 432671
2023-02-09 16:28:29 +00:00
Forest ix c57c5384fc Reveal the Backspace shortcut in the UI
Since the Back action already has two standard shortcuts, a third one appended
to the list will be invisible in the UI, which shows only the first two.  This
leaves users unable to reassign it.

We therefore make it the first shortcut in the list, so that the hidden third
entry will be the dedicated Back button, which users are far less likely to
want reassigned.

BUG: 371130
2023-02-09 11:17:26 +00:00
Andrew Gunnerson 34e0a5488e KFileItemModelRolesUpdater: Skip directory item count if it isSlow()
This makes the behavior of kernel cifs/nfs mounts the same as with kio's
smb://. It also helps reduce the chance of the UI hanging due to
opendir/readdir slowing down stat calls on the UI thread.

Signed-off-by: Andrew Gunnerson <accounts+kde@chiller3.com>
2023-02-09 09:18:35 +00:00
Alexander Volkov 24cc1483bc Avoid crash on start when help actions are restricted through the Kiosk system
This was first applied in 0ac57fbe90,
but then "reverted" in 3ccdcc2176 by
misunderstanding.
2023-02-09 09:09:21 +00:00
Serg Podtynnyi 36dfe5795f Selects next item in list after delete/trash actions
BUG: 419914
BUG: 181214
2023-02-06 10:47:49 +07:00
Serg Podtynnyi 38c34eeca3 Add clang-format and format code as in Frameworks 2023-02-05 12:45:38 +07:00
Serg Podtynnyi a9ac1f1252 Add Page count and Publisher columns
BUG: 374561
2023-02-04 22:14:46 +07:00
Davide Garberi f0d201dcf1 dolphinview: Fix right click broken on placeholderLabel
* This commit fixes the right click context menu not being shown
  whenever the click is made right on the placeholderLabel text

Signed-off-by: Davide Garberi <dade.garberi@gmail.com>
2023-02-01 10:20:09 +00:00
l10n daemon script 572f4d2e9a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-01-30 02:05:00 +00:00
l10n daemon script 4a3ddf29f9 GIT_SILENT made messages (after extraction) 2023-01-30 01:00:43 +00:00
Heiko Becker 9eb780a288 GIT_SILENT Update Appstream for new release
(cherry picked from commit dd7a4fc0e8)
2023-01-29 23:39:25 +01:00
Bharadwaj Raju 3c48004086 Fix sudo message
We don't have KIO PolKit support yet
2023-01-29 10:46:12 +00:00